Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14187

Update ZooKeeper dependency to 3.4.9 and Curator dependency to 2.12.0

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is a update for using Apache Curator which shades guava.

      Why is Curator updated to 2.12.0 instead of 3.3.0?
      It's because Curator 3.x only supports ZooKeeper 3.5.x. ZooKeeper 3.5.x is still alpha release. Hence, I think we should do conservative choice here.

        Issue Links

          Activity

          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Verified patch by using tests on my local in case that our test script cannot detect the changes:

          mvn install test -Dtest=TestZKDelegationTokenSecretManager,TestChildReaper,TestKDiag,TestDelegationTokenRenewer,TestSubmitApplicationWithRMHA,TestLeaderElectorService,TestRMHAForNodeLabels,TestZKRMStateStorePerf,TestKillApplicationWithRMHA,TestRMStoreCommands,TestZKRMStateStore,TestRMRestart,TestZKRMStateStoreZKClientConnections,TestReservationSystemWithRMHA
          
          Show
          ozawa Tsuyoshi Ozawa added a comment - Verified patch by using tests on my local in case that our test script cannot detect the changes: mvn install test -Dtest=TestZKDelegationTokenSecretManager,TestChildReaper,TestKDiag,TestDelegationTokenRenewer,TestSubmitApplicationWithRMHA,TestLeaderElectorService,TestRMHAForNodeLabels,TestZKRMStateStorePerf,TestKillApplicationWithRMHA,TestRMStoreCommands,TestZKRMStateStore,TestRMRestart,TestZKRMStateStoreZKClientConnections,TestReservationSystemWithRMHA
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 12m 19s trunk passed
          +1 compile 0m 9s trunk passed
          +1 mvnsite 0m 11s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          +1 javadoc 0m 9s trunk passed
          +1 mvninstall 0m 7s the patch passed
          +1 compile 0m 6s the patch passed
          +1 javac 0m 6s the patch passed
          +1 mvnsite 0m 8s the patch passed
          +1 mvneclipse 0m 7s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 6s the patch passed
          +1 unit 0m 6s hadoop-project in the patch passed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          14m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-14187
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12858988/HADOOP-14187.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 77b3c9bebe28 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d69a82c
          Default Java 1.8.0_121
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11833/testReport/
          modules C: hadoop-project U: hadoop-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11833/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 19s trunk passed +1 compile 0m 9s trunk passed +1 mvnsite 0m 11s trunk passed +1 mvneclipse 0m 10s trunk passed +1 javadoc 0m 9s trunk passed +1 mvninstall 0m 7s the patch passed +1 compile 0m 6s the patch passed +1 javac 0m 6s the patch passed +1 mvnsite 0m 8s the patch passed +1 mvneclipse 0m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 6s the patch passed +1 unit 0m 6s hadoop-project in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 14m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14187 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12858988/HADOOP-14187.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 77b3c9bebe28 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d69a82c Default Java 1.8.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11833/testReport/ modules C: hadoop-project U: hadoop-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11833/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Could anyone take a look at the patch?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Could anyone take a look at the patch?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. Thanks Tsuyoshi Ozawa.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. Thanks Tsuyoshi Ozawa .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Tsuyoshi Ozawa for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Tsuyoshi Ozawa for the contribution.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11436 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11436/)
          HADOOP-14187. Update ZooKeeper dependency to 3.4.9 and Curator (aajisaka: rev 74af0bdf68d56f02e92dad2411b26d1cde3dc703)

          • (edit) hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11436 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11436/ ) HADOOP-14187 . Update ZooKeeper dependency to 3.4.9 and Curator (aajisaka: rev 74af0bdf68d56f02e92dad2411b26d1cde3dc703) (edit) hadoop-project/pom.xml

            People

            • Assignee:
              ozawa Tsuyoshi Ozawa
              Reporter:
              ozawa Tsuyoshi Ozawa
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development