Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14166

Reset the DecayRpcScheduler AvgResponseTime metric to zero when queue is not used

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
    • Component/s: common
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

       "name" : "Hadoop:service=NameNode,name=DecayRpcSchedulerMetrics2.ipc.8020",
          "modelerType" : "DecayRpcSchedulerMetrics2.ipc.8020",
          "tag.Context" : "ipc.8020",
          "tag.Hostname" : "host1",
          "DecayedCallVolume" : 3,
          "UniqueCallers" : 1,
          "Caller(root).Volume" : 266,
          "Caller(root).Priority" : 3,
          "Priority.0.AvgResponseTime" : 6.151201023385511E-5,
          "Priority.1.AvgResponseTime" : 0.0,
          "Priority.2.AvgResponseTime" : 0.0,
          "Priority.3.AvgResponseTime" : 1.184686336544601,
          "Priority.0.CompletedCallVolume" : 0,
          "Priority.1.CompletedCallVolume" : 0,
          "Priority.2.CompletedCallVolume" : 0,
          "Priority.3.CompletedCallVolume" : 2,
          "CallVolume" : 266
      

      "Priority.0.AvgResponseTime" is always "6.151201023385511E-5" even the queue is not used for long time.

            if (lastAvg > PRECISION || averageResponseTime > PRECISION) {
              if (enableDecay) {
                final double decayed = decayFactor * lastAvg + averageResponseTime;
                LOG.info("Decayed "  + i + " time " +   decayed);
                responseTimeAvgInLastWindow.set(i, decayed);
              } else {
                responseTimeAvgInLastWindow.set(i, averageResponseTime);
              }
            }
      

      we should reset it to zero when above condition is false.

      1. HADOOP-14166.001.patch
        0.8 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached initial patch..
          Please review...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached initial patch.. Please review...
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Chris Li/Ming Ma can you please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Chris Li / Ming Ma can you please review..
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Xiaoyu Yao Pls can you review ?

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Xiaoyu Yao Pls can you review ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 14m 3s trunk passed
          +1 compile 13m 49s trunk passed
          +1 checkstyle 0m 34s trunk passed
          +1 mvnsite 1m 6s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 0m 48s trunk passed
          +1 mvninstall 0m 38s the patch passed
          +1 compile 14m 31s the patch passed
          +1 javac 14m 31s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 1m 11s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 52s the patch passed
          +1 unit 9m 29s hadoop-common in the patch passed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          64m 15s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14166
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12857078/HADOOP-14166.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f7dcbd7b9048 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b6f66b0
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 3s trunk passed +1 compile 13m 49s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 21s trunk passed -1 findbugs 1m 23s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 14m 31s the patch passed +1 javac 14m 31s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 11s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 52s the patch passed +1 unit 9m 29s hadoop-common in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 64m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14166 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12857078/HADOOP-14166.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f7dcbd7b9048 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b6f66b0 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Surendra Singh Lilhore for reporting the issue and post the fix. The patch looks good to me. +1

          Show
          xyao Xiaoyu Yao added a comment - Thanks Surendra Singh Lilhore for reporting the issue and post the fix. The patch looks good to me. +1
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          +1, will commit shortly.

          Show
          brahmareddy Brahma Reddy Battula added a comment - +1, will commit shortly.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Committed to trunk,branch-2 and branch-2.8. Surendra Singh Lilhore thanks for your contribution. it's nice finding.. Xiaoyu Yao thanks for additional review.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Committed to trunk , branch-2 and branch-2.8 . Surendra Singh Lilhore thanks for your contribution. it's nice finding.. Xiaoyu Yao thanks for additional review.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Brahma Reddy Battula for review and commit.
          Thanks Xiaoyu Yao for review...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Brahma Reddy Battula for review and commit. Thanks Xiaoyu Yao for review...
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11773 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11773/)
          HADOOP-14166. Reset the DecayRpcScheduler AvgResponseTime metric to zero (brahma: rev dcf4559ebdb5bb11d03b264a9875bff316b89eef)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11773 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11773/ ) HADOOP-14166 . Reset the DecayRpcScheduler AvgResponseTime metric to zero (brahma: rev dcf4559ebdb5bb11d03b264a9875bff316b89eef) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              surendrasingh Surendra Singh Lilhore
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development