[HADOOP-14158] Possible for modified configuration to leak into metadatastore in S3GuardTool

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 3.0.0-beta1
• Component/s: fs/s3
• Assignee: Unassigned
• Reporter: Sean Mackrory
• Created: 08/Mar/17 15:45
• Updated: 27/Feb/21 10:57
• Resolved: 27/Feb/21 10:57

Description

It doesn't appear to do it when run from the command-line, but when running the S3GuardTool.run (i.e. the parent function of most of the functions used in the unit tests) from a unit test, you end up with a NullMetadataStore, regardless of what else was configured.

We create an instance of S3AFileSystem with the metadata store implementation overridden to NullMetadataStore so that we have distinct interfaces to S3 and the metadata store. S3Guard can later be called using this filesystem, causing it to pick up the filesystem's configuration, which instructs it to use the NullMetadataStore implementation. This shouldn't be possible.

It is unknown if this happens in any real-world scenario - I've been unable to reproduce the problem from the command-line. But it definitely happens in a test, it shouldn't, and fixing this will at least allow HADOOP-14145 to have an automated test.

Issue Links

• relates to: HADOOP-14220 Enhance S3GuardTool with bucket-info and set-capacity commands, tests