Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14150

Implement getHomeDirectory() method in NativeAzureFileSystem

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: fs/azure
    • Labels:
      None

      Description

      org.apache.hadoop.fs.azure.NativeAzureFileSystem does not override FileSystem#getHomeDirectory() method.
      So, whenever NativeAzureFileSystem#getHomeDirectory() gets called getHomeDirectory() from FileSystem will be invoked, which has code like below,

      public Path getHomeDirectory() {
          return this.makeQualified(
              new Path(USER_HOME_PREFIX + "/" + System.getProperty("user.name")));
        }
      

      In secure environment, it returns home directory of System.getProperty("user.name") instead of Kerberos principal/UGI.
      So, the proposal is to override the getHomeDirectory() method in NativeAzureFileSystem and have it return the home directory for the Kerberos principal/ugi.

      1. HADOOP-14150.1.patch
        2 kB
        Santhosh G Nayak

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11368 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11368/)
        HADOOP-14150. Implement getHomeDirectory() method in (liuml07: rev 28daaf0eb206d723d2baf0f9d91e43d98bb2fd26)

        • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11368 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11368/ ) HADOOP-14150 . Implement getHomeDirectory() method in (liuml07: rev 28daaf0eb206d723d2baf0f9d91e43d98bb2fd26) (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Committed to trunk and branch-2 branches. Thanks for your contribution Santhosh G Nayak.

        Show
        liuml07 Mingliang Liu added a comment - Committed to trunk and branch-2 branches. Thanks for your contribution Santhosh G Nayak .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 11m 56s trunk passed
        +1 compile 0m 13s trunk passed
        +1 checkstyle 0m 11s trunk passed
        +1 mvnsite 0m 17s trunk passed
        +1 mvneclipse 0m 20s trunk passed
        +1 findbugs 0m 24s trunk passed
        +1 javadoc 0m 11s trunk passed
        +1 mvninstall 0m 15s the patch passed
        +1 compile 0m 14s the patch passed
        +1 javac 0m 14s the patch passed
        -0 checkstyle 0m 9s hadoop-tools/hadoop-azure: The patch generated 1 new + 27 unchanged - 1 fixed = 28 total (was 28)
        +1 mvnsite 0m 15s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 9s the patch passed
        +1 unit 1m 24s hadoop-azure in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        18m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-14150
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856437/HADOOP-14150.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bbb30531f618 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1598fd3
        Default Java 1.8.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11771/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11771/testReport/
        modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11771/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 11m 56s trunk passed +1 compile 0m 13s trunk passed +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 17s trunk passed +1 mvneclipse 0m 20s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 15s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed -0 checkstyle 0m 9s hadoop-tools/hadoop-azure: The patch generated 1 new + 27 unchanged - 1 fixed = 28 total (was 28) +1 mvnsite 0m 15s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 1m 24s hadoop-azure in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 18m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14150 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856437/HADOOP-14150.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bbb30531f618 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1598fd3 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11771/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11771/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11771/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        +1 pending on Jenkins.

        Show
        liuml07 Mingliang Liu added a comment - +1 pending on Jenkins.
        Hide
        liuml07 Mingliang Liu added a comment -

        Submitting the patch to trigger pre-commit run and also sets the target versions both branch-2 and trunk. Correct me if I'm wrong, thanks Santhosh G Nayak!

        Show
        liuml07 Mingliang Liu added a comment - Submitting the patch to trigger pre-commit run and also sets the target versions both branch-2 and trunk. Correct me if I'm wrong, thanks Santhosh G Nayak !
        Hide
        snayak Santhosh G Nayak added a comment -

        Attaching initial version of the patch containing proposed changes.

        Show
        snayak Santhosh G Nayak added a comment - Attaching initial version of the patch containing proposed changes.

          People

          • Assignee:
            snayak Santhosh G Nayak
            Reporter:
            nmaheshwari Namit Maheshwari
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development