Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13204 Über-jira: S3a phase III: scale and tuning
  3. HADOOP-14135

Remove URI parameter in AWSCredentialProvider constructors

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.9.0, 3.0.0-alpha4, 2.8.2
    • fs/s3
    • None

    Description

      This was from comment in HADOOP-13252.
      It looks like the URI parameter is not needed for our AWSCredentialProvider constructors. This was useful because we relied on URI parameter for retrieving user:pass. Now in binding URIs, we have

      279 S3xLoginHelper.Login creds = getAWSAccessKeys(binding, conf);
      280	      credentials.add(new BasicAWSCredentialsProvider(
      281	              creds.getUser(), creds.getPassword()));
      

      This way, we only need configuration object (if necessary) for all AWSCredentialProvider implementations. The benefit is that, if we create AWSCredentialProvider list for DynamoDB, we don't have to pass down the associated file system URI. This might be useful to S3Guard tools.

      Attachments

        1. HADOOP-14135.003.patch
          18 kB
          Mingliang Liu
        2. HADOOP-14135.002.patch
          17 kB
          Mingliang Liu
        3. HADOOP-14135.001.patch
          17 kB
          Mingliang Liu
        4. HADOOP-14135.000.patch
          17 kB
          Mingliang Liu

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            liuml07 Mingliang Liu
            liuml07 Mingliang Liu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment