Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14097

Remove Java6 specific code from GzipCodec.java

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:

      Description

      GzipCodec has Java 6 specific code and it can be removed.

      GzipCodec.java
            public static final String JVMVersion= System.getProperty("java.version");
            private static final boolean HAS_BROKEN_FINISH =
                (IBM_JAVA && JVMVersion.contains("1.6.0"));
      

      Hadoop 2.7+ dropped Java 6 support.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11300 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11300/)
          HADOOP-14097. Remove Java6 specific code from GzipCodec.java. (aajisaka: rev 50decd36130945e184734dcd55b8912be6f4550a)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/GzipCodec.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11300 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11300/ ) HADOOP-14097 . Remove Java6 specific code from GzipCodec.java. (aajisaka: rev 50decd36130945e184734dcd55b8912be6f4550a) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/GzipCodec.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Filed HADOOP-14119.

          Show
          ajisakaa Akira Ajisaka added a comment - Filed HADOOP-14119 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I found there are some unused imports after committing this (sorry for that). I'll file a separate jira to track this.

          Show
          ajisakaa Akira Ajisaka added a comment - I found there are some unused imports after committing this (sorry for that). I'll file a separate jira to track this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Elek, Marton for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Elek, Marton for the contribution.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this shortly.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this shortly.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 12m 23s trunk passed
          +1 compile 12m 28s trunk passed
          +1 checkstyle 0m 34s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 26s trunk passed
          +1 javadoc 0m 47s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 10m 47s the patch passed
          +1 javac 10m 47s the patch passed
          +1 checkstyle 0m 35s the patch passed
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 32s the patch passed
          +1 javadoc 0m 47s the patch passed
          -1 unit 8m 6s hadoop-common in the patch failed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          55m 15s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-14097
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12854444/HDFS-14097.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3ce17089d3e0 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9c22a91
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11707/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11707/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11707/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 23s trunk passed +1 compile 12m 28s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 26s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 10m 47s the patch passed +1 javac 10m 47s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 47s the patch passed -1 unit 8m 6s hadoop-common in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 55m 15s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14097 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12854444/HDFS-14097.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3ce17089d3e0 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9c22a91 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11707/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11707/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11707/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          elek Elek, Marton added a comment -

          Removed the code intoduced by HADOOP-8419 (except unit test)

          Show
          elek Elek, Marton added a comment - Removed the code intoduced by HADOOP-8419 (except unit test)
          Hide
          elek Elek, Marton added a comment -

          Link to the original issue where the workaround has been introduced.

          Show
          elek Elek, Marton added a comment - Link to the original issue where the workaround has been introduced.

            People

            • Assignee:
              elek Elek, Marton
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development