Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14058

Fix NativeS3FileSystemContractBaseTest#testDirWithDifferentMarkersWorks

    Details

      Description

      In NativeS3FileSystemContractBaseTest#testDirWithDifferentMarkersWorks,

            else if (i == 3) {
              // test both markers
              store.storeEmptyFile(base + "_$folder$");
              store.storeEmptyFile(base + "/dir_$folder$");
              store.storeEmptyFile(base + "/");
              store.storeEmptyFile(base + "/dir/");
            }
      

      the above test code is not executed. In the following code:

          for (int i = 0; i < 3; i++) {
      

      < should be <=.

      1. HADOOP-14058-HADOOP-13345.001.patch
        0.8 kB
        Yiqun Lin
      2. HADOOP-14058.001.patch
        0.8 kB
        Yiqun Lin

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11245 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11245/)
        HADOOP-14058. Fix (aajisaka: rev b9f8491252f5a23a91a1d695d748556a0fd803ae)

        • (edit) hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/NativeS3FileSystemContractBaseTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11245 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11245/ ) HADOOP-14058 . Fix (aajisaka: rev b9f8491252f5a23a91a1d695d748556a0fd803ae) (edit) hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/NativeS3FileSystemContractBaseTest.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution and thanks Steve Loughran for the comments.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution and thanks Steve Loughran for the comments.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, ran the subclasses of NativeS3FileSystemContract (ITestInMemoryNativeS3FileSystemContract and ITestJets3tNativeS3FileSystemContract) and they passed.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, ran the subclasses of NativeS3FileSystemContract (ITestInMemoryNativeS3FileSystemContract and ITestJets3tNativeS3FileSystemContract) and they passed.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Afraid I will have to be strict and say "no tests, no review". sorry, but we have to be consistent.

        I'm not going near s3n for now: if anyone can do a test run that'd be great

        Show
        stevel@apache.org Steve Loughran added a comment - Afraid I will have to be strict and say "no tests, no review". sorry, but we have to be consistent. I'm not going near s3n for now: if anyone can do a test run that'd be great
        Hide
        linyiqun Yiqun Lin added a comment -

        what is important is that you need to confirm that you've tested against an object store:

        Hi Steve, I am not able to test against an object store in my local now. Feel free to assign this JIRA to yourself and make this JIRA go ahead.

        Show
        linyiqun Yiqun Lin added a comment - what is important is that you need to confirm that you've tested against an object store: Hi Steve, I am not able to test against an object store in my local now. Feel free to assign this JIRA to yourself and make this JIRA go ahead.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        no need to declare a branch; if it's against trunk you can skip a suffix, if it's branch-2 then use -branch-2 as the suffix

        what is important is that you need to confirm that you've tested against an object store: the way we do this is require that the patch submitter says which s3 endpoint they ran their tests against.

        Show
        stevel@apache.org Steve Loughran added a comment - no need to declare a branch; if it's against trunk you can skip a suffix, if it's branch-2 then use -branch-2 as the suffix what is important is that you need to confirm that you've tested against an object store: the way we do this is require that the patch submitter says which s3 endpoint they ran their tests against.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 14m 3s HADOOP-13345 passed
        +1 compile 0m 20s HADOOP-13345 passed
        +1 checkstyle 0m 14s HADOOP-13345 passed
        +1 mvnsite 0m 22s HADOOP-13345 passed
        +1 mvneclipse 0m 21s HADOOP-13345 passed
        +1 findbugs 0m 32s HADOOP-13345 passed
        +1 javadoc 0m 15s HADOOP-13345 passed
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 20s the patch passed
        +1 javac 0m 20s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 23s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 38s the patch passed
        +1 javadoc 0m 13s the patch passed
        +1 unit 0m 41s hadoop-aws in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        21m 15s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-14058
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851309/HADOOP-14058-HADOOP-13345.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ab84f30e9d78 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision HADOOP-13345 / a7e6dbe
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11593/testReport/
        modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11593/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 3s HADOOP-13345 passed +1 compile 0m 20s HADOOP-13345 passed +1 checkstyle 0m 14s HADOOP-13345 passed +1 mvnsite 0m 22s HADOOP-13345 passed +1 mvneclipse 0m 21s HADOOP-13345 passed +1 findbugs 0m 32s HADOOP-13345 passed +1 javadoc 0m 15s HADOOP-13345 passed +1 mvninstall 0m 23s the patch passed +1 compile 0m 20s the patch passed +1 javac 0m 20s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 0m 41s hadoop-aws in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 21m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14058 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851309/HADOOP-14058-HADOOP-13345.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ab84f30e9d78 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision HADOOP-13345 / a7e6dbe Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11593/testReport/ modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11593/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Hi Steve Loughran, did you mean that I should add the HADOOP-13345 as the suffix of patch name? And this patch should be ran under this feature branch? I'm not so familiar with this, please let me know if I am not understanding correctly. Attach the patch.

        Show
        linyiqun Yiqun Lin added a comment - Hi Steve Loughran , did you mean that I should add the HADOOP-13345 as the suffix of patch name? And this patch should be ran under this feature branch? I'm not so familiar with this, please let me know if I am not understanding correctly. Attach the patch.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        As per all object store patches, can you declare which S3 endpoint you ran the tests against?

        Sorry for being so strict, but demanding it for every single patch in those modules is how we compensate for yetus not testing the blobstores

        Show
        stevel@apache.org Steve Loughran added a comment - As per all object store patches, can you declare which S3 endpoint you ran the tests against? Sorry for being so strict, but demanding it for every single patch in those modules is how we compensate for yetus not testing the blobstores
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 18s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 20s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 27s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 15s the patch passed
        +1 compile 0m 15s the patch passed
        +1 javac 0m 15s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 17s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 31s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 0m 19s hadoop-aws in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        19m 13s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-14058
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851073/HADOOP-14058.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6fdbe9b1cf64 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3ea6d35
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11586/testReport/
        modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11586/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 18s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 20s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 15s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 17s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 0m 19s hadoop-aws in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 19m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14058 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851073/HADOOP-14058.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6fdbe9b1cf64 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3ea6d35 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11586/testReport/ modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11586/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        Attach a simple patch to make a quick fix.

        Show
        linyiqun Yiqun Lin added a comment - - edited Attach a simple patch to make a quick fix.

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development