Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14055

SwiftRestClient includes pass length in exception if auth fails

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      SwiftRestClient.exec(M method) throws SwiftAuthenticationFailedException if auth fails and its message will contain the pass length that may leak into logs.
      Fix is trivial.

      1. HADOOP-14055.01.patch
        0.8 kB
        Marcell Hegedus
      2. HADOOP-14055.02.patch
        0.8 kB
        Marcell Hegedus

        Activity

        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1. Thanks Marcell Hegedus.

        Steve Loughran this change looks safe to me but I'll hold off committing until next week just in case you have any comments.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1. Thanks Marcell Hegedus . Steve Loughran this change looks safe to me but I'll hold off committing until next week just in case you have any comments.
        Hide
        marcellhegedus Marcell Hegedus added a comment -

        Build failed when accessing git. Attaching again to restart build.

        Show
        marcellhegedus Marcell Hegedus added a comment - Build failed when accessing git. Attaching again to restart build.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 50s trunk passed
        +1 compile 0m 14s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 15s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 25s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 12s the patch passed
        +1 compile 0m 12s the patch passed
        +1 javac 0m 12s the patch passed
        +1 checkstyle 0m 10s hadoop-tools/hadoop-openstack: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
        +1 mvnsite 0m 12s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 0m 12s hadoop-openstack in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        19m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-14055
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851643/HADOOP-14055.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 55e4ea4ce8d7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / eec52e1
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11598/testReport/
        modules C: hadoop-tools/hadoop-openstack U: hadoop-tools/hadoop-openstack
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11598/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 50s trunk passed +1 compile 0m 14s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 15s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 12s the patch passed +1 compile 0m 12s the patch passed +1 javac 0m 12s the patch passed +1 checkstyle 0m 10s hadoop-tools/hadoop-openstack: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) +1 mvnsite 0m 12s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 0m 12s hadoop-openstack in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 19m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14055 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851643/HADOOP-14055.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 55e4ea4ce8d7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eec52e1 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11598/testReport/ modules C: hadoop-tools/hadoop-openstack U: hadoop-tools/hadoop-openstack Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11598/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        marcellhegedus Marcell Hegedus added a comment -

        Arpit Agarwal, could you commit the patch, please?

        Show
        marcellhegedus Marcell Hegedus added a comment - Arpit Agarwal , could you commit the patch, please?
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Committed this to trunk and branch-2. Thanks for the contribution Marcell Hegedus.

        Show
        arpitagarwal Arpit Agarwal added a comment - Committed this to trunk and branch-2. Thanks for the contribution Marcell Hegedus .
        Hide
        marcellhegedus Marcell Hegedus added a comment -
        Show
        marcellhegedus Marcell Hegedus added a comment - Thanks Arpit Agarwal
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11232 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11232/)
        HADOOP-14055. SwiftRestClient includes pass length in exception if auth (arp: rev 2b7a7bbe0f2ad0b3434c4dcf1f60051920d5b532)

        • (edit) hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/auth/PasswordCredentials.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11232 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11232/ ) HADOOP-14055 . SwiftRestClient includes pass length in exception if auth (arp: rev 2b7a7bbe0f2ad0b3434c4dcf1f60051920d5b532) (edit) hadoop-tools/hadoop-openstack/src/main/java/org/apache/hadoop/fs/swift/auth/PasswordCredentials.java

          People

          • Assignee:
            marcellhegedus Marcell Hegedus
            Reporter:
            marcellhegedus Marcell Hegedus
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development