Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14029

Fix KMSClientProvider for non-secure proxyuser use case

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: common,kms
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The issue was found after HADOOP-13988 by Hadoop-HDFS test (TestAclsEndToEnd). Sorry both Jenkins and I was not able to catch it.

      HADOOP-13988 fixed the issue for KMSClientProvider secure proxy user(token) use case. But the non-secure proxy user case should not be affected by the new logic. The ticket is open to fix it.

      1. HADOOP-14029.00.patch
        2 kB
        Xiaoyu Yao
      2. HADOOP-14029.01.patch
        2 kB
        Xiaoyu Yao

        Issue Links

          Activity

          Hide
          xyao Xiaoyu Yao added a comment - - edited

          Attach a patch that address the non-secure proxy user case for KMSClientProvider where we don't need to fallback to loginUGI in any case. cc: Xiao Chen Thanks!

          Show
          xyao Xiaoyu Yao added a comment - - edited Attach a patch that address the non-secure proxy user case for KMSClientProvider where we don't need to fallback to loginUGI in any case. cc: Xiao Chen Thanks!
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Xiaoyu Yao for the quick turnaround.

          Fix lgtm. Do you think it'd be helpful to add a comment to the KMSCP change, to say sth like 'login is only necessary for kerberos auth'?

          Show
          xiaochen Xiao Chen added a comment - Thanks Xiaoyu Yao for the quick turnaround. Fix lgtm. Do you think it'd be helpful to add a comment to the KMSCP change, to say sth like 'login is only necessary for kerberos auth'?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 14m 18s trunk passed
          +1 compile 13m 26s trunk passed
          +1 checkstyle 0m 36s trunk passed
          +1 mvnsite 2m 5s trunk passed
          +1 mvneclipse 0m 36s trunk passed
          +1 findbugs 2m 4s trunk passed
          +1 javadoc 1m 12s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 58s the patch passed
          +1 compile 12m 29s the patch passed
          +1 javac 12m 29s the patch passed
          +1 checkstyle 0m 34s the patch passed
          +1 mvnsite 2m 4s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 24s the patch passed
          +1 javadoc 1m 10s the patch passed
          +1 unit 8m 31s hadoop-common in the patch passed.
          +1 unit 2m 17s hadoop-kms in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          71m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-14029
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849631/HADOOP-14029.00.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c430b800f0c0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7bc333a
          Default Java 1.8.0_121
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11521/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11521/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 14m 18s trunk passed +1 compile 13m 26s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 2m 5s trunk passed +1 mvneclipse 0m 36s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 12s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 58s the patch passed +1 compile 12m 29s the patch passed +1 javac 12m 29s the patch passed +1 checkstyle 0m 34s the patch passed +1 mvnsite 2m 4s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 24s the patch passed +1 javadoc 1m 10s the patch passed +1 unit 8m 31s hadoop-common in the patch passed. +1 unit 2m 17s hadoop-kms in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 71m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14029 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849631/HADOOP-14029.00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c430b800f0c0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7bc333a Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11521/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11521/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Xiao Chen for the review. Update patch v01 to update the comment and debug log. I plan to commit it shortly.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Xiao Chen for the review. Update patch v01 to update the comment and debug log. I plan to commit it shortly.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Xiao Chen for the review. I've commit the fix to trunk and branch-2.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Xiao Chen for the review. I've commit the fix to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11183 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11183/)
          HADOOP-14029. Fix KMSClientProvider for non-secure proxyuser use case. (xyao: rev 2034315763cd7b1eb77e96c719918fc14e2dabf6)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java
          • (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11183 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11183/ ) HADOOP-14029 . Fix KMSClientProvider for non-secure proxyuser use case. (xyao: rev 2034315763cd7b1eb77e96c719918fc14e2dabf6) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Xiaoyu Yao, +1 on patch 1 FWIW. Happy new year

          Show
          xiaochen Xiao Chen added a comment - Thanks Xiaoyu Yao , +1 on patch 1 FWIW. Happy new year
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 25s Maven dependency ordering for branch
          +1 mvninstall 13m 13s trunk passed
          +1 compile 12m 53s trunk passed
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 1m 55s trunk passed
          +1 mvneclipse 0m 36s trunk passed
          +1 findbugs 1m 58s trunk passed
          +1 javadoc 1m 7s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 0m 54s the patch passed
          +1 compile 10m 57s the patch passed
          +1 javac 10m 57s the patch passed
          +1 checkstyle 0m 35s the patch passed
          +1 mvnsite 1m 53s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 1m 6s the patch passed
          +1 unit 8m 15s hadoop-common in the patch passed.
          +1 unit 2m 15s hadoop-kms in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          66m 52s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-14029
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849646/HADOOP-14029.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 15a70af61250 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7bc333a
          Default Java 1.8.0_121
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11522/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11522/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvninstall 13m 13s trunk passed +1 compile 12m 53s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 55s trunk passed +1 mvneclipse 0m 36s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 7s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 0m 54s the patch passed +1 compile 10m 57s the patch passed +1 javac 10m 57s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 14s the patch passed +1 javadoc 1m 6s the patch passed +1 unit 8m 15s hadoop-common in the patch passed. +1 unit 2m 15s hadoop-kms in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 66m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14029 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849646/HADOOP-14029.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 15a70af61250 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7bc333a Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11522/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11522/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              xyao Xiaoyu Yao
              Reporter:
              xyao Xiaoyu Yao
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development