Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13999

Add -DskipShade maven profile to disable jar shading to reduce compile time

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2, HADOOP-13345
    • Component/s: build
    • Labels:
      None

      Description

      Adding a maven profile to disable client jar shading

      1. HADOOP-13999.001.patch
        64 kB
        Arun Suresh
      2. HADOOP-13999.002.patch
        64 kB
        Arun Suresh

        Activity

        Hide
        asuresh Arun Suresh added a comment -

        Attaching initial patch

        Show
        asuresh Arun Suresh added a comment - Attaching initial patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 7s HADOOP-13999 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HADOOP-13999
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848092/HADOOP-13999.001.patch
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11457/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HADOOP-13999 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-13999 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848092/HADOOP-13999.001.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11457/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        busbey Sean Busbey added a comment - - edited

        We can't use active by default because it would mean activating the release profile would disable running the shade plugin.

        Instead, you should add a profile that sets the needed skip properties to not shade.

        Show
        busbey Sean Busbey added a comment - - edited We can't use active by default because it would mean activating the release profile would disable running the shade plugin. Instead, you should add a profile that sets the needed skip properties to not shade.
        Hide
        asuresh Arun Suresh added a comment -

        Updating patch:
        Rebased with trunk and incorporated Sean's suggestion. Thanks for the rev.
        Shading will be suppressed using a property and invoking mvn like so:

        $ mvn clean install -DskipShade -DskipTests=true
        
        Show
        asuresh Arun Suresh added a comment - Updating patch: Rebased with trunk and incorporated Sean's suggestion. Thanks for the rev. Shading will be suppressed using a property and invoking mvn like so: $ mvn clean install -DskipShade -DskipTests=true
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 33s Maven dependency ordering for branch
        +1 mvninstall 12m 45s trunk passed
        +1 compile 0m 16s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 51s trunk passed
        +1 javadoc 0m 38s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 6m 30s the patch passed
        +1 compile 0m 13s the patch passed
        +1 javac 0m 13s the patch passed
        +1 mvnsite 0m 39s the patch passed
        +1 mvneclipse 0m 39s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 5s The patch has no ill-formed XML file.
        +1 javadoc 0m 27s the patch passed
        +1 unit 0m 9s hadoop-client-api in the patch passed.
        +1 unit 0m 8s hadoop-client-runtime in the patch passed.
        +1 unit 0m 10s hadoop-client-minicluster in the patch passed.
        +1 unit 0m 7s hadoop-client-integration-tests in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        26m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13999
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848111/HADOOP-13999.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux c3b534865c24 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9130af3
        Default Java 1.8.0_111
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11460/testReport/
        modules C: hadoop-client-modules/hadoop-client-api hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster hadoop-client-modules/hadoop-client-integration-tests U: hadoop-client-modules
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11460/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 33s Maven dependency ordering for branch +1 mvninstall 12m 45s trunk passed +1 compile 0m 16s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 51s trunk passed +1 javadoc 0m 38s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 6m 30s the patch passed +1 compile 0m 13s the patch passed +1 javac 0m 13s the patch passed +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 5s The patch has no ill-formed XML file. +1 javadoc 0m 27s the patch passed +1 unit 0m 9s hadoop-client-api in the patch passed. +1 unit 0m 8s hadoop-client-runtime in the patch passed. +1 unit 0m 10s hadoop-client-minicluster in the patch passed. +1 unit 0m 7s hadoop-client-integration-tests in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 26m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13999 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848111/HADOOP-13999.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux c3b534865c24 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9130af3 Default Java 1.8.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11460/testReport/ modules C: hadoop-client-modules/hadoop-client-api hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster hadoop-client-modules/hadoop-client-integration-tests U: hadoop-client-modules Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11460/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1

        tested locally, works great!

        committed to s3guard branch alongside trunk; there may be some merge issues later on, but I'll deal with that by reverting this one prior to the next merge-from-trunk

        Show
        stevel@apache.org Steve Loughran added a comment - +1 tested locally, works great! committed to s3guard branch alongside trunk; there may be some merge issues later on, but I'll deal with that by reverting this one prior to the next merge-from-trunk
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11145 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11145/)
        HADOOP-13999 Add -DskipShade maven profile to disable jar shading to (stevel: rev 85e4961f60b7f8cd1343b6f2b9f4c8bb1a5de6ac)

        • (edit) hadoop-client-modules/hadoop-client-runtime/pom.xml
        • (edit) hadoop-client-modules/hadoop-client-minicluster/pom.xml
        • (edit) hadoop-client-modules/hadoop-client-api/pom.xml
        • (edit) hadoop-client-modules/hadoop-client-integration-tests/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11145 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11145/ ) HADOOP-13999 Add -DskipShade maven profile to disable jar shading to (stevel: rev 85e4961f60b7f8cd1343b6f2b9f4c8bb1a5de6ac) (edit) hadoop-client-modules/hadoop-client-runtime/pom.xml (edit) hadoop-client-modules/hadoop-client-minicluster/pom.xml (edit) hadoop-client-modules/hadoop-client-api/pom.xml (edit) hadoop-client-modules/hadoop-client-integration-tests/pom.xml

          People

          • Assignee:
            asuresh Arun Suresh
            Reporter:
            asuresh Arun Suresh
          • Votes:
            2 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development