Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha2, HADOOP-13345
    • HADOOP-13345
    • build, fs/azure, fs/s3
    • None

    Description

      Other people aren't seeing this (yet?), but unless you explicitly exclude v 3.4 of commons-lang3 from the azure build (which HADOOP-13660 does), then the dependency declaration of commons-lang3 v 3.3.2 is creating a resolution conflict. That's a dependency only needed for the local dynamodb & tests.

      I propose to fix this in s3guard by explicitly declaring the version used in the tests to be that of the azure-storage one, excluding that you get for free. It doesn't impact anything shipped in production, but puts the hadoop build in control of what versions of commons-lang are coming in everywhere by way of the commons-config version declared in hadoop-common

      Attachments

        Issue Links

        Activity

          stevel@apache.org Steve Loughran added a comment -

          patch 001, includes the ddb exclusions needed for s3guard, so the patch is against that

          stevel@apache.org Steve Loughran added a comment - patch 001, includes the ddb exclusions needed for s3guard, so the patch is against that
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-13994 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-13994 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-13994 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847906/HADOOP-13994-HADOOP-13445-001.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11455/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          stevel@apache.org Steve Loughran added a comment -

          patch 001 named correctly for Yetus to apply to the right branch

          stevel@apache.org Steve Loughran added a comment - patch 001 named correctly for Yetus to apply to the right branch
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 2m 8s Maven dependency ordering for branch
          -1 mvninstall 3m 51s root in HADOOP-13345 failed.
          +1 compile 10m 14s HADOOP-13345 passed
          +1 mvnsite 1m 50s HADOOP-13345 passed
          +1 mvneclipse 1m 7s HADOOP-13345 passed
          +1 javadoc 1m 24s HADOOP-13345 passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 5s the patch passed
          +1 compile 9m 46s the patch passed
          +1 javac 9m 46s the patch passed
          +1 mvnsite 1m 47s the patch passed
          +1 mvneclipse 0m 56s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 4s The patch has no ill-formed XML file.
          +1 javadoc 1m 25s the patch passed
          +1 unit 0m 14s hadoop-project in the patch passed.
          +1 unit 7m 56s hadoop-common in the patch passed.
          +1 unit 0m 43s hadoop-aws in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          46m 43s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13994
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848047/HADOOP-13994-HADOOP-13345-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 2716826f61a3 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision HADOOP-13345 / f10114c
          Default Java 1.8.0_111
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11456/artifact/patchprocess/branch-mvninstall-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11456/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11456/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 2m 8s Maven dependency ordering for branch -1 mvninstall 3m 51s root in HADOOP-13345 failed. +1 compile 10m 14s HADOOP-13345 passed +1 mvnsite 1m 50s HADOOP-13345 passed +1 mvneclipse 1m 7s HADOOP-13345 passed +1 javadoc 1m 24s HADOOP-13345 passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 5s the patch passed +1 compile 9m 46s the patch passed +1 javac 9m 46s the patch passed +1 mvnsite 1m 47s the patch passed +1 mvneclipse 0m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 4s The patch has no ill-formed XML file. +1 javadoc 1m 25s the patch passed +1 unit 0m 14s hadoop-project in the patch passed. +1 unit 7m 56s hadoop-common in the patch passed. +1 unit 0m 43s hadoop-aws in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 46m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13994 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848047/HADOOP-13994-HADOOP-13345-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 2716826f61a3 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision HADOOP-13345 / f10114c Default Java 1.8.0_111 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11456/artifact/patchprocess/branch-mvninstall-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11456/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11456/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          stevel@apache.org Steve Loughran added a comment -

          there's no tests here. Not sure why mvn install failed

          stevel@apache.org Steve Loughran added a comment - there's no tests here. Not sure why mvn install failed
          busbey Sean Busbey added a comment -

          the build problem is

          [INFO] --- maven-enforcer-plugin:1.4.1:enforce (depcheck) @ hadoop-hdfs ---
          [WARNING] 
          Dependency convergence error for org.apache.hadoop:hadoop-kms:3.0.0-alpha2-SNAPSHOT paths to dependency are:
          +-org.apache.hadoop:hadoop-hdfs:3.0.0-alpha2-SNAPSHOT
            +-org.apache.hadoop:hadoop-kms:3.0.0-alpha2-SNAPSHOT
          and
          +-org.apache.hadoop:hadoop-hdfs:3.0.0-alpha2-SNAPSHOT
            +-org.apache.hadoop:hadoop-kms:3.0.0-alpha2-20170118.094916-987
          
          [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
          Failed while enforcing releasability the error(s) are [
          Dependency convergence error for org.apache.hadoop:hadoop-kms:3.0.0-alpha2-SNAPSHOT paths to dependency are:
          +-org.apache.hadoop:hadoop-hdfs:3.0.0-alpha2-SNAPSHOT
            +-org.apache.hadoop:hadoop-kms:3.0.0-alpha2-SNAPSHOT
          and
          +-org.apache.hadoop:hadoop-hdfs:3.0.0-alpha2-SNAPSHOT
            +-org.apache.hadoop:hadoop-kms:3.0.0-alpha2-20170118.094916-987
          ]
          

          This usually happens when one module picks up a previously created or published SNAPSHOT and then a different one picks up the SNAPSHOT from the current reactor build. I don't think I've seen it from the same module. There aren't duplicate declarations of the hadoop-kms dependency in hadoop-hdfs right?

          In any case, an install failure in the branch doesn't matter to the patch if the patch passes (which it did).

          Change looks reasonable to me. +1 (non-binding)

          busbey Sean Busbey added a comment - the build problem is [INFO] --- maven-enforcer-plugin:1.4.1:enforce (depcheck) @ hadoop-hdfs --- [WARNING] Dependency convergence error for org.apache.hadoop:hadoop-kms:3.0.0-alpha2-SNAPSHOT paths to dependency are: +-org.apache.hadoop:hadoop-hdfs:3.0.0-alpha2-SNAPSHOT +-org.apache.hadoop:hadoop-kms:3.0.0-alpha2-SNAPSHOT and +-org.apache.hadoop:hadoop-hdfs:3.0.0-alpha2-SNAPSHOT +-org.apache.hadoop:hadoop-kms:3.0.0-alpha2-20170118.094916-987 [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message: Failed while enforcing releasability the error(s) are [ Dependency convergence error for org.apache.hadoop:hadoop-kms:3.0.0-alpha2-SNAPSHOT paths to dependency are: +-org.apache.hadoop:hadoop-hdfs:3.0.0-alpha2-SNAPSHOT +-org.apache.hadoop:hadoop-kms:3.0.0-alpha2-SNAPSHOT and +-org.apache.hadoop:hadoop-hdfs:3.0.0-alpha2-SNAPSHOT +-org.apache.hadoop:hadoop-kms:3.0.0-alpha2-20170118.094916-987 ] This usually happens when one module picks up a previously created or published SNAPSHOT and then a different one picks up the SNAPSHOT from the current reactor build. I don't think I've seen it from the same module. There aren't duplicate declarations of the hadoop-kms dependency in hadoop-hdfs right? In any case, an install failure in the branch doesn't matter to the patch if the patch passes (which it did). Change looks reasonable to me. +1 (non-binding)
          aajisaka Akira Ajisaka added a comment -

          LGTM, +1.

          aajisaka Akira Ajisaka added a comment - LGTM, +1.
          aajisaka Akira Ajisaka added a comment -

          Committed this to HADOOP-13345 branch. Thanks Steve Loughran for the contribution and thanks Sean Busbey for the review.

          aajisaka Akira Ajisaka added a comment - Committed this to HADOOP-13345 branch. Thanks Steve Loughran for the contribution and thanks Sean Busbey for the review.
          liuml07 Mingliang Liu added a comment - - edited

          Sorry Steve Loughran I missed this point when I did the merge from trunk to HADOOP-13345 feature branch. When I merged, I was still thinking that we didn't have to exclude this dependency explicitly in DDBLocal. Then I realized that the AWS shaded uber jar does not include DDBLocal package (which clearly has its own maven repository).

          1. Should we make this a subtask of HADOOP-13345 Uber JIRA? Tracking there seems helpful to me at least.
          2. Should we file a new JIRA to add this effort back (only need change in hadoop-tools/hadoop-aws/pom.xml for DDBLocal exclusion tag), or re-open this and commit an addendum patch?

          Thanks!

          liuml07 Mingliang Liu added a comment - - edited Sorry Steve Loughran I missed this point when I did the merge from trunk to HADOOP-13345 feature branch. When I merged, I was still thinking that we didn't have to exclude this dependency explicitly in DDBLocal. Then I realized that the AWS shaded uber jar does not include DDBLocal package (which clearly has its own maven repository). Should we make this a subtask of HADOOP-13345 Uber JIRA? Tracking there seems helpful to me at least. Should we file a new JIRA to add this effort back (only need change in hadoop-tools/hadoop-aws/pom.xml for DDBLocal exclusion tag), or re-open this and commit an addendum patch? Thanks!
          stevel@apache.org Steve Loughran added a comment -

          Just reopen this and sync up the diff.

          It might be good to split into the "bits for trunk" and the special case for DDB

          stevel@apache.org Steve Loughran added a comment - Just reopen this and sync up the diff. It might be good to split into the "bits for trunk" and the special case for DDB

          People

            stevel@apache.org Steve Loughran Assign to me
            stevel@apache.org Steve Loughran
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack