Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13963

/bin/bash is hard coded in some of the scripts

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      /bin/bash is hard coded in some of the scripts. We should consider using #!/usr/bin/env bash at the beginning instead.
      Candidates:
      hadoop-functions_test_helper.bash
      start-build-env.sh
      findHangingTest.sh
      verify-xml.sh
      hadoop_env_checks.sh

        Issue Links

          Activity

          Hide
          miklos.szegedi@cloudera.com Miklos Szegedi added a comment -

          This bug was opened based on the discussion with Allen Wittenauer in YARN-6060.

          Show
          miklos.szegedi@cloudera.com Miklos Szegedi added a comment - This bug was opened based on the discussion with Allen Wittenauer in YARN-6060 .
          Hide
          ajayydv Ajay Kumar added a comment -

          Miklos Szegedi I have made the changes. Please review the patch.

          Show
          ajayydv Ajay Kumar added a comment - Miklos Szegedi I have made the changes. Please review the patch.
          Hide
          miklos.szegedi@cloudera.com Miklos Szegedi added a comment -

          LGTM (non-binding). Thank you for the patch Ajay Kumar. Allen Wittenauer do you have time to take a look?

          Show
          miklos.szegedi@cloudera.com Miklos Szegedi added a comment - LGTM (non-binding). Thank you for the patch Ajay Kumar . Allen Wittenauer do you have time to take a look?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 30s Maven dependency ordering for branch
          +1 mvninstall 14m 0s trunk passed
          +1 mvnsite 10m 26s trunk passed
                Patch Compile Tests
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvnsite 10m 17s the patch passed
          +1 shellcheck 0m 1s There were no new shellcheck issues.
          +1 shelldocs 0m 10s There were no new shelldocs issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
                Other Tests
          +1 unit 16m 43s root in the patch passed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          54m 50s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-13963
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879871/HADOOP-13963.01.patch
          Optional Tests asflicense mvnsite unit shellcheck shelldocs
          uname Linux 16b7b92faff4 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 91f120f
          shellcheck v0.4.6
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12916/testReport/
          modules C: hadoop-common-project/hadoop-common . U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12916/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 1m 30s Maven dependency ordering for branch +1 mvninstall 14m 0s trunk passed +1 mvnsite 10m 26s trunk passed       Patch Compile Tests 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvnsite 10m 17s the patch passed +1 shellcheck 0m 1s There were no new shellcheck issues. +1 shelldocs 0m 10s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 unit 16m 43s root in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 54m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-13963 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879871/HADOOP-13963.01.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 16b7b92faff4 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 91f120f shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12916/testReport/ modules C: hadoop-common-project/hadoop-common . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12916/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 lgtm. I will commit this shortly.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 lgtm. I will commit this shortly.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed to trunk.

          Thanks for the contribution Ajay Kumar and thanks for the review Miklos Szegedi.

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed to trunk. Thanks for the contribution Ajay Kumar and thanks for the review Miklos Szegedi .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12119 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12119/)
          HADOOP-13963. /bin/bash is hard coded in some of the scripts. (arp: rev a6fdeb8a872d413c76257a32914ade1d0e944583)

          • (edit) dev-support/verify-xml.sh
          • (edit) dev-support/findHangingTest.sh
          • (edit) hadoop-common-project/hadoop-common/src/test/scripts/hadoop-functions_test_helper.bash
          • (edit) dev-support/docker/hadoop_env_checks.sh
          • (edit) start-build-env.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12119 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12119/ ) HADOOP-13963 . /bin/bash is hard coded in some of the scripts. (arp: rev a6fdeb8a872d413c76257a32914ade1d0e944583) (edit) dev-support/verify-xml.sh (edit) dev-support/findHangingTest.sh (edit) hadoop-common-project/hadoop-common/src/test/scripts/hadoop-functions_test_helper.bash (edit) dev-support/docker/hadoop_env_checks.sh (edit) start-build-env.sh
          Hide
          ajayydv Ajay Kumar added a comment -

          Thanks Arpit!

          Show
          ajayydv Ajay Kumar added a comment - Thanks Arpit!

            People

            • Assignee:
              ajayydv Ajay Kumar
              Reporter:
              miklos.szegedi@cloudera.com Miklos Szegedi
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development