Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13955

Replace deprecated HttpServer2 and SSLFactory constants

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      +underlined text+A follow-up to HADOOP-13597. Fix these javac warnings about deprecated constants:

      [WARNING] /testptch/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java:[139,20] [deprecation] DEFAULT_SSL_REQUIRE_CLIENT_CERT in SSLFactory has been deprecated
      [WARNING] /testptch/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java:[148,27] [deprecation] HTTP_MAX_THREADS in HttpServer2 has been deprecated
      [WARNING] /testptch/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java:[85,27] [deprecation] HTTP_MAX_THREADS in HttpServer2 has been deprecated
      [WARNING] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/DatanodeHttpServer.java:[99,40] [deprecation] HTTP_MAX_THREADS in HttpServer2 has been deprecated
      
      1. HADOOP-13955.001.patch
        6 kB
        John Zhuge
      2. HADOOP-13955.002.patch
        7 kB
        John Zhuge

        Issue Links

          Activity

          Hide
          jzhuge John Zhuge added a comment -

          Patch 001:

          • Remove deprecated HTTP_MAX_THREADS and DEFAULT_SSL_REQUIRE_CLIENT_CERT
          Show
          jzhuge John Zhuge added a comment - Patch 001: Remove deprecated HTTP_MAX_THREADS and DEFAULT_SSL_REQUIRE_CLIENT_CERT
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 12m 41s trunk passed
          +1 compile 9m 47s trunk passed
          +1 checkstyle 1m 37s trunk passed
          +1 mvnsite 2m 3s trunk passed
          +1 mvneclipse 0m 37s trunk passed
          +1 findbugs 3m 19s trunk passed
          +1 javadoc 1m 39s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 33s the patch passed
          +1 compile 9m 36s the patch passed
          +1 javac 9m 36s root generated 0 new + 690 unchanged - 4 fixed = 690 total (was 694)
          +1 checkstyle 1m 38s the patch passed
          +1 mvnsite 2m 5s the patch passed
          +1 mvneclipse 0m 44s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 45s the patch passed
          +1 javadoc 1m 44s the patch passed
          +1 unit 8m 54s hadoop-common in the patch passed.
          -1 unit 70m 43s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          157m 48s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
          Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13955
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847491/HADOOP-13955.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e36c3bdf866d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2604e82
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11440/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11440/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 12m 41s trunk passed +1 compile 9m 47s trunk passed +1 checkstyle 1m 37s trunk passed +1 mvnsite 2m 3s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 3m 19s trunk passed +1 javadoc 1m 39s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 33s the patch passed +1 compile 9m 36s the patch passed +1 javac 9m 36s root generated 0 new + 690 unchanged - 4 fixed = 690 total (was 694) +1 checkstyle 1m 38s the patch passed +1 mvnsite 2m 5s the patch passed +1 mvneclipse 0m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 45s the patch passed +1 javadoc 1m 44s the patch passed +1 unit 8m 54s hadoop-common in the patch passed. -1 unit 70m 43s hadoop-hdfs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 157m 48s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13955 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847491/HADOOP-13955.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e36c3bdf866d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2604e82 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11440/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11440/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11440/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Mostly looks good to me. Can we remove SSL_ENABLED_PROTOCOLS and DEFAULT_SSL_ENABLED_PROTOCOLS as well?

          Show
          ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. Can we remove SSL_ENABLED_PROTOCOLS and DEFAULT_SSL_ENABLED_PROTOCOLS as well?
          Hide
          jzhuge John Zhuge added a comment -
          Show
          jzhuge John Zhuge added a comment - Sure Akira Ajisaka .
          Hide
          jzhuge John Zhuge added a comment -

          Patch 002

          • Deprecate SSL_ENABLED_PROTOCOLS and DEFAULT_SSL_ENABLED_PROTOCOLS
          Show
          jzhuge John Zhuge added a comment - Patch 002 Deprecate SSL_ENABLED_PROTOCOLS and DEFAULT_SSL_ENABLED_PROTOCOLS
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 2m 2s Maven dependency ordering for branch
          +1 mvninstall 14m 1s trunk passed
          +1 compile 11m 37s trunk passed
          +1 checkstyle 1m 55s trunk passed
          +1 mvnsite 2m 48s trunk passed
          +1 mvneclipse 0m 47s trunk passed
          +1 findbugs 3m 51s trunk passed
          +1 javadoc 1m 50s trunk passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 1m 50s the patch passed
          +1 compile 12m 23s the patch passed
          +1 javac 12m 23s root generated 0 new + 671 unchanged - 4 fixed = 671 total (was 675)
          +1 checkstyle 1m 46s the patch passed
          +1 mvnsite 2m 38s the patch passed
          +1 mvneclipse 0m 49s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 22s the patch passed
          +1 javadoc 2m 10s the patch passed
          +1 unit 9m 16s hadoop-common in the patch passed.
          -1 unit 100m 57s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 44s The patch does not generate ASF License warnings.
          200m 51s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
          Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13955
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847939/HADOOP-13955.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ec22dfa3caa5 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 47dfda7
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11451/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11451/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 2m 2s Maven dependency ordering for branch +1 mvninstall 14m 1s trunk passed +1 compile 11m 37s trunk passed +1 checkstyle 1m 55s trunk passed +1 mvnsite 2m 48s trunk passed +1 mvneclipse 0m 47s trunk passed +1 findbugs 3m 51s trunk passed +1 javadoc 1m 50s trunk passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 1m 50s the patch passed +1 compile 12m 23s the patch passed +1 javac 12m 23s root generated 0 new + 671 unchanged - 4 fixed = 671 total (was 675) +1 checkstyle 1m 46s the patch passed +1 mvnsite 2m 38s the patch passed +1 mvneclipse 0m 49s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 22s the patch passed +1 javadoc 2m 10s the patch passed +1 unit 9m 16s hadoop-common in the patch passed. -1 unit 100m 57s hadoop-hdfs in the patch failed. +1 asflicense 0m 44s The patch does not generate ASF License warnings. 200m 51s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13955 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847939/HADOOP-13955.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ec22dfa3caa5 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 47dfda7 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11451/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11451/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          All 4 failed unit tests are unrelated and they pass locally.

          Show
          jzhuge John Zhuge added a comment - All 4 failed unit tests are unrelated and they pass locally.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, checking this in.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks John Zhuge for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks John Zhuge for the contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11134 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11134/)
          HADOOP-13955. Replace deprecated HttpServer2 and SSLFactory constants. (aajisaka: rev 9130af3f74a7923fff3f80360ba043ab2c6558a9)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/DatanodeHttpServer.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11134 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11134/ ) HADOOP-13955 . Replace deprecated HttpServer2 and SSLFactory constants. (aajisaka: rev 9130af3f74a7923fff3f80360ba043ab2c6558a9) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/DatanodeHttpServer.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
          Hide
          jzhuge John Zhuge added a comment -

          Thanks @akira for the review and commit.

          Show
          jzhuge John Zhuge added a comment - Thanks @akira for the review and commit.

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              jzhuge John Zhuge
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development