Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13951

Precommit builds do not adequately protect against test malformed fs permissions.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Critical
    • Resolution: Unresolved
    • None
    • None
    • test
    • None

    Description

      Right now this is expressed as failed Precommit-YARN-build jobs when they run on H5 / H6 (see INFRA-13148), but the problem exists for all of the hadoop related precommit jobs.

      The issue is that we have some tests in Common (and maybe HDFS) that purposefully set permissions within the target/ directory to simulate a failure to interact with underlying fs data. The test sets some subdirectories to have permissions such that we can no longer delete their contents.

      Right now our precommit jobs include a step post-yetus-test-patch that traverses the target directories and ensures that all subdirectories are modifiable:

      find ${WORKSPACE} -name target | xargs chmod -R u+w
      

      Unfortunately, if we don't get to that line (say due to an aborted build, or if the call to yetus test-patch exceeds the job timeout), then we are left in a state where there are still subdirectories that can't be modified (including deleted).

      Our builds also currently attempt to run a git clean at the very start of the build after the repo is updated. If we have one of the aforementioned timeouts that leaves a can't-be-deleted test directory, then all future builds on that machine will fail attempting to run the git clean command.

      Attachments

        Activity

          People

            Unassigned Unassigned
            busbey Sean Busbey
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated: