Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13943

TestCommonConfigurationFields#testCompareXmlAgainstConfigurationClass fails after HADOOP-13863

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None

      Description

      File core-default.xml (153 properties)
      
      core-default.xml has 3 properties missing in  class org.apache.hadoop.fs.CommonConfigurationKeys  class org.apache.hadoop.fs.CommonConfigurationKeysPublic  class org.apache.hadoop.fs.local.LocalConfigKeys  class org.apache.hadoop.fs.ftp.FtpConfigKeys  class org.apache.hadoop.ha.SshFenceByTcpPort  class org.apache.hadoop.security.LdapGroupsMapping  class org.apache.hadoop.ha.ZKFailoverController  class org.apache.hadoop.security.ssl.SSLFactory  class org.apache.hadoop.security.CompositeGroupsMapping  class org.apache.hadoop.io.erasurecode.CodecUtil
      
        fs.azure.sas.expiry.period
        fs.azure.local.sas.key.mode
        fs.azure.secure.mode
      

      Referece
      https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/266/testReport/junit/org.apache.hadoop.conf/TestCommonConfigurationFields/testCompareXmlAgainstConfigurationClass/

      1. HADOOP-13943-002.patch
        1 kB
        Brahma Reddy Battula
      2. HADOOP-13943.patch
        1 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka thanks for review and commit.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks for review and commit.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11040 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11040/)
          HADOOP-13943. (aajisaka: rev 0665c5f09afb2d6f59b6c4d4980f8b1ff9cbe620)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11040 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11040/ ) HADOOP-13943 . (aajisaka: rev 0665c5f09afb2d6f59b6c4d4980f8b1ff9cbe620) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for the contribution.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, checking this in.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 13m 43s trunk passed
          +1 compile 9m 45s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 2s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 24s trunk passed
          +1 javadoc 0m 48s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 9m 4s the patch passed
          +1 javac 9m 4s the patch passed
          +1 checkstyle 0m 28s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 31s the patch passed
          +1 javadoc 0m 47s the patch passed
          +1 unit 8m 28s hadoop-common in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          52m 13s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13943
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844649/HADOOP-13943.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 288c9ffefe7f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ea54752
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11328/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11328/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 43s trunk passed +1 compile 9m 45s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 4s the patch passed +1 javac 9m 4s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 8m 28s hadoop-common in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 52m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13943 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844649/HADOOP-13943.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 288c9ffefe7f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea54752 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11328/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11328/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka thanks for taking a look..

          Is there any specific reason to use xmlPrefixToSkipCompare instead of xmlPropsToSkipCompare?

          No..Updated patch to address this..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks for taking a look.. Is there any specific reason to use xmlPrefixToSkipCompare instead of xmlPropsToSkipCompare? No..Updated patch to address this..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Brahma Reddy Battula for reporting this and providing the patch!

            xmlPrefixToSkipCompare.add("fs.azure.sas.expiry.period");
          

          Is there any specific reason to use xmlPrefixToSkipCompare instead of xmlPropsToSkipCompare?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for reporting this and providing the patch! xmlPrefixToSkipCompare.add( "fs.azure.sas.expiry.period" ); Is there any specific reason to use xmlPrefixToSkipCompare instead of xmlPropsToSkipCompare ?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 12m 27s trunk passed
          +1 compile 9m 37s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 23s trunk passed
          +1 javadoc 0m 48s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 9m 14s the patch passed
          +1 javac 9m 14s the patch passed
          +1 checkstyle 0m 28s the patch passed
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 31s the patch passed
          +1 javadoc 0m 48s the patch passed
          +1 unit 8m 29s hadoop-common in the patch passed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          50m 55s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13943
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844649/HADOOP-13943.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d25c6a3fd6b6 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c721f78
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11326/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11326/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 27s trunk passed +1 compile 9m 37s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 14s the patch passed +1 javac 9m 14s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 48s the patch passed +1 unit 8m 29s hadoop-common in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 50m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13943 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844649/HADOOP-13943.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d25c6a3fd6b6 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c721f78 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11326/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11326/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Uploaded the patch.Kindly Review.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch.Kindly Review.

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              brahmareddy Brahma Reddy Battula
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development