Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13933

Add haadmin -getAllServiceState option to get the HA state of all the NameNodes/ResourceManagers

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.9.0, 3.0.0-alpha2, 2.8.3
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently we have one command to get state of namenode.

      ./hdfs haadmin -getServiceState <serviceId>
      

      It will be good to have command which will give state of all the namenodes.

      1. HDFS-9559.01.patch
        5 kB
        Surendra Singh Lilhore
      2. HADOOP-13933.006.patch
        19 kB
        Surendra Singh Lilhore
      3. HADOOP-13933.005.patch
        17 kB
        Surendra Singh Lilhore
      4. HADOOP-13933.004.patch
        16 kB
        Surendra Singh Lilhore
      5. HADOOP-13933.003.patch
        16 kB
        Surendra Singh Lilhore
      6. HADOOP-13933.003.patch
        16 kB
        Surendra Singh Lilhore
      7. HADOOP-13933.002.patch
        13 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached initial path..

          Added new command in haadmin

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached initial path.. Added new command in haadmin
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          New command :

          ./hdfs haadmin -getAllServiceState
          

          Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - New command : ./hdfs haadmin -getAllServiceState Please review..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 32s trunk passed
          +1 compile 7m 40s trunk passed with JDK v1.8.0_66
          +1 compile 8m 34s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 57s trunk passed
          +1 mvnsite 1m 52s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 37s trunk passed
          +1 javadoc 1m 58s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 47s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 34s the patch passed
          +1 compile 7m 54s the patch passed with JDK v1.8.0_66
          +1 javac 7m 54s the patch passed
          +1 compile 8m 38s the patch passed with JDK v1.7.0_91
          +1 javac 8m 38s the patch passed
          -1 checkstyle 0m 58s Patch generated 1 new checkstyle issues in root (total was 27, now 28).
          +1 mvnsite 1m 53s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 56s the patch passed
          +1 javadoc 1m 59s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 50s the patch passed with JDK v1.7.0_91
          -1 unit 6m 44s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 52m 58s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 7m 26s hadoop-common in the patch passed with JDK v1.7.0_91.
          -1 unit 52m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 29s Patch generated 58 ASF License warnings.
          188m 27s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.TestDFSClientRetries
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockReplacement



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778005/HDFS-9559.01.patch
          JIRA Issue HDFS-9559
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 00e175c925fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7092d47
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13895/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13895/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 32s trunk passed +1 compile 7m 40s trunk passed with JDK v1.8.0_66 +1 compile 8m 34s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 57s trunk passed +1 mvnsite 1m 52s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 1m 58s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 47s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 34s the patch passed +1 compile 7m 54s the patch passed with JDK v1.8.0_66 +1 javac 7m 54s the patch passed +1 compile 8m 38s the patch passed with JDK v1.7.0_91 +1 javac 8m 38s the patch passed -1 checkstyle 0m 58s Patch generated 1 new checkstyle issues in root (total was 27, now 28). +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 59s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 50s the patch passed with JDK v1.7.0_91 -1 unit 6m 44s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 52m 58s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 7m 26s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 52m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 29s Patch generated 58 ASF License warnings. 188m 27s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestDFSClientRetries JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778005/HDFS-9559.01.patch JIRA Issue HDFS-9559 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 00e175c925fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7092d47 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13895/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13895/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13895/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Please can someone review this jira?

          This command is useful in multiple namenode cluster ( HDFS-6440 ).

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Please can someone review this jira? This command is useful in multiple namenode cluster ( HDFS-6440 ).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 55s Maven dependency ordering for branch
          +1 mvninstall 9m 26s trunk passed
          +1 compile 13m 7s trunk passed with JDK v1.8.0_74
          +1 compile 11m 37s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 37s trunk passed
          +1 mvnsite 2m 48s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 5m 21s trunk passed
          +1 javadoc 3m 44s trunk passed with JDK v1.8.0_74
          +1 javadoc 4m 59s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 23s Maven dependency ordering for patch
          +1 mvninstall 2m 24s the patch passed
          +1 compile 15m 34s the patch passed with JDK v1.8.0_74
          +1 javac 15m 34s the patch passed
          +1 compile 12m 3s the patch passed with JDK v1.7.0_95
          +1 javac 12m 3s the patch passed
          -1 checkstyle 1m 41s root: patch generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26)
          +1 mvnsite 2m 59s the patch passed
          +1 mvneclipse 0m 48s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 8s the patch passed
          +1 javadoc 3m 48s the patch passed with JDK v1.8.0_74
          +1 javadoc 4m 59s the patch passed with JDK v1.7.0_95
          -1 unit 14m 2s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 121m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          -1 unit 11m 15s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 74m 52s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 47s Patch generated 2 ASF License warnings.
          330m 3s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.ipc.TestRPCWaitForProxy
            hadoop.fs.shell.find.TestIname
            hadoop.ha.TestZKFailoverController
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestName
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.tracing.TestTracing
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.TestReconstructStripedFile
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestRPCWaitForProxy
            hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestPrint0
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestName
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.TestSecureNameNode
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
            org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
            org.apache.hadoop.hdfs.TestAclsEndToEnd
            org.apache.hadoop.hdfs.TestWriteConfigurationToDFS
            org.apache.hadoop.hdfs.server.balancer.TestBalancer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778005/HDFS-9559.01.patch
          JIRA Issue HDFS-9559
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1d991766da29 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e7ed05e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14888/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14888/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 55s Maven dependency ordering for branch +1 mvninstall 9m 26s trunk passed +1 compile 13m 7s trunk passed with JDK v1.8.0_74 +1 compile 11m 37s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 37s trunk passed +1 mvnsite 2m 48s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 5m 21s trunk passed +1 javadoc 3m 44s trunk passed with JDK v1.8.0_74 +1 javadoc 4m 59s trunk passed with JDK v1.7.0_95 0 mvndep 0m 23s Maven dependency ordering for patch +1 mvninstall 2m 24s the patch passed +1 compile 15m 34s the patch passed with JDK v1.8.0_74 +1 javac 15m 34s the patch passed +1 compile 12m 3s the patch passed with JDK v1.7.0_95 +1 javac 12m 3s the patch passed -1 checkstyle 1m 41s root: patch generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26) +1 mvnsite 2m 59s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 8s the patch passed +1 javadoc 3m 48s the patch passed with JDK v1.8.0_74 +1 javadoc 4m 59s the patch passed with JDK v1.7.0_95 -1 unit 14m 2s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 121m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 11m 15s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 74m 52s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 47s Patch generated 2 ASF License warnings. 330m 3s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.fs.shell.find.TestIname   hadoop.ha.TestZKFailoverController   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestName   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.tracing.TestTracing   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.TestReconstructStripedFile   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestPrint0   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestName   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestSecureNameNode   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker   org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery   org.apache.hadoop.hdfs.TestAclsEndToEnd   org.apache.hadoop.hdfs.TestWriteConfigurationToDFS   org.apache.hadoop.hdfs.server.balancer.TestBalancer Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778005/HDFS-9559.01.patch JIRA Issue HDFS-9559 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1d991766da29 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e7ed05e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14888/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14888/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14888/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Lei (Eddy) Xu Please can you review ?

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Lei (Eddy) Xu Please can you review ?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'm thinking this feature is useful for RM-HA as well. Would you move this issue from HDFS to Hadoop common?

          Show
          ajisakaa Akira Ajisaka added a comment - I'm thinking this feature is useful for RM-HA as well. Would you move this issue from HDFS to Hadoop common?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          In addition, would you add a test for RM-HA and document this command in both HDFS and YARN?

          Show
          ajisakaa Akira Ajisaka added a comment - In addition, would you add a test for RM-HA and document this command in both HDFS and YARN?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for review..

          would you add a test for RM-HA and document this command in both HDFS and YARN?

          Yes, I will update the patch.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for review.. would you add a test for RM-HA and document this command in both HDFS and YARN? Yes, I will update the patch.
          Hide
          yuanbo Yuanbo Liu added a comment - - edited

          Surendra Singh Lilhore Thanks for filing this JIRA.
          I'm +1 for adding this command, it will be very useful for monitor scripts and auto test-case scripts.
          Here're my comments for your patch.

          • Would you mind using "rpcTimeoutForChecks" instead of "5000" here?
            HAServiceProtocol proto = target.getProxy(getConf(), 5000);
            
          • The exception message in getAllServiceState is ignored, I think it's good to expose it.
            catch (IOException e) {
                    out.println(String.format("%-50s %-10s", target.getAddress(),
                        "Failed to connect."));
                  }
            
          Show
          yuanbo Yuanbo Liu added a comment - - edited Surendra Singh Lilhore Thanks for filing this JIRA. I'm +1 for adding this command, it will be very useful for monitor scripts and auto test-case scripts. Here're my comments for your patch. Would you mind using "rpcTimeoutForChecks" instead of "5000" here? HAServiceProtocol proto = target.getProxy(getConf(), 5000); The exception message in getAllServiceState is ignored, I think it's good to expose it. catch (IOException e) { out.println( String .format( "%-50s %-10s" , target.getAddress(), "Failed to connect." )); }
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 53s Maven dependency ordering for branch
          +1 mvninstall 13m 19s trunk passed
          +1 compile 9m 57s trunk passed
          +1 checkstyle 1m 31s trunk passed
          +1 mvnsite 1m 59s trunk passed
          +1 mvneclipse 0m 38s trunk passed
          +1 findbugs 3m 28s trunk passed
          +1 javadoc 1m 38s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 27s the patch passed
          +1 compile 9m 22s the patch passed
          +1 javac 9m 21s the patch passed
          -0 checkstyle 1m 35s root: The patch generated 1 new + 51 unchanged - 0 fixed = 52 total (was 51)
          +1 mvnsite 2m 1s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 38s the patch passed
          +1 javadoc 1m 45s the patch passed
          +1 unit 8m 26s hadoop-common in the patch passed.
          -1 unit 63m 2s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 41s The patch does not generate ASF License warnings.
          151m 47s



          Reason Tests
          Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13933
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778005/HDFS-9559.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d340abd2c7df 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 56a13a6
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11309/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11309/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11309/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 53s Maven dependency ordering for branch +1 mvninstall 13m 19s trunk passed +1 compile 9m 57s trunk passed +1 checkstyle 1m 31s trunk passed +1 mvnsite 1m 59s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 3m 28s trunk passed +1 javadoc 1m 38s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 9m 22s the patch passed +1 javac 9m 21s the patch passed -0 checkstyle 1m 35s root: The patch generated 1 new + 51 unchanged - 0 fixed = 52 total (was 51) +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 38s the patch passed +1 javadoc 1m 45s the patch passed +1 unit 8m 26s hadoop-common in the patch passed. -1 unit 63m 2s hadoop-hdfs in the patch failed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 151m 47s Reason Tests Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778005/HDFS-9559.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d340abd2c7df 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 56a13a6 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11309/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11309/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11309/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka and Yuanbo Liu for review...
          Attached updated patch..
          Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka and Yuanbo Liu for review... Attached updated patch.. Please review..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 12m 22s trunk passed
          +1 compile 9m 42s trunk passed
          +1 checkstyle 1m 32s trunk passed
          +1 mvnsite 2m 24s trunk passed
          +1 mvneclipse 0m 57s trunk passed
          +1 findbugs 3m 52s trunk passed
          +1 javadoc 1m 57s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 47s the patch passed
          +1 compile 9m 13s the patch passed
          +1 javac 9m 13s the patch passed
          -0 checkstyle 1m 35s root: The patch generated 3 new + 145 unchanged - 3 fixed = 148 total (was 148)
          +1 mvnsite 2m 31s the patch passed
          +1 mvneclipse 1m 7s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 24s the patch passed
          +1 javadoc 2m 9s the patch passed
          -1 unit 8m 4s hadoop-common in the patch failed.
          +1 unit 63m 14s hadoop-hdfs in the patch passed.
          +1 unit 16m 8s hadoop-yarn-client in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          168m 50s



          Reason Tests
          Failed junit tests hadoop.conf.TestCommonConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13933
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844623/HADOOP-13933.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a452f38cc7b6 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c721f78
          Default Java 1.8.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11321/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11321/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11321/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11321/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 12m 22s trunk passed +1 compile 9m 42s trunk passed +1 checkstyle 1m 32s trunk passed +1 mvnsite 2m 24s trunk passed +1 mvneclipse 0m 57s trunk passed +1 findbugs 3m 52s trunk passed +1 javadoc 1m 57s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 47s the patch passed +1 compile 9m 13s the patch passed +1 javac 9m 13s the patch passed -0 checkstyle 1m 35s root: The patch generated 3 new + 145 unchanged - 3 fixed = 148 total (was 148) +1 mvnsite 2m 31s the patch passed +1 mvneclipse 1m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 24s the patch passed +1 javadoc 2m 9s the patch passed -1 unit 8m 4s hadoop-common in the patch failed. +1 unit 63m 14s hadoop-hdfs in the patch passed. +1 unit 16m 8s hadoop-yarn-client in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 168m 50s Reason Tests Failed junit tests hadoop.conf.TestCommonConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844623/HADOOP-13933.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a452f38cc7b6 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c721f78 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11321/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11321/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11321/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11321/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yuanbo Yuanbo Liu added a comment -

          Surendra Singh Lilhore Thanks for your new patch.

          .put("-getAllServiceState",
                  new UsageInfo(null, "Returns the state of all the services"))
          

          I'm wondering if we can use "" instead of null so that we can get rid of some null condition code, but I'm cool with the null parameter if you want to keep it.

          Show
          yuanbo Yuanbo Liu added a comment - Surendra Singh Lilhore Thanks for your new patch. .put( "-getAllServiceState" , new UsageInfo( null , "Returns the state of all the services" )) I'm wondering if we can use "" instead of null so that we can get rid of some null condition code, but I'm cool with the null parameter if you want to keep it.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Yuanbo Liu for review..

          I'm wondering if we can use "" instead of null so that we can get rid of some null condition code

          We will wait for Akira Ajisaka's suggestion for this.

          I will fix the checkstyle warnings in next patch..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Yuanbo Liu for review.. I'm wondering if we can use "" instead of null so that we can get rid of some null condition code We will wait for Akira Ajisaka 's suggestion for this. I will fix the checkstyle warnings in next patch..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Now I'm +1 for using null because

          • using null implies there is no argument for getAllServiceState command
          • we cannot get rid of all the null condition code even if we switch to use empty string
            For example, if the usage.args is an empty string, the error message will be getUsageString() + "[" + cmd + " ]". (unnecessary whitespace before ])
                if (usage.args == null) {
                  errOut.println(getUsageString() + " [" + cmd + "]");
                } else {
                  errOut.println(getUsageString() + " [" + cmd + " " + usage.args + "]");
                }
            
          Show
          ajisakaa Akira Ajisaka added a comment - Now I'm +1 for using null because using null implies there is no argument for getAllServiceState command we cannot get rid of all the null condition code even if we switch to use empty string For example, if the usage.args is an empty string, the error message will be getUsageString() + "[" + cmd + " ]" . (unnecessary whitespace before ] ) if (usage.args == null ) { errOut.println(getUsageString() + " [" + cmd + "]" ); } else { errOut.println(getUsageString() + " [" + cmd + " " + usage.args + "]" ); }
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka

          Attached updated patch...
          v3 :

          1. Updated document for new command.
          2. Fixed checkstyle warnings...

          Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka Attached updated patch... v3 : 1. Updated document for new command. 2. Fixed checkstyle warnings... Please review..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 44s Maven dependency ordering for branch
          +1 mvninstall 12m 26s trunk passed
          +1 compile 9m 29s trunk passed
          +1 checkstyle 1m 33s trunk passed
          +1 mvnsite 2m 41s trunk passed
          +1 mvneclipse 1m 14s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 3m 49s trunk passed
          +1 javadoc 2m 15s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 58s the patch passed
          +1 compile 9m 12s the patch passed
          +1 javac 9m 12s the patch passed
          +1 checkstyle 1m 36s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148)
          +1 mvnsite 2m 53s the patch passed
          +1 mvneclipse 1m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 4m 19s the patch passed
          +1 javadoc 2m 27s the patch passed
          -1 unit 8m 4s hadoop-common in the patch failed.
          -1 unit 63m 15s hadoop-hdfs in the patch failed.
          +1 unit 16m 9s hadoop-yarn-client in the patch passed.
          +1 unit 0m 22s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          172m 34s



          Reason Tests
          Failed junit tests hadoop.conf.TestCommonConfigurationFields
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13933
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844691/HADOOP-13933.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 38926813c93d 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ea54752
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11327/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11327/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11327/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11327/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 44s Maven dependency ordering for branch +1 mvninstall 12m 26s trunk passed +1 compile 9m 29s trunk passed +1 checkstyle 1m 33s trunk passed +1 mvnsite 2m 41s trunk passed +1 mvneclipse 1m 14s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 49s trunk passed +1 javadoc 2m 15s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 58s the patch passed +1 compile 9m 12s the patch passed +1 javac 9m 12s the patch passed +1 checkstyle 1m 36s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148) +1 mvnsite 2m 53s the patch passed +1 mvneclipse 1m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 4m 19s the patch passed +1 javadoc 2m 27s the patch passed -1 unit 8m 4s hadoop-common in the patch failed. -1 unit 63m 15s hadoop-hdfs in the patch failed. +1 unit 16m 9s hadoop-yarn-client in the patch passed. +1 unit 0m 22s hadoop-yarn-site in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 172m 34s Reason Tests Failed junit tests hadoop.conf.TestCommonConfigurationFields   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844691/HADOOP-13933.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 38926813c93d 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea54752 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11327/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11327/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11327/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11327/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yuanbo Yuanbo Liu added a comment -

          Surendra Singh Lilhore Thanks for the new patch.
          There is a tiny mistake in you patch

          +| -getServiceState \<serviceId\> | Returns the state of all the services. |
          

          After it's addressed, I'm +1(no-binding) for your patch. Thanks for your work.

          Show
          yuanbo Yuanbo Liu added a comment - Surendra Singh Lilhore Thanks for the new patch. There is a tiny mistake in you patch +| -getServiceState \<serviceId\> | Returns the state of all the services. | After it's addressed, I'm +1(no-binding) for your patch. Thanks for your work.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Yuanbo Liu, good catch.
          Attached updated patch.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Yuanbo Liu , good catch. Attached updated patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 12m 27s trunk passed
          +1 compile 9m 30s trunk passed
          +1 checkstyle 1m 33s trunk passed
          +1 mvnsite 2m 42s trunk passed
          +1 mvneclipse 1m 12s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 3m 46s trunk passed
          +1 javadoc 2m 13s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 57s the patch passed
          +1 compile 9m 14s the patch passed
          +1 javac 9m 14s the patch passed
          +1 checkstyle 1m 36s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148)
          +1 mvnsite 2m 52s the patch passed
          +1 mvneclipse 1m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 4m 21s the patch passed
          +1 javadoc 2m 20s the patch passed
          -1 unit 8m 9s hadoop-common in the patch failed.
          +1 unit 63m 1s hadoop-hdfs in the patch passed.
          +1 unit 16m 10s hadoop-yarn-client in the patch passed.
          +1 unit 0m 22s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          170m 29s



          Reason Tests
          Failed junit tests hadoop.conf.TestCommonConfigurationFields



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13933
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844723/HADOOP-13933.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux cbf5820d69ca 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ea54752
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11329/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11329/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11329/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 12m 27s trunk passed +1 compile 9m 30s trunk passed +1 checkstyle 1m 33s trunk passed +1 mvnsite 2m 42s trunk passed +1 mvneclipse 1m 12s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 46s trunk passed +1 javadoc 2m 13s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 57s the patch passed +1 compile 9m 14s the patch passed +1 javac 9m 14s the patch passed +1 checkstyle 1m 36s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148) +1 mvnsite 2m 52s the patch passed +1 mvneclipse 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 4m 21s the patch passed +1 javadoc 2m 20s the patch passed -1 unit 8m 9s hadoop-common in the patch failed. +1 unit 63m 1s hadoop-hdfs in the patch passed. +1 unit 16m 10s hadoop-yarn-client in the patch passed. +1 unit 0m 22s hadoop-yarn-site in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 170m 29s Reason Tests Failed junit tests hadoop.conf.TestCommonConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12844723/HADOOP-13933.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cbf5820d69ca 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ea54752 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11329/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11329/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11329/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          yuanbo Yuanbo Liu added a comment -

          Surendra Singh Lilhore FYI, you just uploaded another 003 patch and the issue I mentioned before seems not addressed.

          Show
          yuanbo Yuanbo Liu added a comment - Surendra Singh Lilhore FYI, you just uploaded another 003 patch and the issue I mentioned before seems not addressed.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Sorry, I think I uploaded wrong patch...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Sorry, I think I uploaded wrong patch...
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached updated patch.
          Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached updated patch. Please review..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 14m 9s trunk passed
          +1 compile 10m 23s trunk passed
          +1 checkstyle 1m 37s trunk passed
          +1 mvnsite 2m 55s trunk passed
          +1 mvneclipse 1m 17s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 6m 34s trunk passed
          +1 javadoc 7m 32s trunk passed
          0 mvndep 0m 52s Maven dependency ordering for patch
          +1 mvninstall 2m 15s the patch passed
          +1 compile 10m 6s the patch passed
          +1 javac 10m 6s the patch passed
          +1 checkstyle 1m 46s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148)
          +1 mvnsite 3m 6s the patch passed
          +1 mvneclipse 1m 32s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 5m 0s the patch passed
          +1 javadoc 2m 36s the patch passed
          -1 unit 8m 1s hadoop-common in the patch failed.
          -1 unit 75m 16s hadoop-hdfs in the patch failed.
          +1 unit 17m 17s hadoop-yarn-client in the patch passed.
          +1 unit 0m 22s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 57s The patch does not generate ASF License warnings.
          200m 16s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.hdfs.TestEncryptionZones



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13933
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845800/HADOOP-13933.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4a1b77425b84 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a605ff3
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11369/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11369/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11369/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 14m 9s trunk passed +1 compile 10m 23s trunk passed +1 checkstyle 1m 37s trunk passed +1 mvnsite 2m 55s trunk passed +1 mvneclipse 1m 17s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 6m 34s trunk passed +1 javadoc 7m 32s trunk passed 0 mvndep 0m 52s Maven dependency ordering for patch +1 mvninstall 2m 15s the patch passed +1 compile 10m 6s the patch passed +1 javac 10m 6s the patch passed +1 checkstyle 1m 46s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148) +1 mvnsite 3m 6s the patch passed +1 mvneclipse 1m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 5m 0s the patch passed +1 javadoc 2m 36s the patch passed -1 unit 8m 1s hadoop-common in the patch failed. -1 unit 75m 16s hadoop-hdfs in the patch failed. +1 unit 17m 17s hadoop-yarn-client in the patch passed. +1 unit 0m 22s hadoop-yarn-site in the patch passed. +1 asflicense 0m 57s The patch does not generate ASF License warnings. 200m 16s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845800/HADOOP-13933.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4a1b77425b84 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a605ff3 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11369/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11369/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11369/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Failed tests are unrelated .
          Akira Ajisaka Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Failed tests are unrelated . Akira Ajisaka Please review..
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Surendra Singh Lilhore for the work on this. Only one trival comment, can you change OVerride to Override?

                 protected HAServiceTarget resolveTarget(String rmId) {
          -        return haServiceTarget;
          +        HAServiceTarget target = super.resolveTarget(rmId);
          +        HAServiceTarget spy = Mockito.spy(target);
          +        // OVerride the target to return our mock protocol
          +        try {
          +          Mockito.doReturn(haadmin).when(spy)
          +              .getProxy(Mockito.<Configuration> any(), Mockito.anyInt());
          +          Mockito.doReturn(false).when(spy).isAutoFailoverEnabled();
          +        } catch (IOException e) {
          +          throw new AssertionError(e); // mock setup doesn't really throw
          +        }
          +        return spy;
                 }
               };
             }
          

          +1 once addressed. Thanks.

          Show
          linyiqun Yiqun Lin added a comment - Thanks Surendra Singh Lilhore for the work on this. Only one trival comment, can you change OVerride to Override ? protected HAServiceTarget resolveTarget( String rmId) { - return haServiceTarget; + HAServiceTarget target = super .resolveTarget(rmId); + HAServiceTarget spy = Mockito.spy(target); + // OVerride the target to return our mock protocol + try { + Mockito.doReturn(haadmin).when(spy) + .getProxy(Mockito.<Configuration> any(), Mockito.anyInt()); + Mockito.doReturn( false ).when(spy).isAutoFailoverEnabled(); + } catch (IOException e) { + throw new AssertionError(e); // mock setup doesn't really throw + } + return spy; } }; } +1 once addressed. Thanks.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Yiqun Lin for review...

          Attached updated patch v5...

          This command will not print anything if it fail to get service IDs from configuration, so I added one check.

          +    if (targetIds.isEmpty()) {
          +      errOut.println("Failed to get service IDs");
          +      return -1;
          +    }
          

          Please review...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Yiqun Lin for review... Attached updated patch v5... This command will not print anything if it fail to get service IDs from configuration, so I added one check. + if (targetIds.isEmpty()) { + errOut.println( "Failed to get service IDs" ); + return -1; + } Please review...
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 13m 8s trunk passed
          +1 compile 10m 7s trunk passed
          +1 checkstyle 1m 34s trunk passed
          +1 mvnsite 2m 47s trunk passed
          +1 mvneclipse 1m 10s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 3m 52s trunk passed
          +1 javadoc 2m 15s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 2m 2s the patch passed
          +1 compile 9m 43s the patch passed
          +1 javac 9m 43s the patch passed
          +1 checkstyle 1m 36s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148)
          +1 mvnsite 2m 56s the patch passed
          +1 mvneclipse 1m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 4m 33s the patch passed
          +1 javadoc 2m 24s the patch passed
          +1 unit 8m 50s hadoop-common in the patch passed.
          +1 unit 66m 24s hadoop-hdfs in the patch passed.
          +1 unit 16m 8s hadoop-yarn-client in the patch passed.
          +1 unit 0m 21s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 39s The patch does not generate ASF License warnings.
          176m 35s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13933
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847152/HADOOP-13933.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4e9a07a78a6d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a6b06f7
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11426/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11426/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 13m 8s trunk passed +1 compile 10m 7s trunk passed +1 checkstyle 1m 34s trunk passed +1 mvnsite 2m 47s trunk passed +1 mvneclipse 1m 10s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 52s trunk passed +1 javadoc 2m 15s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 2s the patch passed +1 compile 9m 43s the patch passed +1 javac 9m 43s the patch passed +1 checkstyle 1m 36s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148) +1 mvnsite 2m 56s the patch passed +1 mvneclipse 1m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 4m 33s the patch passed +1 javadoc 2m 24s the patch passed +1 unit 8m 50s hadoop-common in the patch passed. +1 unit 66m 24s hadoop-hdfs in the patch passed. +1 unit 16m 8s hadoop-yarn-client in the patch passed. +1 unit 0m 21s hadoop-yarn-site in the patch passed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 176m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847152/HADOOP-13933.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4e9a07a78a6d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a6b06f7 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11426/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11426/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Mostly looks good to me. I built an HA cluster and verified the new option.
          Would you update HDFSHighAvailabilityWithNFS.md and HDFSHighAvailabilityWithQJM.md as well? I'm +1 if that is addressed.

          Show
          ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. I built an HA cluster and verified the new option. Would you update HDFSHighAvailabilityWithNFS.md and HDFSHighAvailabilityWithQJM.md as well? I'm +1 if that is addressed.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for review.
          Attached updated patch, pls review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for review. Attached updated patch, pls review..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 53s Maven dependency ordering for branch
          +1 mvninstall 12m 45s trunk passed
          +1 compile 9m 48s trunk passed
          +1 checkstyle 1m 32s trunk passed
          +1 mvnsite 2m 47s trunk passed
          +1 mvneclipse 1m 14s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 3m 58s trunk passed
          +1 javadoc 2m 13s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 2s the patch passed
          +1 compile 9m 25s the patch passed
          +1 javac 9m 25s the patch passed
          +1 checkstyle 1m 35s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148)
          +1 mvnsite 2m 57s the patch passed
          +1 mvneclipse 1m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          +1 findbugs 5m 12s the patch passed
          +1 javadoc 2m 24s the patch passed
          -1 unit 9m 3s hadoop-common in the patch failed.
          -1 unit 72m 21s hadoop-hdfs in the patch failed.
          +1 unit 16m 3s hadoop-yarn-client in the patch passed.
          +1 unit 0m 16s hadoop-yarn-site in the patch passed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          183m 54s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13933
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847319/HADOOP-13933.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d579f2ebcee6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1f344e0
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11430/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11430/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11430/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11430/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 53s Maven dependency ordering for branch +1 mvninstall 12m 45s trunk passed +1 compile 9m 48s trunk passed +1 checkstyle 1m 32s trunk passed +1 mvnsite 2m 47s trunk passed +1 mvneclipse 1m 14s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 3m 58s trunk passed +1 javadoc 2m 13s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 2s the patch passed +1 compile 9m 25s the patch passed +1 javac 9m 25s the patch passed +1 checkstyle 1m 35s root: The patch generated 0 new + 145 unchanged - 3 fixed = 145 total (was 148) +1 mvnsite 2m 57s the patch passed +1 mvneclipse 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site +1 findbugs 5m 12s the patch passed +1 javadoc 2m 24s the patch passed -1 unit 9m 3s hadoop-common in the patch failed. -1 unit 72m 21s hadoop-hdfs in the patch failed. +1 unit 16m 3s hadoop-yarn-client in the patch passed. +1 unit 0m 16s hadoop-yarn-site in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 183m 54s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847319/HADOOP-13933.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d579f2ebcee6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1f344e0 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11430/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11430/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11430/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11430/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'll commit this tomorrow if there are no objections.

          Show
          ajisakaa Akira Ajisaka added a comment - I'll commit this tomorrow if there are no objections.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Surendra Singh Lilhore for the contribution and thanks Yuanbo Liu and Yiqun Lin for the reviews.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Surendra Singh Lilhore for the contribution and thanks Yuanbo Liu and Yiqun Lin for the reviews.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11123 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11123/)
          HADOOP-13933. Add haadmin -getAllServiceState option to get the HA state (aajisaka: rev e407449ddb52c36b74358f22db498424e82ec4a7)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnCommands.md
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithNFS.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11123 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11123/ ) HADOOP-13933 . Add haadmin -getAllServiceState option to get the HA state (aajisaka: rev e407449ddb52c36b74358f22db498424e82ec4a7) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnCommands.md (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithNFS.md
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for review and commit..
          Thanks Yuanbo Liu and Yiqun Lin for review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for review and commit.. Thanks Yuanbo Liu and Yiqun Lin for review..
          Hide
          kihwal Kihwal Lee added a comment - - edited

          Cherry-picked to branch-2.8.

          Show
          kihwal Kihwal Lee added a comment - - edited Cherry-picked to branch-2.8.

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              surendrasingh Surendra Singh Lilhore
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development