Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.0, 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The indefinite article before "HA" and "FS" should be "an", not "a". Most of the comments are correct, execpt a few which fixed in this patch.
      They should stay the same.

      1. HADOOP-13932.update.patch
        12 kB
        LiXin Ge
      2. HADOOP-13932.branch-2.patch
        12 kB
        LiXin Ge

        Activity

        Hide
        templedf Daniel Templeton added a comment -

        Thanks, LiXin Ge. Looks good, except for the "HAR" fix. As far as I know, most folks pronounce that one instead of spelling it, so it would be, "a HAR."

        Show
        templedf Daniel Templeton added a comment - Thanks, LiXin Ge . Looks good, except for the "HAR" fix. As far as I know, most folks pronounce that one instead of spelling it, so it would be, "a HAR."
        Hide
        GeLiXin LiXin Ge added a comment - - edited

        Thanks for your review , Daniel Templeton. I have Updated the patch according to your suggestion now.

        Show
        GeLiXin LiXin Ge added a comment - - edited Thanks for your review , Daniel Templeton . I have Updated the patch according to your suggestion now.
        Hide
        templedf Daniel Templeton added a comment -

        LGTM +1

        Show
        templedf Daniel Templeton added a comment - LGTM +1
        Hide
        templedf Daniel Templeton added a comment -

        Thanks, LiXin Ge. Committed to trunk. The patch doesn't apply cleanly to branch-2. If you provide a branch-2 patch, I'll commit it there as well.

        Show
        templedf Daniel Templeton added a comment - Thanks, LiXin Ge . Committed to trunk. The patch doesn't apply cleanly to branch-2. If you provide a branch-2 patch, I'll commit it there as well.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11043 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11043/)
        HADOOP-13932. Fix indefinite article in comments (Contributed by LiXin (templedf: rev e216e8e2334519b7c833d99586218e99a39265f3)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsRollingUpgrade.md
        • (edit) hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_API_2.7.2.xml
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/FileSystemRMStateStore.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/LibHdfs.md
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/HAUtil.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueueMetrics.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImagePreTransactionalStorageInspector.java
        • (edit) hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_API_2.6.0.xml
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11043 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11043/ ) HADOOP-13932 . Fix indefinite article in comments (Contributed by LiXin (templedf: rev e216e8e2334519b7c833d99586218e99a39265f3) (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsRollingUpgrade.md (edit) hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_API_2.7.2.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/FileSystemRMStateStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/LibHdfs.md (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/HAUtil.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueueMetrics.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImagePreTransactionalStorageInspector.java (edit) hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_API_2.6.0.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
        Hide
        GeLiXin LiXin Ge added a comment -

        It was my pleasure, Daniel Templeton. The patch for branch-2 is done

        Show
        GeLiXin LiXin Ge added a comment - It was my pleasure, Daniel Templeton . The patch for branch-2 is done
        Hide
        templedf Daniel Templeton added a comment -

        Committed to branch-2. Thanks again, LiXin Ge.

        Show
        templedf Daniel Templeton added a comment - Committed to branch-2. Thanks again, LiXin Ge .

          People

          • Assignee:
            GeLiXin LiXin Ge
            Reporter:
            GeLiXin LiXin Ge
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development