Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13883

Add description of -fs option in generic command usage

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the description of option '-fs' is missing in generic command usage in documentation CommandManual.md. And the users won't know to use this option, while this option already makes sense to hdfs dfsadmin, hdfs fsck, etc.

      1. HADOOP-13883.addendum-005.patch
        4 kB
        Brahma Reddy Battula
      2. HADOOP-13883-branch-2.8.addendum.patch
        5 kB
        Yiqun Lin
      3. HADOOP-13883.005.patch
        4 kB
        Yiqun Lin
      4. HADOOP-13883.004.patch
        3 kB
        Yiqun Lin
      5. HADOOP-13883.addendum002.patch
        3 kB
        Yiqun Lin
      6. HADOOP-13883.addendum001.patch
        3 kB
        Yiqun Lin
      7. HADOOP-13883.001.patch
        0.8 kB
        Yiqun Lin

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Patch attached.

        Show
        linyiqun Yiqun Lin added a comment - Patch attached.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvninstall 7m 32s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvnsite 0m 58s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        10m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13883
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842537/HADOOP-13883.001.patch
        Optional Tests asflicense mvnsite
        uname Linux cdd424499080 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d1d4aba
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11234/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 7m 32s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvnsite 0m 58s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 10m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13883 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842537/HADOOP-13883.001.patch Optional Tests asflicense mvnsite uname Linux cdd424499080 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d1d4aba modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11234/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yiqun Lin thanks for reporting this..LGTM..will commit..I feel,this should goto branc-2.8 and branch-2 also ,but you mentioned affter version as 3.0.0-alpaha2,any specific reasion..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin thanks for reporting this..LGTM..will commit..I feel,this should goto branc-2.8 and branch-2 also ,but you mentioned affter version as 3.0.0-alpaha2,any specific reasion..?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,branch-2 and branch-2.8..Yiqun Lin thanks for contribution..Hope it should be fine as it should go to branch-2 and branc-2.8..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2 and branch-2.8.. Yiqun Lin thanks for contribution..Hope it should be fine as it should go to branch-2 and branc-2.8..
        Hide
        aw Allen Wittenauer added a comment -

        It's not listed there because not everything supports -fs. Also, why wasn't this alphabetized?

        Show
        aw Allen Wittenauer added a comment - It's not listed there because not everything supports -fs. Also, why wasn't this alphabetized?
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        I feel,this should goto branc-2.8 and branch-2 also

        Agreed on this. Sorry to make you confused, Brahma Reddy Battula. Since this issue exists in trunk, I add the 3.0 alpha2 to affect version.

        It's not listed there because not everything supports -fs.

        Now I see the '-fs' option can be used in many hdfs subcommands, but these commands hardly not documented the usage of '-fs'. Do you mean we should add the usage of '-fs' option one by one? I think one better way based on the v01 patch is to add the supported hdfs commands which can used '-fs' option in the documentation.

        Show
        linyiqun Yiqun Lin added a comment - - edited I feel,this should goto branc-2.8 and branch-2 also Agreed on this. Sorry to make you confused, Brahma Reddy Battula . Since this issue exists in trunk, I add the 3.0 alpha2 to affect version. It's not listed there because not everything supports -fs. Now I see the '-fs' option can be used in many hdfs subcommands, but these commands hardly not documented the usage of '-fs'. Do you mean we should add the usage of '-fs' option one by one? I think one better way based on the v01 patch is to add the supported hdfs commands which can used '-fs' option in the documentation.
        Hide
        linyiqun Yiqun Lin added a comment -

        I made a code glance in hdfs project and found 14 commands that use the ToolRunner#run. And that means these commands can support '-fs' option. Attached the addendum patch for this JIRA. Brahma Reddy Battula, I see that HDFS-11226 hasn't been merged, can you apply this minor change into your latest patch and you can add hdfs storagepolicies as well? Thanks a lot for that.

        Show
        linyiqun Yiqun Lin added a comment - I made a code glance in hdfs project and found 14 commands that use the ToolRunner#run . And that means these commands can support '-fs' option. Attached the addendum patch for this JIRA. Brahma Reddy Battula , I see that HDFS-11226 hasn't been merged, can you apply this minor change into your latest patch and you can add hdfs storagepolicies as well? Thanks a lot for that.
        Hide
        vinayrpet Vinayakumar B added a comment -

        "-fs" option is basically overriding the client's "fs.defaultFS" configuration.
        It can be any filesystem url. not only HDFS. So description should be generic and simple. I dont think, where and all this option is supported, needs to be mentioned in the description of command.
        It could be as simple as -fs : Default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations.

        Show
        vinayrpet Vinayakumar B added a comment - "-fs" option is basically overriding the client's "fs.defaultFS" configuration. It can be any filesystem url. not only HDFS. So description should be generic and simple. I dont think, where and all this option is supported, needs to be mentioned in the description of command. It could be as simple as -fs : Default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        sorry, I missed this..and thanks Allen Wittenauer and Vinayakumar B for pointing the same.

        I think, we need to change this message GenericOptionsParser#printGenericCommandUsage (might not incompatiable..?) here also and update in doc where we can address following also.

        why wasn't this alphabetized?

        Change can be like below,as vinay mentioned.

        out.println("-fs <Default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations>")

        Yiqun Lin i am thinking, you can update as addendum here.

        Show
        brahmareddy Brahma Reddy Battula added a comment - sorry, I missed this..and thanks Allen Wittenauer and Vinayakumar B for pointing the same. I think, we need to change this message GenericOptionsParser#printGenericCommandUsage (might not incompatiable..?) here also and update in doc where we can address following also. why wasn't this alphabetized? Change can be like below,as vinay mentioned. out.println( "-fs <Default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations>" ) Yiqun Lin i am thinking, you can update as addendum here.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks for the great comments. Attached the addendum patch here.

        Show
        linyiqun Yiqun Lin added a comment - Thanks for the great comments. Attached the addendum patch here.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yiqun Lin thanks for updating the patch. can you address alphabetized also..? i.e
        needs to update after -D <property>=<value> ` | Use value for given property. | in CommandsManual.md ..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin thanks for updating the patch. can you address alphabetized also..? i.e needs to update after -D <property>=<value> ` | Use value for given property. | in CommandsManual.md ..?
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        I'm a little confused here, I have updated in CommandsManual.md, right?

        -| `-fs <local> or <namenode:port>` | Specify a NameNode. |
        +| `-fs <default filesystem URL to use>` | Specify default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations. |
         | `-archives <comma separated list of archives> ` | Specify comma separated archives to be unarchived on the compute machines. Applies only to job. |
         | `-conf <configuration file> ` | Specify an application configuration file. |
         | `-D <property>=<value> ` | Use value for given property. |
        
        Show
        linyiqun Yiqun Lin added a comment - - edited I'm a little confused here, I have updated in CommandsManual.md , right? -| `-fs <local> or <namenode:port>` | Specify a NameNode. | +| `-fs < default filesystem URL to use>` | Specify default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations. | | `-archives <comma separated list of archives> ` | Specify comma separated archives to be unarchived on the compute machines. Applies only to job. | | `-conf <configuration file> ` | Specify an application configuration file. | | `-D <property>=<value> ` | Use value for given property. |
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yes, you updated, but it's not alphabet order...shuold like following

        -| `-fs <local> or <namenode:port>` | Specify a NameNode. |
         | `-archives <comma separated list of archives> ` | Specify comma separated archives to be unarchived on the compute machines. Applies only to job. |
         | `-conf <configuration file> ` | Specify an application configuration file. |
         | `-D <property>=<value> ` | Use value for given property. |
         | `-files <comma separated list of files> ` | Specify comma separated files to be copied to the map reduce cluster. Applies only to job. |
        +| `-fs <default filesystem URL to use>` | Specify default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations. |
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - Yes, you updated, but it's not alphabet order...shuold like following -| `-fs <local> or <namenode:port>` | Specify a NameNode. | | `-archives <comma separated list of archives> ` | Specify comma separated archives to be unarchived on the compute machines. Applies only to job. | | `-conf <configuration file> ` | Specify an application configuration file. | | `-D <property>=<value> ` | Use value for given property. | | `-files <comma separated list of files> ` | Specify comma separated files to be copied to the map reduce cluster. Applies only to job. | +| `-fs <default filesystem URL to use>` | Specify default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations. |
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 57s trunk passed
        +1 compile 9m 31s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 21s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 35s the patch passed
        +1 compile 9m 26s the patch passed
        +1 javac 9m 26s the patch passed
        -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 1 new + 28 unchanged - 1 fixed = 29 total (was 29)
        +1 mvnsite 1m 8s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 52s the patch passed
        +1 javadoc 0m 48s the patch passed
        -1 unit 8m 50s hadoop-common in the patch failed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        46m 19s



        Reason Tests
        Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13883
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842669/HADOOP-13883.addendum001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a52cf58a6f42 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4c38f11
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11240/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11240/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11240/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11240/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 57s trunk passed +1 compile 9m 31s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 21s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 9m 26s the patch passed +1 javac 9m 26s the patch passed -0 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 1 new + 28 unchanged - 1 fixed = 29 total (was 29) +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 48s the patch passed -1 unit 8m 50s hadoop-common in the patch failed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 46m 19s Reason Tests Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13883 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842669/HADOOP-13883.addendum001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a52cf58a6f42 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4c38f11 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11240/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11240/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11240/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11240/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks for your patient explanation, Brahma. Attached the new patch to address your comment. Hope the latest patch can satisfy with you.

        Show
        linyiqun Yiqun Lin added a comment - Thanks for your patient explanation, Brahma. Attached the new patch to address your comment. Hope the latest patch can satisfy with you.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 44s trunk passed
        +1 compile 9m 27s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 47s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 9m 6s the patch passed
        +1 javac 9m 6s the patch passed
        +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 26 unchanged - 3 fixed = 26 total (was 29)
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 31s the patch passed
        +1 javadoc 0m 48s the patch passed
        -1 unit 7m 50s hadoop-common in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        44m 19s



        Reason Tests
        Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13883
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842692/HADOOP-13883.addendum002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fff3598a0545 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4c38f11
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11241/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11241/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11241/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 44s trunk passed +1 compile 9m 27s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 6s the patch passed +1 javac 9m 6s the patch passed +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 26 unchanged - 3 fixed = 26 total (was 29) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 48s the patch passed -1 unit 7m 50s hadoop-common in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 44m 19s Reason Tests Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13883 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842692/HADOOP-13883.addendum002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fff3598a0545 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4c38f11 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11241/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11241/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11241/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yiqun Lin thanks for updating the patch.. If Vinayakumar B and Allen Wittenauer are ok with current approach , then I have two comments.
        i) TestPipeApplication#testSubmitter can fail after this patch, so need to correct
        ii) Need seperate patch for branch-2.8

        Show
        brahmareddy Brahma Reddy Battula added a comment - Yiqun Lin thanks for updating the patch.. If Vinayakumar B and Allen Wittenauer are ok with current approach , then I have two comments. i) TestPipeApplication#testSubmitter can fail after this patch, so need to correct ii) Need seperate patch for branch-2.8
        Hide
        vinayrpet Vinayakumar B added a comment -
         `-fs <default filesystem URL to use>` | Specify default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations. |

        Actually, earlier message local|namenode:port was not wrong. But it didnt mention explicitly about supporting other filesystems using full url. In-fact 'local' is shortcut for 'file:///' and 'namenode:port' is shortcut for 'hdfs://namenode:port'. see FileSystem#fixName() as below.

          /** Update old-format filesystem names, for back-compatibility.  This should
           * eventually be replaced with a checkName() method that throws an exception
           * for old-format names.
           */
          private static String fixName(String name) {
            // convert old-format name to new-format name
            if (name.equals("local")) {         // "local" is now "file:///".
              LOGGER.warn("\"local\" is a deprecated filesystem name."
                       +" Use \"file:///\" instead.");
              name = "file:///";
            } else if (name.indexOf('/')==-1) {   // unqualified is "hdfs://"
              LOGGER.warn("\""+name+"\" is a deprecated filesystem name."
                       +" Use \"hdfs://"+name+"/\" instead.");
              name = "hdfs://"+name;
            }
            return name;
          }

        So, Now description can be updated to mention about acceptance of local and namenode:port also instead of file:/// and hdfs://namenode:port

        hope I am clear now.

        Show
        vinayrpet Vinayakumar B added a comment - `-fs < default filesystem URL to use>` | Specify default filesystem URL to use. Overrides 'fs.defaultFS' property from configurations. | Actually, earlier message local|namenode:port was not wrong. But it didnt mention explicitly about supporting other filesystems using full url. In-fact 'local' is shortcut for 'file:///' and 'namenode:port' is shortcut for 'hdfs://namenode:port'. see FileSystem#fixName() as below. /** Update old-format filesystem names, for back-compatibility. This should * eventually be replaced with a checkName() method that throws an exception * for old-format names. */ private static String fixName( String name) { // convert old-format name to new -format name if (name.equals( "local" )) { // "local" is now "file:///" . LOGGER.warn( "\" local\ " is a deprecated filesystem name." + " Use \" file: ///\ " instead." ); name = "file: ///" ; } else if (name.indexOf('/')==-1) { // unqualified is "hdfs://" LOGGER.warn( "\" "+name+" \ " is a deprecated filesystem name." + " Use \" hdfs: // "+name+" /\ " instead." ); name = "hdfs: //" +name; } return name; } So, Now description can be updated to mention about acceptance of local and namenode:port also instead of file:/// and hdfs://namenode:port hope I am clear now.
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        Thanks for the further comments, Vinayakumar B. I see local and namenode:port is already deprecated filesystem name, so I think we can use file:/// and hdfs://namenode:port instead. This will also be clear to let users understand. New patch attached. Please let me know if the latest patch can satisfy with you, thanks.

        TestPipeApplication#testSubmitter can fail after this patch, so need to correct

        Good catch, Brahma Reddy Battula. Will attach a complete patch after the confirmationof the current v04 patch.

        Show
        linyiqun Yiqun Lin added a comment - - edited Thanks for the further comments, Vinayakumar B . I see local and namenode:port is already deprecated filesystem name, so I think we can use file:/// and hdfs://namenode:port instead. This will also be clear to let users understand. New patch attached. Please let me know if the latest patch can satisfy with you, thanks. TestPipeApplication#testSubmitter can fail after this patch, so need to correct Good catch, Brahma Reddy Battula . Will attach a complete patch after the confirmationof the current v04 patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 8s trunk passed
        +1 compile 9m 49s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 25s trunk passed
        +1 javadoc 0m 46s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 9m 15s the patch passed
        +1 javac 9m 15s the patch passed
        +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 26 unchanged - 3 fixed = 26 total (was 29)
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 47s the patch passed
        -1 unit 7m 57s hadoop-common in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        45m 26s



        Reason Tests
        Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13883
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842791/HADOOP-13883.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 35ee872a94d1 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4c38f11
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11246/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11246/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11246/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 8s trunk passed +1 compile 9m 49s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 9m 15s the patch passed +1 javac 9m 15s the patch passed +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 26 unchanged - 3 fixed = 26 total (was 29) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 47s the patch passed -1 unit 7m 57s hadoop-common in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 45m 26s Reason Tests Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13883 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842791/HADOOP-13883.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 35ee872a94d1 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4c38f11 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11246/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11246/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11246/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Attached the patch with failed test TestPipeApplication#testSubmitter fixed. Will attached the patch for branch-2.8 later if there are no further comments. Thanks for the review.

        Show
        linyiqun Yiqun Lin added a comment - Attached the patch with failed test TestPipeApplication#testSubmitter fixed. Will attached the patch for branch-2.8 later if there are no further comments. Thanks for the review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 6m 43s trunk passed
        +1 compile 10m 32s trunk passed
        +1 checkstyle 1m 38s trunk passed
        +1 mvnsite 1m 51s trunk passed
        +1 mvneclipse 0m 42s trunk passed
        +1 findbugs 2m 8s trunk passed
        +1 javadoc 1m 11s trunk passed
        0 mvndep 0m 17s Maven dependency ordering for patch
        -1 mvninstall 0m 19s hadoop-mapreduce-client-jobclient in the patch failed.
        -1 compile 7m 48s root in the patch failed.
        -1 javac 7m 48s root in the patch failed.
        -0 checkstyle 1m 42s root: The patch generated 2 new + 26 unchanged - 35 fixed = 28 total (was 61)
        -1 mvnsite 0m 27s hadoop-mapreduce-client-jobclient in the patch failed.
        +1 mvneclipse 0m 46s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 24s hadoop-mapreduce-client-jobclient in the patch failed.
        +1 javadoc 1m 14s the patch passed
        -1 unit 8m 13s hadoop-common in the patch failed.
        -1 unit 0m 27s hadoop-mapreduce-client-jobclient in the patch failed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        74m 39s



        Reason Tests
        Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13883
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842970/HADOOP-13883.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2419a97618bb 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b0b033e
        Default Java 1.8.0_111
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-compile-root.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-compile-root.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/diff-checkstyle-root.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 43s trunk passed +1 compile 10m 32s trunk passed +1 checkstyle 1m 38s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 2m 8s trunk passed +1 javadoc 1m 11s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch -1 mvninstall 0m 19s hadoop-mapreduce-client-jobclient in the patch failed. -1 compile 7m 48s root in the patch failed. -1 javac 7m 48s root in the patch failed. -0 checkstyle 1m 42s root: The patch generated 2 new + 26 unchanged - 35 fixed = 28 total (was 61) -1 mvnsite 0m 27s hadoop-mapreduce-client-jobclient in the patch failed. +1 mvneclipse 0m 46s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 24s hadoop-mapreduce-client-jobclient in the patch failed. +1 javadoc 1m 14s the patch passed -1 unit 8m 13s hadoop-common in the patch failed. -1 unit 0m 27s hadoop-mapreduce-client-jobclient in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 74m 39s Reason Tests Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13883 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842970/HADOOP-13883.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2419a97618bb 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b0b033e Default Java 1.8.0_111 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11261/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 7m 46s trunk passed
        +1 compile 10m 20s trunk passed
        +1 checkstyle 1m 33s trunk passed
        +1 mvnsite 1m 45s trunk passed
        +1 mvneclipse 0m 40s trunk passed
        +1 findbugs 2m 3s trunk passed
        +1 javadoc 1m 16s trunk passed
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 10s the patch passed
        +1 compile 9m 42s the patch passed
        +1 javac 9m 42s the patch passed
        +1 checkstyle 1m 36s root: The patch generated 0 new + 58 unchanged - 3 fixed = 58 total (was 61)
        +1 mvnsite 1m 50s the patch passed
        +1 mvneclipse 0m 47s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 33s the patch passed
        +1 javadoc 1m 17s the patch passed
        -1 unit 8m 31s hadoop-common in the patch failed.
        +1 unit 103m 39s hadoop-mapreduce-client-jobclient in the patch passed.
        +1 asflicense 0m 46s The patch does not generate ASF License warnings.
        181m 39s



        Reason Tests
        Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13883
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842975/HADOOP-13883.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f421c27bb86f 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b0b033e
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11262/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11262/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11262/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 46s trunk passed +1 compile 10m 20s trunk passed +1 checkstyle 1m 33s trunk passed +1 mvnsite 1m 45s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 2m 3s trunk passed +1 javadoc 1m 16s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 10s the patch passed +1 compile 9m 42s the patch passed +1 javac 9m 42s the patch passed +1 checkstyle 1m 36s root: The patch generated 0 new + 58 unchanged - 3 fixed = 58 total (was 61) +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 33s the patch passed +1 javadoc 1m 17s the patch passed -1 unit 8m 31s hadoop-common in the patch failed. +1 unit 103m 39s hadoop-mapreduce-client-jobclient in the patch passed. +1 asflicense 0m 46s The patch does not generate ASF License warnings. 181m 39s Reason Tests Failed junit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13883 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842975/HADOOP-13883.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f421c27bb86f 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b0b033e Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11262/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11262/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11262/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Latest patch LGTM

        Show
        vinayrpet Vinayakumar B added a comment - Latest patch LGTM
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Vinayakumar B thanks for review...will commit this weekend unless there are further comments.Yiqun Lin can you please attach branch-2.8 patch also( add suffix as addendum).

        Show
        brahmareddy Brahma Reddy Battula added a comment - Vinayakumar B thanks for review...will commit this weekend unless there are further comments. Yiqun Lin can you please attach branch-2.8 patch also( add suffix as addendum).
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Vinayakumar B for the review. Attach a patch for branch-2.8 as Brahma Reddy Battula commented.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Vinayakumar B for the review. Attach a patch for branch-2.8 as Brahma Reddy Battula commented.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 45s Maven dependency ordering for branch
        +1 mvninstall 6m 27s branch-2.8 passed
        +1 compile 5m 50s branch-2.8 passed with JDK v1.8.0_111
        +1 compile 6m 47s branch-2.8 passed with JDK v1.7.0_121
        +1 checkstyle 1m 5s branch-2.8 passed
        +1 mvnsite 1m 28s branch-2.8 passed
        +1 mvneclipse 0m 31s branch-2.8 passed
        +1 findbugs 2m 11s branch-2.8 passed
        +1 javadoc 1m 0s branch-2.8 passed with JDK v1.8.0_111
        +1 javadoc 1m 15s branch-2.8 passed with JDK v1.7.0_121
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 6s the patch passed
        +1 compile 5m 47s the patch passed with JDK v1.8.0_111
        +1 javac 5m 47s the patch passed
        +1 compile 6m 47s the patch passed with JDK v1.7.0_121
        +1 javac 6m 48s the patch passed
        +1 checkstyle 1m 6s root: The patch generated 0 new + 39 unchanged - 3 fixed = 39 total (was 42)
        +1 mvnsite 1m 31s the patch passed
        +1 mvneclipse 0m 38s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 41s the patch passed
        +1 javadoc 1m 5s the patch passed with JDK v1.8.0_111
        +1 javadoc 1m 20s the patch passed with JDK v1.7.0_121
        +1 unit 8m 22s hadoop-common in the patch passed with JDK v1.7.0_121.
        +1 unit 105m 19s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_121.
        -1 asflicense 0m 37s The patch generated 17 ASF License warnings.
        310m 28s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5af2af1
        JIRA Issue HADOOP-13883
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845149/HADOOP-13883-branch-2.8.addendum.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f429e76620bc 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / d7b80f1
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11335/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/11335/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11335/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 6m 27s branch-2.8 passed +1 compile 5m 50s branch-2.8 passed with JDK v1.8.0_111 +1 compile 6m 47s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 1m 5s branch-2.8 passed +1 mvnsite 1m 28s branch-2.8 passed +1 mvneclipse 0m 31s branch-2.8 passed +1 findbugs 2m 11s branch-2.8 passed +1 javadoc 1m 0s branch-2.8 passed with JDK v1.8.0_111 +1 javadoc 1m 15s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 6s the patch passed +1 compile 5m 47s the patch passed with JDK v1.8.0_111 +1 javac 5m 47s the patch passed +1 compile 6m 47s the patch passed with JDK v1.7.0_121 +1 javac 6m 48s the patch passed +1 checkstyle 1m 6s root: The patch generated 0 new + 39 unchanged - 3 fixed = 39 total (was 42) +1 mvnsite 1m 31s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 41s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_111 +1 javadoc 1m 20s the patch passed with JDK v1.7.0_121 +1 unit 8m 22s hadoop-common in the patch passed with JDK v1.7.0_121. +1 unit 105m 19s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_121. -1 asflicense 0m 37s The patch generated 17 ASF License warnings. 310m 28s Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue HADOOP-13883 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845149/HADOOP-13883-branch-2.8.addendum.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f429e76620bc 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / d7b80f1 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11335/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/11335/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11335/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Committed the addendum patch to trunk,branch-2 and branch-2.8..Thanks to all again.

        asf license warnings in branch-2.8 are not related to this patch..I commented in MAPREDUCE-6662.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Committed the addendum patch to trunk,branch-2 and branch-2.8..Thanks to all again. asf license warnings in branch-2.8 are not related to this patch..I commented in MAPREDUCE-6662 .
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Attaching the patch which just added suffix of addendum to trunk patch(HADOOP-13883.005.patch).

        Show
        brahmareddy Brahma Reddy Battula added a comment - Attaching the patch which just added suffix of addendum to trunk patch( HADOOP-13883 .005.patch).
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11061 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11061/)
        HADOOP-13883. Addendum patch to correct the message and alphabetized (brahma: rev 6938b677111a5fa6bf654717b310220f98b7cf20)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        • (edit) hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/TestPipeApplication.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11061 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11061/ ) HADOOP-13883 . Addendum patch to correct the message and alphabetized (brahma: rev 6938b677111a5fa6bf654717b310220f98b7cf20) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java (edit) hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/TestPipeApplication.java
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks for your commit, Brahma Reddy Battula, and thanks for the others.

        Show
        linyiqun Yiqun Lin added a comment - Thanks for your commit, Brahma Reddy Battula , and thanks for the others.

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development