Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13867

FilterFileSystem should override rename(.., options) to take effect of Rename options called via FilterFileSystem implementations

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.9.0, 2.7.4, 3.0.0-alpha2, 2.8.2
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          HDFS-8312 Added Rename.TO_TRASH option to add a security check before moving to trash.

          But for FilterFileSystem implementations since this rename(..options) is not overridden, it uses default FileSystem implementation where Rename.TO_TRASH option is not delegated to NameNode.

            Issue Links

            is related to

            Bug - A problem which impairs or prevents the functions of the product. HDFS-8312 Trash does not descent into child directories to check for permissions

            • Critical - Crashes, loss of data, severe memory leak.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              vinayrpet Vinayakumar B added a comment - - edited

              Attached the patch.
              Please review

              Show
              vinayrpet Vinayakumar B added a comment - - edited Attached the patch. Please review
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 18s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 9m 5s trunk passed
              +1 compile 11m 16s trunk passed
              +1 checkstyle 0m 32s trunk passed
              +1 mvnsite 1m 8s trunk passed
              +1 mvneclipse 0m 18s trunk passed
              +1 findbugs 1m 29s trunk passed
              +1 javadoc 0m 47s trunk passed
              +1 mvninstall 0m 40s the patch passed
              +1 compile 10m 22s the patch passed
              -1 javac 10m 22s root generated 4 new + 711 unchanged - 0 fixed = 715 total (was 711)
              +1 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 0 new + 77 unchanged - 1 fixed = 77 total (was 78)
              +1 mvnsite 1m 9s the patch passed
              +1 mvneclipse 0m 18s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 44s the patch passed
              +1 javadoc 0m 50s the patch passed
              +1 unit 8m 0s hadoop-common in the patch passed.
              +1 asflicense 0m 31s The patch does not generate ASF License warnings.
              50m 52s



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:a9ad5d6
              JIRA Issue HADOOP-13867
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841947/HADOOP-13867-01.patch
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux 11a2e9950320 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / 7b988e8
              Default Java 1.8.0_111
              findbugs v3.0.0
              javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11203/artifact/patchprocess/diff-compile-javac-root.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11203/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11203/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 5s trunk passed +1 compile 11m 16s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 10m 22s the patch passed -1 javac 10m 22s root generated 4 new + 711 unchanged - 0 fixed = 715 total (was 711) +1 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 0 new + 77 unchanged - 1 fixed = 77 total (was 78) +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 8m 0s hadoop-common in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 50m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13867 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841947/HADOOP-13867-01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 11a2e9950320 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7b988e8 Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11203/artifact/patchprocess/diff-compile-javac-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11203/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11203/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              vinayrpet Vinayakumar B added a comment -

              javac errors are expected, as rename(,, options) is deprecated.

              Show
              vinayrpet Vinayakumar B added a comment - javac errors are expected, as rename(,, options) is deprecated.
              Hide
              Permalink
              andrew.wang Andrew Wang added a comment -

              LGTM +1 thanks Vinay

              Show
              andrew.wang Andrew Wang added a comment - LGTM +1 thanks Vinay
              Hide
              Permalink
              brahmareddy Brahma Reddy Battula added a comment -

              me too,+1.

              Show
              brahmareddy Brahma Reddy Battula added a comment - me too,+1.
              Hide
              Permalink
              brahmareddy Brahma Reddy Battula added a comment -

              Committed to trunk,branch-2..Thanks Vinayakumar B for contribution and Andrew Wang for review.

              Show
              brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2..Thanks Vinayakumar B for contribution and Andrew Wang for review.
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10970 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10970/)
              HADOOP-13867. FilterFileSystem should override rename(.., options) to (brahma: rev 0ef796174ecb5383f79cfecfcbfc4f309d093cd7)

              • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
              • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFilterFileSystem.java
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10970 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10970/ ) HADOOP-13867 . FilterFileSystem should override rename(.., options) to (brahma: rev 0ef796174ecb5383f79cfecfcbfc4f309d093cd7) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFilterFileSystem.java
              Hide
              Permalink
              brahmareddy Brahma Reddy Battula added a comment -

              Hi Vinayakumar B
              HDFS-8312 is backported to branch-2.7.. can you able to update branch-2.7 patch for this issue..?

              Show
              brahmareddy Brahma Reddy Battula added a comment - Hi Vinayakumar B HDFS-8312 is backported to branch-2.7.. can you able to update branch-2.7 patch for this issue..?
              Hide
              Permalink
              brahmareddy Brahma Reddy Battula added a comment - - edited

              Pushed to branch-2.8.2 and branch-2.7. Changes are straight forward and verified locally.

              Show
              brahmareddy Brahma Reddy Battula added a comment - - edited Pushed to branch-2.8.2 and branch-2.7 . Changes are straight forward and verified locally.
              Hide
              Permalink
              brahmareddy Brahma Reddy Battula added a comment -

              Pushed to branch-2.8 also.

              Show
              brahmareddy Brahma Reddy Battula added a comment - Pushed to branch-2.8 also.

                People

                • Assignee:
                  vinayrpet Vinayakumar B
                  Reporter:
                  vinayrpet Vinayakumar B
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development