Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13852

hadoop build to allow hadoop version property to be explicitly set

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1, 3.0.0-alpha2
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Hive (and transitively) Spark, won't start on Hadoop 3.x as the shim layer rejects Hadoop v3. As a workaround pending a Hive fix, allow the build to have the Hadoop version (currently set to pom.version) to be overridden manually.

      This will not affect version names of artifacts, merely the declared Hadoop version visible in VersionInfo.getVersion()

      1. HADOOP-13582-003.patch
        2 kB
        Steve Loughran
      2. HADOOP-13852-001.patch
        1 kB
        Steve Loughran
      3. HADOOP-13852-002.patch
        2 kB
        Steve Loughran
      4. HADOOP-13852-003.patch
        4 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch allows a build with an argument like -Ddeclared.hadoop.version=2.11 to specify the build to be returned via an API call.

          When you do a build with that option, Spark DF test runs do appear to work again.

          Show
          stevel@apache.org Steve Loughran added a comment - Patch allows a build with an argument like -Ddeclared.hadoop.version=2.11 to specify the build to be returned via an API call. When you do a build with that option, Spark DF test runs do appear to work again.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 38s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 17s trunk passed
          +1 compile 9m 34s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 javadoc 0m 47s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 9m 6s the patch passed
          +1 javac 9m 6s the patch passed
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 47s the patch passed
          +1 unit 7m 38s hadoop-common in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          46m 40s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13852
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841273/HADOOP-13852-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux f55528d8ffbe 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1f7613b
          Default Java 1.8.0_111
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11175/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11175/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 38s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 17s trunk passed +1 compile 9m 34s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 18s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 6s the patch passed +1 javac 9m 6s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 47s the patch passed +1 unit 7m 38s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 46m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13852 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841273/HADOOP-13852-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux f55528d8ffbe 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1f7613b Default Java 1.8.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11175/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11175/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Hi Steve, there's also a reference in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-version-info.properties which should probably be addressed.

          What makes this change more expedient than fixing the Hive/Spark shim?

          Show
          andrew.wang Andrew Wang added a comment - Hi Steve, there's also a reference in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-version-info.properties which should probably be addressed. What makes this change more expedient than fixing the Hive/Spark shim?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I guess the yarn one should be kept in sync.

          One thing that the patch does is let todays spark releases be tested against Hadoop 3.x, otherwise it will need (a) an updated org.spark-project.hive JAR and a matching spark release.

          Show
          stevel@apache.org Steve Loughran added a comment - I guess the yarn one should be kept in sync. One thing that the patch does is let todays spark releases be tested against Hadoop 3.x, otherwise it will need (a) an updated org.spark-project.hive JAR and a matching spark release.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for the explanation Steve. This seems harmless, so I'm +1 pending the YARN instance also being addressed.

          Show
          andrew.wang Andrew Wang added a comment - Thanks for the explanation Steve. This seems harmless, so I'm +1 pending the YARN instance also being addressed.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          patch 2 updates the YARN one.

          I'm going to propose this for the s3guard branch, irrespective of what happens in trunk, so that it enables spark to be used for regression testing

          Show
          stevel@apache.org Steve Loughran added a comment - patch 2 updates the YARN one. I'm going to propose this for the s3guard branch, irrespective of what happens in trunk, so that it enables spark to be used for regression testing
          Hide
          andrew.wang Andrew Wang added a comment -

          Hit the "submit patch" button to get a precommit run, I'm still +1 pending. Thanks Steve!

          Show
          andrew.wang Andrew Wang added a comment - Hit the "submit patch" button to get a precommit run, I'm still +1 pending. Thanks Steve!
          Hide
          stevel@apache.org Steve Loughran added a comment -

          thanks for this; it'll help us with testing things

          Show
          stevel@apache.org Steve Loughran added a comment - thanks for this; it'll help us with testing things
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 56s trunk passed
          +1 compile 9m 36s trunk passed
          +1 mvnsite 1m 39s trunk passed
          +1 mvneclipse 0m 36s trunk passed
          +1 javadoc 1m 20s trunk passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 4s the patch passed
          +1 compile 9m 18s the patch passed
          +1 javac 9m 18s the patch passed
          +1 mvnsite 1m 36s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 1m 20s the patch passed
          -1 unit 8m 14s hadoop-common in the patch failed.
          +1 unit 2m 23s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          46m 55s



          Reason Tests
          Failed junit tests hadoop.net.TestClusterTopology
            hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13852
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842150/HADOOP-13852-002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux bf030c966bf8 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a793cec
          Default Java 1.8.0_111
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11212/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11212/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11212/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 56s trunk passed +1 compile 9m 36s trunk passed +1 mvnsite 1m 39s trunk passed +1 mvneclipse 0m 36s trunk passed +1 javadoc 1m 20s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 4s the patch passed +1 compile 9m 18s the patch passed +1 javac 9m 18s the patch passed +1 mvnsite 1m 36s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 20s the patch passed -1 unit 8m 14s hadoop-common in the patch failed. +1 unit 2m 23s hadoop-yarn-common in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 46m 55s Reason Tests Failed junit tests hadoop.net.TestClusterTopology   hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13852 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842150/HADOOP-13852-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux bf030c966bf8 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a793cec Default Java 1.8.0_111 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11212/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11212/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11212/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10971 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10971/)
          HADOOP-13852 hadoop build to allow hadoop version property to be (stevel: rev c2655157257079b8541d71bb1e5b6cbae75561ff)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-version-info.properties
          • (edit) hadoop-common-project/hadoop-common/src/main/resources/common-version-info.properties
          • (edit) BUILDING.txt
          • (edit) hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10971 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10971/ ) HADOOP-13852 hadoop build to allow hadoop version property to be (stevel: rev c2655157257079b8541d71bb1e5b6cbae75561ff) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-version-info.properties (edit) hadoop-common-project/hadoop-common/src/main/resources/common-version-info.properties (edit) BUILDING.txt (edit) hadoop-common-project/hadoop-common/pom.xml
          Hide
          stevel@apache.org Steve Loughran added a comment -

          fixed in trunk; also added a couple of lines into BUILDING.TXT about how to do this.

          (+ added -Dmaven.javadoc.skip=true as an option in mvn package; everyone should know that)

          Show
          stevel@apache.org Steve Loughran added a comment - fixed in trunk; also added a couple of lines into BUILDING.TXT about how to do this. (+ added -Dmaven.javadoc.skip=true as an option in mvn package ; everyone should know that)
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Hi, I think this commit broke the TestRMWebServicesNodes.
          Any ideas what caused the problem and how we can fix it?

          Thanks!

          Show
          kkaranasos Konstantinos Karanasos added a comment - Hi, I think this commit broke the TestRMWebServicesNodes . Any ideas what caused the problem and how we can fix it? Thanks!
          Hide
          ajisakaa Akira Ajisaka added a comment - - edited

          Hi, I think this commit broke the TestRMWebServicesNodes.
          Any ideas what caused the problem and how we can fix it?

          hadoop-common-project/hadoop-common/pom.xml
              <!-- the version of Hadoop declared in the version resources; can be overridden
              so that Hadoop 3.x can declare itself a 2.x artifact. -->
              <declared.hadoop.version>${pom.version}</declared.hadoop.version>
          

          The setting is in hadoop-common module, but I think the setting should be in hadoop-project module. hadoop-common module is not a parent of hadoop-yarn module, so the test cannot use the above setting.

          Show
          ajisakaa Akira Ajisaka added a comment - - edited Hi, I think this commit broke the TestRMWebServicesNodes. Any ideas what caused the problem and how we can fix it? hadoop-common-project/hadoop-common/pom.xml <!-- the version of Hadoop declared in the version resources; can be overridden so that Hadoop 3.x can declare itself a 2.x artifact. --> <declared.hadoop.version>${pom.version}</declared.hadoop.version> The setting is in hadoop-common module, but I think the setting should be in hadoop-project module. hadoop-common module is not a parent of hadoop-yarn module, so the test cannot use the above setting.
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Thanks for the reply, Akira Ajisaka.
          I also found two more test classes that are failing currently on trunk, namely TestRMWebServices and TestNMWebServices. They are related to the last couple of days commits, but I did not manage to figure out which exact commit it was (since I was getting the failures only intermittently).

          Show
          kkaranasos Konstantinos Karanasos added a comment - Thanks for the reply, Akira Ajisaka . I also found two more test classes that are failing currently on trunk, namely TestRMWebServices and TestNMWebServices . They are related to the last couple of days commits, but I did not manage to figure out which exact commit it was (since I was getting the failures only intermittently).
          Hide
          ajisakaa Akira Ajisaka added a comment -

          It looks like the failures of TestRMWebServices and TestNMWebServices are related to this commit.

          Show
          ajisakaa Akira Ajisaka added a comment - It looks like the failures of TestRMWebServices and TestNMWebServices are related to this commit.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Reverted this commit. Hi Steve Loughran, would you move the setting to hadoop-project pom.xml?

          Show
          ajisakaa Akira Ajisaka added a comment - Reverted this commit. Hi Steve Loughran , would you move the setting to hadoop-project pom.xml?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10974 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10974/)
          Revert "HADOOP-13852 hadoop build to allow hadoop version property to be (aajisaka: rev 7d8e440eee51562d0769efe04eb97256fe6061d1)

          • (edit) BUILDING.txt
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-version-info.properties
          • (edit) hadoop-common-project/hadoop-common/src/main/resources/common-version-info.properties
          • (edit) hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10974 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10974/ ) Revert " HADOOP-13852 hadoop build to allow hadoop version property to be (aajisaka: rev 7d8e440eee51562d0769efe04eb97256fe6061d1) (edit) BUILDING.txt (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-version-info.properties (edit) hadoop-common-project/hadoop-common/src/main/resources/common-version-info.properties (edit) hadoop-common-project/hadoop-common/pom.xml
          Hide
          stevel@apache.org Steve Loughran added a comment -

          oh, I get it. Sorry. Let me (a) fix it so that the hadoop-project gets it, and submit a patch to YARN JIRA too

          Show
          stevel@apache.org Steve Loughran added a comment - oh, I get it. Sorry. Let me (a) fix it so that the hadoop-project gets it, and submit a patch to YARN JIRA too
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 003

          1. moves variable set to hadoop-project/pom.xml
          2. verifies that yarn-common/target/classes/version-info.properties has the version data
          3. verifies that TestRMWebServicesNodes passes
          Show
          stevel@apache.org Steve Loughran added a comment - Patch 003 moves variable set to hadoop-project/pom.xml verifies that yarn-common/target/classes/version-info.properties has the version data verifies that TestRMWebServicesNodes passes
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 8m 20s trunk passed
          +1 compile 11m 16s trunk passed
          +1 mvnsite 2m 4s trunk passed
          +1 mvneclipse 0m 49s trunk passed
          +1 javadoc 1m 39s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 25s the patch passed
          +1 compile 11m 3s the patch passed
          +1 javac 11m 3s the patch passed
          +1 mvnsite 2m 7s the patch passed
          +1 mvneclipse 0m 52s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 1m 39s the patch passed
          +1 unit 0m 13s hadoop-project in the patch passed.
          +1 unit 9m 23s hadoop-common in the patch passed.
          +1 unit 2m 33s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          55m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13852
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842557/HADOOP-13582-003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 45af14786fe9 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 80b8023
          Default Java 1.8.0_111
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11235/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11235/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 8m 20s trunk passed +1 compile 11m 16s trunk passed +1 mvnsite 2m 4s trunk passed +1 mvneclipse 0m 49s trunk passed +1 javadoc 1m 39s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 25s the patch passed +1 compile 11m 3s the patch passed +1 javac 11m 3s the patch passed +1 mvnsite 2m 7s the patch passed +1 mvneclipse 0m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 39s the patch passed +1 unit 0m 13s hadoop-project in the patch passed. +1 unit 9m 23s hadoop-common in the patch passed. +1 unit 2m 33s hadoop-yarn-common in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 55m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13852 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842557/HADOOP-13582-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 45af14786fe9 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 80b8023 Default Java 1.8.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11235/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11235/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Thanks, Steve Loughran and Akira Ajisaka, for taking care of this.

          Show
          kkaranasos Konstantinos Karanasos added a comment - Thanks, Steve Loughran and Akira Ajisaka , for taking care of this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, thanks Steve Loughran for the update.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, thanks Steve Loughran for the update.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10986 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10986/)
          HADOOP-13852 hadoop build to allow hadoop version property to be (stevel: rev f66f61892ac7cbd57e8323d0a2a90cf58e9286ce)

          • (edit) hadoop-common-project/hadoop-common/src/main/resources/common-version-info.properties
          • (edit) BUILDING.txt
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-version-info.properties
          • (edit) hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10986 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10986/ ) HADOOP-13852 hadoop build to allow hadoop version property to be (stevel: rev f66f61892ac7cbd57e8323d0a2a90cf58e9286ce) (edit) hadoop-common-project/hadoop-common/src/main/resources/common-version-info.properties (edit) BUILDING.txt (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-version-info.properties (edit) hadoop-project/pom.xml
          Hide
          liuml07 Mingliang Liu added a comment -

          The latest patch was committed in trunk. I think Steve attached the wrong patch file here? Re-attach the file for record.

          Patch looks good to me (though Im running late); I manually tested the broken unit test failures as well and they are passing.

          Show
          liuml07 Mingliang Liu added a comment - The latest patch was committed in trunk. I think Steve attached the wrong patch file here? Re-attach the file for record. Patch looks good to me (though Im running late); I manually tested the broken unit test failures as well and they are passing.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Note that you need to set dfs.namenode.min.supported.datanode.version and dfs.datanode.min.supported.namenode.version properly to run NameNode and DataNode daemons. For example, if you build trunk with -Ddeclared.hadoop.version=2.8.0, you need to set the two properties to 2.8.0 or lower as well.

          Show
          ajisakaa Akira Ajisaka added a comment - Note that you need to set dfs.namenode.min.supported.datanode.version and dfs.datanode.min.supported.namenode.version properly to run NameNode and DataNode daemons. For example, if you build trunk with -Ddeclared.hadoop.version=2.8.0 , you need to set the two properties to 2.8.0 or lower as well.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          well spotted. I'd not seen that, as I'd just been using this to get hadoop/hive/spark client code working, not HDFS clusters

          Show
          stevel@apache.org Steve Loughran added a comment - well spotted. I'd not seen that, as I'd just been using this to get hadoop/hive/spark client code working, not HDFS clusters
          Hide
          jpallas Joe Pallas added a comment -

          Maven is issuing dozens of warnings:

          [WARNING] Some problems were encountered while building the effective model for org.apache.hadoop:hadoop-project:pom:3.0.0-alpha2-SNAPSHOT
          [WARNING] The expression ${pom.version} is deprecated. Please use ${project.version} instead.
          
          Show
          jpallas Joe Pallas added a comment - Maven is issuing dozens of warnings: [WARNING] Some problems were encountered while building the effective model for org.apache.hadoop:hadoop-project:pom:3.0.0-alpha2-SNAPSHOT [WARNING] The expression ${pom.version} is deprecated. Please use ${project.version} instead.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          ...oh, I get it. The version info file used the pom.version reference, but mvn didn't notice that to tell everyone off.

          I'll create a followon

          Show
          stevel@apache.org Steve Loughran added a comment - ...oh, I get it. The version info file used the pom.version reference, but mvn didn't notice that to tell everyone off. I'll create a followon
          Hide
          ajisakaa Akira Ajisaka added a comment -

          After HDFS-11188, we don't need to set these properties because the default values have changed.

          Show
          ajisakaa Akira Ajisaka added a comment - After HDFS-11188 , we don't need to set these properties because the default values have changed.

            People

            • Assignee:
              stevel@apache.org Steve Loughran
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development