Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: viewfs
    • Labels:
      None

      Description

      ViewFileSystem doesn't override FileSystem#getUSed(). So, when file system used space is queried for slash root "/" paths, the default implementations tries to run the getContentSummary which crashes on seeing unexpected mount points under slash.

      ViewFileSystem#getUsed() is not expected to collate all the space used from all the mount points configured under "/". Proposal is to avoid invoking FileSystem#getUsed() and throw NotInMountPointException until LinkMergeSlash is supported.

      1. HADOOP-13840.01.patch
        3 kB
        Manoj Govindassamy
      2. HADOOP-13840.02.patch
        3 kB
        Manoj Govindassamy

        Activity

        Hide
        manojg Manoj Govindassamy added a comment - - edited

        Attached v0 patch to address the following
        1. Made ViewFileSystem#getUsed() to throw an exception when the SlashRoot is not supported or not configured.
        2. Test to validate getUsed() returning same space usage numbers when accessed via ViewFileSystem and the target FileSystem.

        Andrew Wang, can you please review the patch ?

        Show
        manojg Manoj Govindassamy added a comment - - edited Attached v0 patch to address the following 1. Made ViewFileSystem#getUsed() to throw an exception when the SlashRoot is not supported or not configured. 2. Test to validate getUsed() returning same space usage numbers when accessed via ViewFileSystem and the target FileSystem. Andrew Wang , can you please review the patch ?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 24s trunk passed
        +1 compile 10m 20s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 25s trunk passed
        +1 javadoc 0m 47s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 9m 54s the patch passed
        +1 javac 9m 54s the patch passed
        +1 checkstyle 0m 33s the patch passed
        +1 mvnsite 1m 6s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 46s the patch passed
        -1 javadoc 0m 49s hadoop-common-project_hadoop-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
        -1 unit 8m 19s hadoop-common in the patch failed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        48m 48s



        Reason Tests
        Failed junit tests hadoop.fs.viewfs.TestViewFsTrash



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13840
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840779/HADOOP-13840.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 32ceb9a486f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 47ca9e2
        Default Java 1.8.0_111
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11152/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11152/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11152/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 24s trunk passed +1 compile 10m 20s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 54s the patch passed +1 javac 9m 54s the patch passed +1 checkstyle 0m 33s the patch passed +1 mvnsite 1m 6s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed -1 javadoc 0m 49s hadoop-common-project_hadoop-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) -1 unit 8m 19s hadoop-common in the patch failed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 48m 48s Reason Tests Failed junit tests hadoop.fs.viewfs.TestViewFsTrash Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13840 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840779/HADOOP-13840.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 32ceb9a486f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 47ca9e2 Default Java 1.8.0_111 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11152/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11152/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11152/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        manojg Manoj Govindassamy added a comment -

        TestViewFsTrash is passing through locally for me. Suspecting some file operations are failing in the test and may not be related to the patch. Will dig more.

        Show
        manojg Manoj Govindassamy added a comment - TestViewFsTrash is passing through locally for me. Suspecting some file operations are failing in the test and may not be related to the patch. Will dig more.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        can you switch to assertEquals() for the equality test in the assertion; it provides meaningful details on a failure *provided the expected value comes first(

        assertEquals("space used", usedSpceByPathViaTargetFs ,usedSpcByPathViaViewFs)
        
        Show
        stevel@apache.org Steve Loughran added a comment - can you switch to assertEquals() for the equality test in the assertion; it provides meaningful details on a failure *provided the expected value comes first( assertEquals( "space used" , usedSpceByPathViaTargetFs ,usedSpcByPathViaViewFs)
        Hide
        manojg Manoj Govindassamy added a comment -

        Thanks Steve Loughran. Yes, assertEquals can give us verbose information on the comparisons done. Updated the patch with Assert.assertTrue replaced with assertEquals.

        Show
        manojg Manoj Govindassamy added a comment - Thanks Steve Loughran . Yes, assertEquals can give us verbose information on the comparisons done. Updated the patch with Assert.assertTrue replaced with assertEquals.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 55s trunk passed
        +1 compile 10m 41s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 10s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 29s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 42s the patch passed
        +1 compile 10m 37s the patch passed
        +1 javac 10m 37s the patch passed
        +1 checkstyle 0m 30s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 38s the patch passed
        -1 javadoc 0m 49s hadoop-common-project_hadoop-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
        +1 unit 8m 34s hadoop-common in the patch passed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        48m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13840
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840911/HADOOP-13840.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3b1ea88171bc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b407d53
        Default Java 1.8.0_111
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11161/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11161/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11161/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 55s trunk passed +1 compile 10m 41s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 10m 37s the patch passed +1 javac 10m 37s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 38s the patch passed -1 javadoc 0m 49s hadoop-common-project_hadoop-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) +1 unit 8m 34s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 48m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13840 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840911/HADOOP-13840.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3b1ea88171bc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b407d53 Default Java 1.8.0_111 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11161/artifact/patchprocess/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11161/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11161/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        LGTM +1 besides the flagged javadoc errors. Thanks for working on this Manoj!

        Show
        andrew.wang Andrew Wang added a comment - LGTM +1 besides the flagged javadoc errors. Thanks for working on this Manoj!
        Hide
        manojg Manoj Govindassamy added a comment -

        Attaching v02 to address javadoc style issues. Thanks for the review Andrew Wang.

        Show
        manojg Manoj Govindassamy added a comment - Attaching v02 to address javadoc style issues. Thanks for the review Andrew Wang .
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 27s trunk passed
        +1 compile 9m 49s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 47s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 9m 18s the patch passed
        +1 javac 9m 18s the patch passed
        +1 checkstyle 0m 30s the patch passed
        +1 mvnsite 1m 5s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 50s the patch passed
        +1 unit 8m 23s hadoop-common in the patch passed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        47m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13840
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841186/HADOOP-13840.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4bfa602a9ce9 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7226a71
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11172/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11172/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 27s trunk passed +1 compile 9m 49s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 18s the patch passed +1 javac 9m 18s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 8m 23s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 47m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13840 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841186/HADOOP-13840.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4bfa602a9ce9 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7226a71 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11172/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11172/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk. Thanks again for working on this Manoj!

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk. Thanks again for working on this Manoj!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10922 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10922/)
        HADOOP-13840. Implement getUsed() for ViewFileSystem. Contributed by (wang: rev 1f7613be958bbdb735fd2b49e3f0b48e2c8b7c13)

        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10922 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10922/ ) HADOOP-13840 . Implement getUsed() for ViewFileSystem. Contributed by (wang: rev 1f7613be958bbdb735fd2b49e3f0b48e2c8b7c13) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java

          People

          • Assignee:
            manojg Manoj Govindassamy
            Reporter:
            manojg Manoj Govindassamy
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development