Details
-
Type:
Task
-
Status: Patch Available
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: 3.0.0-alpha2
-
Component/s: test
-
Labels:None
-
Hadoop Flags:Reviewed
Description
The mapreduce project has Google Test Framework code to allow testing of native libraries. This should be moved to hadoop-common so that other projects can use it as well.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Thanks Varun Vasudev for the work. Would you update the path in LICENSE.txt as well?
LICENSE.txt
For hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nat
ivetask/src/main/native/gtest
---------------------------------------------------------------------
Copyright 2008, Google Inc.
All rights reserved.
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 15s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| 0 | mvndep | 1m 51s | Maven dependency ordering for branch |
| +1 | mvninstall | 6m 48s | trunk passed |
| +1 | compile | 9m 32s | trunk passed |
| +1 | mvnsite | 1m 28s | trunk passed |
| +1 | mvneclipse | 0m 37s | trunk passed |
| 0 | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 | mvninstall | 0m 52s | the patch passed |
| +1 | compile | 9m 17s | the patch passed |
| -1 | cc | 9m 17s | root generated 25 new + 7 unchanged - 0 fixed = 32 total (was 7) |
| +1 | javac | 9m 17s | the patch passed |
| +1 | mvnsite | 1m 25s | the patch passed |
| +1 | mvneclipse | 0m 37s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | unit | 8m 23s | hadoop-common in the patch passed. |
| -1 | unit | 8m 36s | hadoop-mapreduce-client-nativetask in the patch failed. |
| -1 | asflicense | 0m 33s | The patch generated 2 ASF License warnings. |
| 51m 8s |
This message was automatically generated.
Thanks for the catch Akira Ajisaka! Uploaded a new patch with the fix.
How about committing MAPREDUCE-6743 first?
Allen Wittenauer - sure. I can wait for MAPREDUCE-6743 to go in.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 16s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| 0 | mvndep | 1m 0s | Maven dependency ordering for branch |
| +1 | mvninstall | 7m 46s | trunk passed |
| +1 | compile | 11m 5s | trunk passed |
| +1 | mvnsite | 11m 0s | trunk passed |
| +1 | mvneclipse | 1m 11s | trunk passed |
| 0 | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 | mvninstall | 9m 3s | the patch passed |
| +1 | compile | 10m 30s | the patch passed |
| -1 | cc | 10m 30s | root generated 25 new + 7 unchanged - 0 fixed = 32 total (was 7) |
| +1 | javac | 10m 30s | the patch passed |
| +1 | mvnsite | 10m 48s | the patch passed |
| +1 | mvneclipse | 1m 10s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 | unit | 119m 30s | root in the patch failed. |
| -1 | asflicense | 0m 34s | The patch generated 4 ASF License warnings. |
| 184m 47s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.yarn.server.timeline.webapp.TestTimelineWebServices |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HADOOP-13835 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12840606/HADOOP-13835.002.patch |
| Optional Tests | asflicense compile cc mvnsite javac unit |
| uname | Linux 188e8f5af233 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 9e173d2 |
| Default Java | 1.8.0_111 |
| cc | https://builds.apache.org/job/PreCommit-HADOOP-Build/11145/artifact/patchprocess/diff-compile-cc-root.txt |
| unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/11145/artifact/patchprocess/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/11145/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HADOOP-Build/11145/artifact/patchprocess/patch-asflicense-problems.txt |
| modules | C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/11145/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Uploaded a new patch after MAPREDUCE-6743
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 11s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| 0 | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 | mvninstall | 7m 7s | trunk passed |
| +1 | compile | 10m 0s | trunk passed |
| +1 | mvnsite | 10m 52s | trunk passed |
| +1 | mvneclipse | 1m 24s | trunk passed |
| +1 | javadoc | 5m 35s | trunk passed |
| 0 | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 | mvninstall | 9m 9s | the patch passed |
| +1 | compile | 10m 53s | the patch passed |
| -1 | cc | 10m 53s | root generated 25 new + 7 unchanged - 0 fixed = 32 total (was 7) |
| +1 | javac | 10m 53s | the patch passed |
| +1 | mvnsite | 11m 13s | the patch passed |
| +1 | mvneclipse | 1m 13s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 | javadoc | 5m 16s | the patch passed |
| -1 | unit | 102m 56s | root in the patch failed. |
| -1 | asflicense | 0m 33s | The patch generated 2 ASF License warnings. |
| 177m 59s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot |
| hadoop.yarn.server.timeline.webapp.TestTimelineWebServices |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HADOOP-13835 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12841007/HADOOP-13835.003.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml cc |
| uname | Linux 6c5cb17f0f7e 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 51e6c1c |
| Default Java | 1.8.0_111 |
| cc | https://builds.apache.org/job/PreCommit-HADOOP-Build/11166/artifact/patchprocess/diff-compile-cc-root.txt |
| unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/11166/artifact/patchprocess/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/11166/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HADOOP-Build/11166/artifact/patchprocess/patch-asflicense-problems.txt |
| modules | C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/11166/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
The ASF license warnings and the test failures are unrelated to the patch. The cc warnings are due to the google test code. Allen Wittenauer - is there a way to suppress the cc warnings?
Akira Ajisaka - can you please review the latest patch? Thanks!
Would you remove the following setting in rat plugin?
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
<!-- gtest has a compatible license -->
<exclude>src/main/native/gtest/**/*</exclude>
I don't think the following changes are needed.
CMakeLists.txt
-include_directories(SYSTEM ${SRC}/gtest/include)
+# include_directories(SYSTEM ${SRC}/gtest/include)
-set(CMAKE_MACOSX_RPATH TRUE)
set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
-set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
Adding set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE) is needed for me to run `mvn test -Pnative` in hadoop-mapreduce-client-nativetask module successfully on CentOS 7.2.
Thanks for the review Akira Ajisaka! I've addressed your feedback in the latest patch.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 17s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| 0 | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 | mvninstall | 7m 13s | trunk passed |
| +1 | compile | 10m 50s | trunk passed |
| +1 | mvnsite | 10m 42s | trunk passed |
| +1 | mvneclipse | 1m 22s | trunk passed |
| +1 | javadoc | 5m 9s | trunk passed |
| 0 | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 | mvninstall | 9m 33s | the patch passed |
| -1 | compile | 8m 48s | root in the patch failed. |
| -1 | cc | 8m 48s | root in the patch failed. |
| -1 | javac | 8m 48s | root in the patch failed. |
| +1 | mvnsite | 10m 12s | the patch passed |
| +1 | mvneclipse | 1m 11s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 | javadoc | 4m 35s | the patch passed |
| -1 | unit | 132m 44s | root in the patch failed. |
| -1 | asflicense | 0m 38s | The patch generated 2 ASF License warnings. |
| 204m 52s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
| hadoop.yarn.server.timeline.webapp.TestTimelineWebServices |
This message was automatically generated.
-005
Fix the compile errors in mapreduce.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 15s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| 0 | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 | mvninstall | 6m 45s | trunk passed |
| +1 | compile | 9m 31s | trunk passed |
| +1 | mvnsite | 10m 34s | trunk passed |
| +1 | mvneclipse | 1m 12s | trunk passed |
| +1 | javadoc | 4m 59s | trunk passed |
| 0 | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 | mvninstall | 9m 3s | the patch passed |
| +1 | compile | 10m 33s | the patch passed |
| -1 | cc | 10m 33s | root generated 25 new + 7 unchanged - 0 fixed = 32 total (was 7) |
| +1 | javac | 10m 33s | the patch passed |
| +1 | mvnsite | 10m 49s | the patch passed |
| +1 | mvneclipse | 1m 6s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 | javadoc | 4m 46s | the patch passed |
| -1 | unit | 14m 28s | root in the patch failed. |
| -1 | asflicense | 0m 31s | The patch generated 2 ASF License warnings. |
| 86m 0s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.ha.TestZKFailoverController |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HADOOP-13835 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12841282/HADOOP-13835.005.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml cc |
| uname | Linux d769bad1bead 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 1f7613b |
| Default Java | 1.8.0_111 |
| cc | https://builds.apache.org/job/PreCommit-HADOOP-Build/11176/artifact/patchprocess/diff-compile-cc-root.txt |
| unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/11176/artifact/patchprocess/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/11176/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HADOOP-Build/11176/artifact/patchprocess/patch-asflicense-problems.txt |
| modules | C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/11176/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Akira Ajisaka - I think the latest patch is ready for review. Can you take a look? Thanks!
-006
1) Fix a typo in CMakeLists.txt
2) Fix path for adding gtest files to system libs in CMakeLists.txt
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 10s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| 0 | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 | mvninstall | 6m 49s | trunk passed |
| +1 | compile | 9m 28s | trunk passed |
| +1 | mvnsite | 9m 33s | trunk passed |
| +1 | mvneclipse | 1m 13s | trunk passed |
| +1 | javadoc | 4m 22s | trunk passed |
| 0 | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 | mvninstall | 7m 31s | the patch passed |
| +1 | compile | 10m 0s | the patch passed |
| -1 | cc | 10m 0s | root generated 25 new + 7 unchanged - 0 fixed = 32 total (was 7) |
| +1 | javac | 10m 0s | the patch passed |
| +1 | mvnsite | 11m 12s | the patch passed |
| +1 | mvneclipse | 1m 13s | the patch passed |
| +1 | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 | javadoc | 5m 30s | the patch passed |
| -1 | unit | 110m 54s | root in the patch failed. |
| -1 | asflicense | 0m 37s | The patch generated 2 ASF License warnings. |
| 180m 2s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.yarn.server.timeline.webapp.TestTimelineWebServices |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HADOOP-13835 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12841412/HADOOP-13835.006.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml cc |
| uname | Linux c451f945ca3d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c87b3a4 |
| Default Java | 1.8.0_111 |
| cc | https://builds.apache.org/job/PreCommit-HADOOP-Build/11180/artifact/patchprocess/diff-compile-cc-root.txt |
| unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/11180/artifact/patchprocess/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/11180/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HADOOP-Build/11180/artifact/patchprocess/patch-asflicense-problems.txt |
| modules | C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/11180/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
# add gtest as system library to suppress gcc warnings
include_directories(SYSTEM ${GTEST_SRC_DIR}/gtest/include)
${GTEST_SRC_DIR}/gtest/include should be ${GTEST_SRC_DIR}/include?
Fix path for system dirs in CMakeLists.txt
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 13s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| 0 | mvndep | 0m 16s | Maven dependency ordering for branch |
| +1 | mvninstall | 6m 52s | trunk passed |
| +1 | compile | 9m 34s | trunk passed |
| +1 | mvnsite | 9m 41s | trunk passed |
| +1 | mvneclipse | 1m 15s | trunk passed |
| +1 | javadoc | 4m 21s | trunk passed |
| 0 | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 | mvninstall | 7m 35s | the patch passed |
| +1 | compile | 9m 13s | the patch passed |
| +1 | cc | 9m 13s | the patch passed |
| +1 | javac | 9m 13s | the patch passed |
| +1 | mvnsite | 9m 29s | the patch passed |
| +1 | mvneclipse | 1m 5s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 | javadoc | 4m 22s | the patch passed |
| -1 | unit | 108m 16s | root in the patch failed. |
| -1 | asflicense | 0m 34s | The patch generated 2 ASF License warnings. |
| 173m 58s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.yarn.server.timeline.webapp.TestTimelineWebServices |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HADOOP-13835 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12841761/HADOOP-13835.007.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml cc |
| uname | Linux c8d75a4ea6ea 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / f885160 |
| Default Java | 1.8.0_111 |
| unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/11198/artifact/patchprocess/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/11198/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HADOOP-Build/11198/artifact/patchprocess/patch-asflicense-problems.txt |
| modules | C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/11198/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1, thanks Varun Vasudev for updating the patch.
Committed this to trunk. Thanks Varun Vasudev for the contribution.
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10945 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10945/)
HADOOP-13835. Move Google Test Framework code from mapreduce to (aajisaka: rev b2a3d6c519d83283a49b0d2172dcf1de97f9c4bc)
- (add) hadoop-common-project/hadoop-common/src/main/native/gtest/include/gtest/gtest.h
- (edit) LICENSE.txt
- (delete) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include/gtest/gtest.h
- (add) hadoop-common-project/hadoop-common/src/main/native/gtest/gtest-all.cc
- (delete) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/gtest-all.cc
- (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
- (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt
- (edit) hadoop-common-project/hadoop-common/pom.xml
Thanks for the review and commit Akira Ajisaka!
Akira Ajisaka, Varun Vasudev, I think this patch should be backported to branch-2 as well since we have other patches need gtest. For example YARN-6852, YARN-6033, is there any concerns of doing this?
Attached branch-2 patch (007).
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 17s | Docker mode activated. |
| Prechecks | |||
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| branch-2 Compile Tests | |||
| 0 | mvndep | 1m 11s | Maven dependency ordering for branch |
| +1 | mvninstall | 6m 49s | branch-2 passed |
| +1 | compile | 5m 51s | branch-2 passed with JDK v1.8.0_131 |
| +1 | compile | 6m 41s | branch-2 passed with JDK v1.7.0_131 |
| +1 | mvnsite | 10m 8s | branch-2 passed |
| +1 | javadoc | 4m 59s | branch-2 passed with JDK v1.8.0_131 |
| +1 | javadoc | 5m 55s | branch-2 passed with JDK v1.7.0_131 |
| Patch Compile Tests | |||
| 0 | mvndep | 0m 15s | Maven dependency ordering for patch |
| -1 | mvninstall | 0m 10s | hadoop-mapreduce-client-nativetask in the patch failed. |
| +1 | compile | 6m 7s | the patch passed with JDK v1.8.0_131 |
| +1 | cc | 6m 7s | the patch passed |
| +1 | javac | 6m 7s | the patch passed |
| +1 | compile | 7m 1s | the patch passed with JDK v1.7.0_131 |
| +1 | cc | 7m 1s | the patch passed |
| +1 | javac | 7m 1s | the patch passed |
| +1 | mvnsite | 9m 45s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 | javadoc | 4m 25s | the patch passed with JDK v1.8.0_131 |
| +1 | javadoc | 5m 38s | the patch passed with JDK v1.7.0_131 |
| Other Tests | |||
| -1 | unit | 87m 57s | root in the patch failed with JDK v1.7.0_131. |
| +1 | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| 265m 23s |
| Reason | Tests |
|---|---|
| JDK v1.8.0_131 Failed junit tests | hadoop.yarn.server.nodemanager.webapp.TestNMWebServer |
| JDK v1.8.0_131 Timed out junit tests | org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure |
| JDK v1.7.0_131 Failed junit tests | hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain |
| hadoop.yarn.server.nodemanager.webapp.TestNMWebServer |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:5e40efe |
| JIRA Issue | HADOOP-13835 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12881066/HADOOP-13835.branch-2.007.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml cc |
| uname | Linux c21f3133ec85 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | branch-2 / 8b75900 |
| Default Java | 1.7.0_131 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 |
| mvninstall | https://builds.apache.org/job/PreCommit-HADOOP-Build/12996/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt |
| unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/12996/artifact/patchprocess/patch-unit-root-jdk1.7.0_131.txt |
| JDK v1.7.0_131 Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12996/testReport/ |
| modules | C: hadoop-common-project/hadoop-common . hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: . |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12996/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Thanks Wangda Tan. I'm +1 for backporting this to branch-2. Two comments:
- We don't need to add pom.xml or CMakeLists.txt in hadoop-mapreduce-client-nativetask module.
- re2j is added to LICENSE.txt in the patch, but I'm thinking re2j is not related.
Wangda Tan - did you get a chance to do this? Can you backport to branch-2.8 as well? Thanks!
I may not have chance to do this at least in the next two weeks. Please feel free to take over if you have bandwidth. When I get chance to do this, I will try to backport branch-2.8 as well.
Patch attached. It does 2 things -
1) Moves the gtest directory from hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/ to hadoop-common-project/hadoop-common/src/main/native
2) Update the CMakeLists.txt in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src to point to the new location of gtest.