Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As per my comment here GlobalStorageStatistics.INSTANCE.reset() can be used at FileSystem#clearStatistics()

      1. HADOOP-13822.patch
        0.8 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Will review,If I get chance( i mean,enough time).thanks for explanation.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Will review,If I get chance( i mean,enough time).thanks for explanation.
        Hide
        liuml07 Mingliang Liu added a comment - - edited

        That one is a bit tricky.

        The parent JIRA itself is a patch and has committed. Then we had a few follow-on tasks. At that time I thought it may be resolved in weeks. After I realized the tasks have been pending review for a while, I regret not having created a logical umbrella JIRA.

        Let's do this: we don't re-open the parent JIRA as the patch has been committed and backported to branch-2 branch. Re-opening that will be confusing. Instead, let's get that code in. I need reviews and ping-ed Jitendra and Colin more than once; it seems they are busy in other projects and not actively reviewing the left 2 or 3 patches. Can I ask you here review/commit that patches?

        1. HADOOP-13435 Add a new thread-local mechanism for aggregating file system storage stats. This includes the new ThreadLocalStorageStatistics class and its test and changes in FileSystemStorageStatistics that use it. After that, the FileSystemStorageStatistics can live without the deprecated FileSystem$Statistics implementation.
        2. HADOOP-13032 Make FileSystems, FileContext, MapReduce and rack-aware read stats use the new FileSystemStorageStatistics interface. And remove the FileSystem$Statistics and update all its usages

        Social coding is interesting. Thank you,

        Show
        liuml07 Mingliang Liu added a comment - - edited That one is a bit tricky. The parent JIRA itself is a patch and has committed. Then we had a few follow-on tasks. At that time I thought it may be resolved in weeks. After I realized the tasks have been pending review for a while, I regret not having created a logical umbrella JIRA. Let's do this: we don't re-open the parent JIRA as the patch has been committed and backported to branch-2 branch. Re-opening that will be confusing. Instead, let's get that code in. I need reviews and ping-ed Jitendra and Colin more than once; it seems they are busy in other projects and not actively reviewing the left 2 or 3 patches. Can I ask you here review/commit that patches? HADOOP-13435 Add a new thread-local mechanism for aggregating file system storage stats. This includes the new ThreadLocalStorageStatistics class and its test and changes in FileSystemStorageStatistics that use it. After that, the FileSystemStorageStatistics can live without the deprecated FileSystem$Statistics implementation. HADOOP-13032 Make FileSystems, FileContext, MapReduce and rack-aware read stats use the new FileSystemStorageStatistics interface. And remove the FileSystem$Statistics and update all its usages Social coding is interesting. Thank you,
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Mingliang Liu thanks for review and commit.
        There are some subtasks are open under HADOOP-13065,but parent jira is resolved..I think,it should be open till all the subtasks closed right..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Mingliang Liu thanks for review and commit. There are some subtasks are open under HADOOP-13065 ,but parent jira is resolved..I think,it should be open till all the subtasks closed right..?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10852 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10852/)
        HADOOP-13822. Use GlobalStorageStatistics.INSTANCE.reset() at (liuml07: rev aab9737a058c0bdeeb17c173e530b7e571315a56)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10852 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10852/ ) HADOOP-13822 . Use GlobalStorageStatistics.INSTANCE.reset() at (liuml07: rev aab9737a058c0bdeeb17c173e530b7e571315a56) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        Hide
        liuml07 Mingliang Liu added a comment -

        +1

        Committed to trunk through branch-2.8 branches. Thanks for reporting and providing a patch, Brahma Reddy Battula.

        Show
        liuml07 Mingliang Liu added a comment - +1 Committed to trunk through branch-2.8 branches. Thanks for reporting and providing a patch, Brahma Reddy Battula .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 59s trunk passed
        +1 compile 11m 27s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 25s trunk passed
        +1 javadoc 0m 47s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 10m 5s the patch passed
        +1 javac 10m 5s the patch passed
        +1 checkstyle 0m 31s the patch passed
        +1 mvnsite 1m 8s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 9m 8s hadoop-common in the patch passed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        51m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13822
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839297/HADOOP-13822.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8e2861a2c7e0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 04a024b
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11083/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11083/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 59s trunk passed +1 compile 11m 27s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 10m 5s the patch passed +1 javac 10m 5s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 9m 8s hadoop-common in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 51m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13822 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839297/HADOOP-13822.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8e2861a2c7e0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 04a024b Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11083/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11083/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch..Mingliang Liu can you review..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch.. Mingliang Liu can you review..?

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development