Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13810

Add a test to verify that Configuration handles &-encoded characters

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.3
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None

      Description

      Add a quick test to verify that escaped/encoded chars like ' are being handled correctly. This is of course something all XML parsers need to do, but it's always good to make sure.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user steveloughran opened a pull request:

          https://github.com/apache/hadoop/pull/158

          HADOOP-13810

          Add a test to verify that Configuration handles &-encoded characters

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/steveloughran/hadoop stevel/HADOOP-13810-configuration-encoded-xml

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/158.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #158


          commit 7efa05154e28c7a67f59847acd4aa0c1dbd783e1
          Author: Steve Loughran <stevel@apache.org>
          Date: 2016-11-11T17:32:34Z

          HADOOP-13810 test for XML escaped characters

          Change-Id: Id88f837d3ecb97d1b5a55e0ec813e62fbe318c33


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user steveloughran opened a pull request: https://github.com/apache/hadoop/pull/158 HADOOP-13810 Add a test to verify that Configuration handles &-encoded characters You can merge this pull request into a Git repository by running: $ git pull https://github.com/steveloughran/hadoop stevel/ HADOOP-13810 -configuration-encoded-xml Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 7efa05154e28c7a67f59847acd4aa0c1dbd783e1 Author: Steve Loughran <stevel@apache.org> Date: 2016-11-11T17:32:34Z HADOOP-13810 test for XML escaped characters Change-Id: Id88f837d3ecb97d1b5a55e0ec813e62fbe318c33
          Hide
          liuml07 Mingliang Liu added a comment -

          +1 pending on Jenkins. Will this PR trigger Jenkins?

          Show
          liuml07 Mingliang Liu added a comment - +1 pending on Jenkins. Will this PR trigger Jenkins?
          Hide
          liuml07 Mingliang Liu added a comment -

          I manually triggered a build request on https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-HDFS-Build/17562

          I asked around, and this PR with "Patch Available" should have triggered the Jenkins. Not luck last time.

          Show
          liuml07 Mingliang Liu added a comment - I manually triggered a build request on https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-HDFS-Build/17562 I asked around, and this PR with "Patch Available" should have triggered the Jenkins. Not luck last time.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 46s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 55s branch-2 passed
          +1 compile 6m 0s branch-2 passed with JDK v1.8.0_111
          +1 compile 6m 48s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 0m 28s branch-2 passed
          +1 mvnsite 1m 0s branch-2 passed
          +1 mvneclipse 0m 16s branch-2 passed
          +1 findbugs 1m 44s branch-2 passed
          +1 javadoc 0m 47s branch-2 passed with JDK v1.8.0_111
          +1 javadoc 0m 58s branch-2 passed with JDK v1.7.0_111
          +1 mvninstall 0m 42s the patch passed
          +1 compile 5m 49s the patch passed with JDK v1.8.0_111
          +1 javac 5m 49s the patch passed
          +1 compile 6m 45s the patch passed with JDK v1.7.0_111
          +1 javac 6m 45s the patch passed
          +1 checkstyle 0m 26s the patch passed
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 1s the patch passed
          +1 javadoc 0m 47s the patch passed with JDK v1.8.0_111
          +1 javadoc 0m 59s the patch passed with JDK v1.7.0_111
          +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          76m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HADOOP-13810
          GITHUB PR https://github.com/apache/hadoop/pull/158
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ee216c14e69c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 818915a
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11063/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11063/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 13m 46s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 55s branch-2 passed +1 compile 6m 0s branch-2 passed with JDK v1.8.0_111 +1 compile 6m 48s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 1m 0s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed +1 findbugs 1m 44s branch-2 passed +1 javadoc 0m 47s branch-2 passed with JDK v1.8.0_111 +1 javadoc 0m 58s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 42s the patch passed +1 compile 5m 49s the patch passed with JDK v1.8.0_111 +1 javac 5m 49s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_111 +1 javac 6m 45s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 1s the patch passed +1 javadoc 0m 47s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 59s the patch passed with JDK v1.7.0_111 +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 76m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-13810 GITHUB PR https://github.com/apache/hadoop/pull/158 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ee216c14e69c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 818915a Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11063/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11063/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          +1 Will commit in one second.

          Show
          liuml07 Mingliang Liu added a comment - +1 Will commit in one second.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/hadoop/pull/158

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/hadoop/pull/158
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10834 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10834/)
          HADOOP-13810. Add a test to verify that Configuration handles &-encoded (liuml07: rev 04014c4c739bb4e3bc3fdf9299abc0f47521e8fd)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10834 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10834/ ) HADOOP-13810 . Add a test to verify that Configuration handles &-encoded (liuml07: rev 04014c4c739bb4e3bc3fdf9299abc0f47521e8fd) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed to trunk through branch-2.8 branches. Thanks for your contribution, Steve Loughran.

          Show
          liuml07 Mingliang Liu added a comment - Committed to trunk through branch-2.8 branches. Thanks for your contribution, Steve Loughran .

            People

            • Assignee:
              stevel@apache.org Steve Loughran
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development