Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13800

Remove unused HADOOP_AUDIT_LOGGER from hadoop-env.sh

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: scripts
    • Labels:

      Description

      The following example is misleading. The environment variable does not effect on HDFS audit logger.

      hadoop-env.sh
      # Default log level for file system audit messages.
      # Generally, this is specifically set in the namenode-specific
      # options line.
      # Java property: hdfs.audit.logger
      # export HADOOP_AUDIT_LOGGER=INFO,NullAppender
      

        Activity

        Hide
        aw Allen Wittenauer added a comment -

        It should be HDFS_AUDIT_LOGGER, not HADOOP_AUDIT_LOGGER.

        Show
        aw Allen Wittenauer added a comment - It should be HDFS_AUDIT_LOGGER, not HADOOP_AUDIT_LOGGER.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Yes. It should be HDFS_AUDIT_LOGGER. There is already an example in hadoop-env.sh:

        hadoop-env.sh
        # Default log level and output location for file system related change
        # messages. For non-namenode daemons, the Java property must be set in
        # the appropriate _OPTS if one wants something other than INFO,NullAppender
        # Java property: hdfs.audit.logger
        # export HDFS_AUDIT_LOGGER=INFO,NullAppender
        

        so HADOOP_AUDIT_LOGGER can simply be removed.

        Show
        ajisakaa Akira Ajisaka added a comment - Yes. It should be HDFS_AUDIT_LOGGER. There is already an example in hadoop-env.sh: hadoop-env.sh # Default log level and output location for file system related change # messages. For non-namenode daemons, the Java property must be set in # the appropriate _OPTS if one wants something other than INFO,NullAppender # Java property: hdfs.audit.logger # export HDFS_AUDIT_LOGGER=INFO,NullAppender so HADOOP_AUDIT_LOGGER can simply be removed.
        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a simple patch to have a quick fix. Thanks Akira Ajisaka for reporting.

        Show
        linyiqun Yiqun Lin added a comment - Attach a simple patch to have a quick fix. Thanks Akira Ajisaka for reporting.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 48s trunk passed
        +1 mvnsite 1m 0s trunk passed
        +1 mvnsite 0m 53s the patch passed
        +1 shellcheck 0m 12s There were no new shellcheck issues.
        +1 shelldocs 0m 9s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 1m 58s hadoop-common in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        12m 0s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e809691
        JIRA Issue HADOOP-13800
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838121/HADOOP-13800.001.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux d3c0393ec630 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ed0beba
        shellcheck v0.4.4
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11041/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11041/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 48s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvnsite 0m 53s the patch passed +1 shellcheck 0m 12s There were no new shellcheck issues. +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 1m 58s hadoop-common in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 12m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13800 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838121/HADOOP-13800.001.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux d3c0393ec630 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ed0beba shellcheck v0.4.4 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11041/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11041/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk. Thanks Yiqun Lin for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Yiqun Lin for the contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10799 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10799/)
        HADOOP-13800. Remove unused HADOOP_AUDIT_LOGGER from hadoop-env.sh. (aajisaka: rev c074880096bd41470a3358f6002f30b57a725375)

        • (edit) hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10799 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10799/ ) HADOOP-13800 . Remove unused HADOOP_AUDIT_LOGGER from hadoop-env.sh. (aajisaka: rev c074880096bd41470a3358f6002f30b57a725375) (edit) hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development