Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None

      Issue Links

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        Got stuck at fsdis.read in the following code:

        TestHadoopArchives.java
              while (true) {
                read = fsdis.read(buffer, readIntoBuffer, buffer.length - readIntoBuffer);
                if (read < 0) {
        

        After HADOOP-13017, HarFileSystem#read can return zero. If fsdis.read returns zero, then the code becomes infinite-loop.

        Show
        ajisakaa Akira Ajisaka added a comment - Got stuck at fsdis.read in the following code: TestHadoopArchives.java while ( true ) { read = fsdis.read(buffer, readIntoBuffer, buffer.length - readIntoBuffer); if (read < 0) { After HADOOP-13017 , HarFileSystem#read can return zero. If fsdis.read returns zero, then the code becomes infinite-loop.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Attaching a simple patch.

        Show
        ajisakaa Akira Ajisaka added a comment - Attaching a simple patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 40s trunk passed
        +1 compile 0m 15s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 21s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 0m 21s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 14s the patch passed
        +1 compile 0m 13s the patch passed
        +1 javac 0m 13s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 27s the patch passed
        +1 javadoc 0m 9s the patch passed
        +1 unit 0m 46s hadoop-archives in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        12m 36s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e809691
        JIRA Issue HADOOP-13798
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837694/HADOOP-13798.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 53134a0a1490 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ca33bdd
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11003/testReport/
        modules C: hadoop-tools/hadoop-archives U: hadoop-tools/hadoop-archives
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11003/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 40s trunk passed +1 compile 0m 15s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 0m 21s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 14s the patch passed +1 compile 0m 13s the patch passed +1 javac 0m 13s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 27s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 0m 46s hadoop-archives in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 12m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13798 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837694/HADOOP-13798.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 53134a0a1490 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ca33bdd Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11003/testReport/ modules C: hadoop-tools/hadoop-archives U: hadoop-tools/hadoop-archives Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11003/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Akira Ajisaka thanks for reporting, Even I noticed this timeout in qbt..

        Nice finding, Patch looks good to me.I think,should wait for commit till Steve Loughran and Masatake Iwasaki looks into this as they worked earlier.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Akira Ajisaka thanks for reporting, Even I noticed this timeout in qbt.. Nice finding, Patch looks good to me.I think,should wait for commit till Steve Loughran and Masatake Iwasaki looks into this as they worked earlier.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1 from me

        Show
        stevel@apache.org Steve Loughran added a comment - +1 from me
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Brahma Reddy Battula and Steve Loughran for your reviews!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Brahma Reddy Battula and Steve Loughran for your reviews!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10780 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10780/)
        HADOOP-13798. TestHadoopArchives times out. (aajisaka: rev b970446b2c59f8897bb2c3a562fa192ed3452db5)

        • (edit) hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10780 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10780/ ) HADOOP-13798 . TestHadoopArchives times out. (aajisaka: rev b970446b2c59f8897bb2c3a562fa192ed3452db5) (edit) hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development