[HADOOP-13749] KMSClientProvider combined with KeyProviderCache can result in wrong UGI being used

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha2
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Xiaoyu Yao
• Reporter: Sergey Shelukhin
• Created: 12/Aug/16 00:56
• Updated: 13/Jan/17 20:17
• Resolved: 23/Oct/16 18:12

Description

ClientContext::get gets the context from CACHE via a config setting based name, then KeyProviderCache stored in ClientContext gets the key provider cached by URI from the configuration, too. These would return the same KeyProvider regardless of current UGI.
KMSClientProvider caches the UGI (actualUgi) in ctor; that means in particular that all the users of DFS with KMSClientProvider in a process will get the KMS token (along with other credentials) of the first user, via the above cache.

Either KMSClientProvider shouldn't store the UGI, or one of the caches should be UGI-aware, like the FS object cache.

Side note: the comment in createConnection that purports to handle the different UGI doesn't seem to cover what it says it covers. In our case, we have two unrelated UGIs with no auth (createRemoteUser) with bunch of tokens, including a KMS token, added.

Issue Links

• breaks: HADOOP-13748 TestKMS fails in testProxyUserSimple and testDelegationTokensOpsSimple
• duplicates: HADOOP-13381 KMS clients should use KMS Delegation Tokens from current UGI.
• is required by: HADOOP-13988 KMSClientProvider does not work with WebHDFS and Apache Knox w/ProxyUser
• relates to: HADOOP-13748 TestKMS fails in testProxyUserSimple and testDelegationTokensOpsSimple