Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13742

Expose "NumOpenConnectionsPerUser" as a metric

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      To track user level connections( How many connections for each user) in busy cluster where so many connections to server.

      1. HADOOP-13742.patch
        5 kB
        Brahma Reddy Battula
      2. HADOOP-13742-002.patch
        8 kB
        Brahma Reddy Battula
      3. HADOOP-13742-003.patch
        9 kB
        Brahma Reddy Battula
      4. HADOOP-13742-004.patch
        9 kB
        Brahma Reddy Battula
      5. HADOOP-13742-005.patch
        8 kB
        Brahma Reddy Battula
      6. HADOOP-13742-006.patch
        9 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Uploaded initial patch..Kindly Review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Uploaded initial patch..Kindly Review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 37s trunk passed
        +1 compile 6m 48s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 43s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 6m 49s the patch passed
        +1 javac 6m 49s the patch passed
        -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 3 new + 223 unchanged - 0 fixed = 226 total (was 223)
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 29s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
        +1 javadoc 0m 40s the patch passed
        +1 unit 8m 5s hadoop-common in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        38m 15s



        Reason Tests
        FindBugs module:hadoop-common-project/hadoop-common
          Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) At Server.java:org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) At Server.java:[line 3226]
          Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) At Server.java:org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) At Server.java:[line 3214]



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13742
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834390/HADOOP-13742.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b1a9ddc08266 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 73504b1
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10841/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10841/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10841/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10841/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 37s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 6m 49s the patch passed +1 javac 6m 49s the patch passed -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 3 new + 223 unchanged - 0 fixed = 226 total (was 223) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 29s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 40s the patch passed +1 unit 8m 5s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 38m 15s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) At Server.java:org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) At Server.java: [line 3226]   Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) At Server.java:org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) At Server.java: [line 3214] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13742 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834390/HADOOP-13742.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b1a9ddc08266 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 73504b1 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10841/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10841/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10841/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10841/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        updating patch with testcases and findbug fix. Kindly Review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - updating patch with testcases and findbug fix. Kindly Review.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 9s trunk passed
        +1 compile 7m 22s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 51s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 44s the patch passed
        +1 compile 8m 56s the patch passed
        +1 javac 8m 56s the patch passed
        -0 checkstyle 0m 31s hadoop-common-project/hadoop-common: The patch generated 3 new + 288 unchanged - 0 fixed = 291 total (was 288)
        +1 mvnsite 1m 5s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 51s the patch passed
        +1 javadoc 0m 48s the patch passed
        +1 unit 9m 47s hadoop-common in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        44m 59s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13742
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835117/HADOOP-13742-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2ba24c0d58d5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dbd2057
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10889/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10889/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10889/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 9s trunk passed +1 compile 7m 22s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 8m 56s the patch passed +1 javac 8m 56s the patch passed -0 checkstyle 0m 31s hadoop-common-project/hadoop-common: The patch generated 3 new + 288 unchanged - 0 fixed = 291 total (was 288) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 48s the patch passed +1 unit 9m 47s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 44m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13742 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835117/HADOOP-13742-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2ba24c0d58d5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbd2057 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10889/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10889/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10889/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Kihwal Lee could please review this..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Kihwal Lee could please review this..?
        Hide
        kihwal Kihwal Lee added a comment -

        At a first glance, the following seems racy. Since processConnectionContext() is done by the reader threads, unless you configure with only one reader thread, one can step over another one adding a new count for the same user. Also the decrement method could remove the hash map entry after this method verified it not being null. The update will be lost in this case too.

            void incrUserConnections(String user) {
              AtomicInteger count = userVsConnectionsMap.get(user);
              if (count == null) {
                count = new AtomicInteger(1);
                userVsConnectionsMap.put(user, count);
              } else {
                count.getAndIncrement();
              }
            }
        

        Slapping a big synchronization will make it safe, but then that's not desirable for the performance. Probably there can be a fine-grained way.

        Show
        kihwal Kihwal Lee added a comment - At a first glance, the following seems racy. Since processConnectionContext() is done by the reader threads, unless you configure with only one reader thread, one can step over another one adding a new count for the same user. Also the decrement method could remove the hash map entry after this method verified it not being null. The update will be lost in this case too. void incrUserConnections( String user) { AtomicInteger count = userVsConnectionsMap.get(user); if (count == null ) { count = new AtomicInteger(1); userVsConnectionsMap.put(user, count); } else { count.getAndIncrement(); } } Slapping a big synchronization will make it safe, but then that's not desirable for the performance. Probably there can be a fine-grained way.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Kihwal Lee thanks for taking a look into this issue. thinking like following, let me know your opinion.

        void incrUserConnections(String user) {
              AtomicInteger count = userVsConnectionsMap.get(user);
              if (count == null) {
                count = new AtomicInteger(1);
                count = userVsConnectionsMap.putIfAbsent(user, count);
                if (count != null) {
                  count.getAndIncrement();
                }
              } else {
                count.getAndIncrement();
              }
            }
        
         void decrUserConnections(String user) {
              AtomicInteger count = userVsConnectionsMap.get(user);
              if (count == null) {
                return;
              } else {
                if (count.decrementAndGet() == 0) {
                  userVsConnectionsMap.remove(user);
                }
              }
            }
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - Kihwal Lee thanks for taking a look into this issue. thinking like following, let me know your opinion. void incrUserConnections( String user) { AtomicInteger count = userVsConnectionsMap.get(user); if (count == null ) { count = new AtomicInteger(1); count = userVsConnectionsMap.putIfAbsent(user, count); if (count != null ) { count.getAndIncrement(); } } else { count.getAndIncrement(); } } void decrUserConnections( String user) { AtomicInteger count = userVsConnectionsMap.get(user); if (count == null ) { return ; } else { if (count.decrementAndGet() == 0) { userVsConnectionsMap.remove(user); } } }
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Kihwal Lee can you please check once..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Kihwal Lee can you please check once..?
        Hide
        kihwal Kihwal Lee added a comment -

        There still is a race.

        Show
        kihwal Kihwal Lee added a comment - There still is a race.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploading the patch to address the race .

        one can step over another one adding a new count for the same user.

        This can't happen now, since AtomicInteger is used.

        Also the decrement method could remove the hash map entry after this method verified it not being null.

        Now,Increment will recheck again if the count was decremented.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploading the patch to address the race . one can step over another one adding a new count for the same user. This can't happen now, since AtomicInteger is used. Also the decrement method could remove the hash map entry after this method verified it not being null. Now,Increment will recheck again if the count was decremented.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 34s trunk passed
        +1 compile 6m 57s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 16s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 7m 15s the patch passed
        +1 javac 7m 15s the patch passed
        -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 4 new + 288 unchanged - 0 fixed = 292 total (was 288)
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 31s hadoop-common-project/hadoop-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
        +1 javadoc 0m 42s the patch passed
        +1 unit 7m 22s hadoop-common in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        39m 10s



        Reason Tests
        FindBugs module:hadoop-common-project/hadoop-common
          Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.ipc.Server$ConnectionManager.addCount(String, AtomicInteger) At Server.java:org.apache.hadoop.ipc.Server$ConnectionManager.addCount(String, AtomicInteger) At Server.java:[line 3227]
          Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) At Server.java:org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) At Server.java:[line 3242]
          Load of known null value in org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) At Server.java:in org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) At Server.java:[line 3216]



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13742
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836888/HADOOP-13742-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ecfd2a823504 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 352cbaa
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10976/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10976/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10976/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10976/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 34s trunk passed +1 compile 6m 57s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 16s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 7m 15s the patch passed +1 javac 7m 15s the patch passed -0 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 4 new + 288 unchanged - 0 fixed = 292 total (was 288) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 31s hadoop-common-project/hadoop-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) +1 javadoc 0m 42s the patch passed +1 unit 7m 22s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 39m 10s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.ipc.Server$ConnectionManager.addCount(String, AtomicInteger) At Server.java:org.apache.hadoop.ipc.Server$ConnectionManager.addCount(String, AtomicInteger) At Server.java: [line 3227]   Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) At Server.java:org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) At Server.java: [line 3242]   Load of known null value in org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) At Server.java:in org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) At Server.java: [line 3216] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13742 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836888/HADOOP-13742-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ecfd2a823504 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 352cbaa Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10976/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10976/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10976/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10976/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch to fix the check-style and findbugs.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch to fix the check-style and findbugs.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 8m 38s trunk passed
        +1 compile 8m 25s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 39s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 44s the patch passed
        +1 compile 8m 21s the patch passed
        +1 javac 8m 21s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 1m 2s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 44s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 8m 23s hadoop-common in the patch passed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        45m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13742
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837061/HADOOP-13742-004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7b62a6824457 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 69dd5fa
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10988/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10988/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 38s trunk passed +1 compile 8m 25s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 8m 21s the patch passed +1 javac 8m 21s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 8m 23s hadoop-common in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 45m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13742 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837061/HADOOP-13742-004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7b62a6824457 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 69dd5fa Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10988/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10988/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Kihwal Lee can you please check latest patch.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Kihwal Lee can you please check latest patch.
        Hide
        kihwal Kihwal Lee added a comment -

        Sorry for the delay. I will review it today.

        Show
        kihwal Kihwal Lee added a comment - Sorry for the delay. I will review it today.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        hmm..Nope.. thanks.

        Show
        brahmareddy Brahma Reddy Battula added a comment - hmm..Nope.. thanks.
        Hide
        kihwal Kihwal Lee added a comment -

        First of all, the use of "Vs" is probably not the best choice. "Vs" is for two comparable things.

        I am wondering whether introducing a separate metrics class is better. (Something similar to RpcDetailedMetrics) For typical metrics, a counter is simply incremented and the diff shows the rate. If users are only interested in instantaneous counts and do not care at all about cumulative counts, the approach in the patch might be okay. But I am thinking cumulative values are useful too.

        If we are to proceed with the proposed approach, I suggest simply synchronize on the lock object inside incrUserConnections() and decrUserConnections() and lose the private methods. Then no need to have AtomicInteger. The ideal way will be range-locking the map, but I don't know whether there is any known good implementation of it. In any case, the number of rpc reader threads is typically small, so this level of synchronization/monitor lock should be okay.

        Show
        kihwal Kihwal Lee added a comment - First of all, the use of "Vs" is probably not the best choice. "Vs" is for two comparable things. I am wondering whether introducing a separate metrics class is better. (Something similar to RpcDetailedMetrics ) For typical metrics, a counter is simply incremented and the diff shows the rate. If users are only interested in instantaneous counts and do not care at all about cumulative counts, the approach in the patch might be okay. But I am thinking cumulative values are useful too. If we are to proceed with the proposed approach, I suggest simply synchronize on the lock object inside incrUserConnections() and decrUserConnections() and lose the private methods. Then no need to have AtomicInteger . The ideal way will be range-locking the map, but I don't know whether there is any known good implementation of it. In any case, the number of rpc reader threads is typically small, so this level of synchronization/monitor lock should be okay.
        Hide
        vinayrpet Vinayakumar B added a comment -

        First of all, the use of "Vs" is probably not the best choice. "Vs" is for two comparable things.

        I think "userToConnectionsMap" might be better.

        I am wondering whether introducing a separate metrics class is better. (Something similar to RpcDetailedMetrics) For typical metrics, a counter is simply incremented and the diff shows the rate. If users are only interested in instantaneous counts and do not care at all about cumulative counts, the approach in the patch might be okay. But I am thinking cumulative values are useful too.

        That's a good idea and may be required to for detailed analysis about each user's usage. In simple terms there could be separate instances of RpcDetailedMetrics for each user, Just an Idea. I feel this could be done in a follow-up jira and detailed discussions could be made.

        If we are to proceed with the proposed approach, I suggest simply synchronize on the lock object inside incrUserConnections() and decrUserConnections() and lose the private methods. Then no need to have AtomicInteger. The ideal way will be range-locking the map, but I don't know whether there is any known good implementation of it. In any case, the number of rpc reader threads is typically small, so this level of synchronization/monitor lock should be okay.

        In this jira only simple count of connections can be exposed as a metric, as title says.
        Brahma Reddy Battula, please update the patch with simple synchronization, as suggested by Kihwal Lee.

        Show
        vinayrpet Vinayakumar B added a comment - First of all, the use of "Vs" is probably not the best choice. "Vs" is for two comparable things. I think "userToConnectionsMap" might be better. I am wondering whether introducing a separate metrics class is better. (Something similar to RpcDetailedMetrics) For typical metrics, a counter is simply incremented and the diff shows the rate. If users are only interested in instantaneous counts and do not care at all about cumulative counts, the approach in the patch might be okay. But I am thinking cumulative values are useful too. That's a good idea and may be required to for detailed analysis about each user's usage. In simple terms there could be separate instances of RpcDetailedMetrics for each user, Just an Idea. I feel this could be done in a follow-up jira and detailed discussions could be made. If we are to proceed with the proposed approach, I suggest simply synchronize on the lock object inside incrUserConnections() and decrUserConnections() and lose the private methods. Then no need to have AtomicInteger. The ideal way will be range-locking the map, but I don't know whether there is any known good implementation of it. In any case, the number of rpc reader threads is typically small, so this level of synchronization/monitor lock should be okay. In this jira only simple count of connections can be exposed as a metric, as title says. Brahma Reddy Battula , please update the patch with simple synchronization, as suggested by Kihwal Lee .
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Thanks Kihwal Lee and Vinayakumar B for reviews..

        Uploaded the patch with simple synchronization mentioned by kihwal.
        I am ok to handle in different jira for separate metrics class to detailed analysis about each user's usage.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Thanks Kihwal Lee and Vinayakumar B for reviews.. Uploaded the patch with simple synchronization mentioned by kihwal. I am ok to handle in different jira for separate metrics class to detailed analysis about each user's usage.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 50s trunk passed
        +1 compile 9m 28s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 25s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 9m 9s the patch passed
        +1 javac 9m 9s the patch passed
        -0 checkstyle 0m 33s hadoop-common-project/hadoop-common: The patch generated 2 new + 288 unchanged - 0 fixed = 290 total (was 288)
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 46s the patch passed
        +1 unit 8m 19s hadoop-common in the patch passed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        45m 13s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13742
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839134/HADOOP-13742-005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 38725497dcc4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 61c0bed
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11076/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11076/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11076/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 50s trunk passed +1 compile 9m 28s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 9s the patch passed +1 javac 9m 9s the patch passed -0 checkstyle 0m 33s hadoop-common-project/hadoop-common: The patch generated 2 new + 288 unchanged - 0 fixed = 290 total (was 288) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 8m 19s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 45m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13742 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839134/HADOOP-13742-005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 38725497dcc4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 61c0bed Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11076/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11076/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11076/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        That's a good idea and may be required to for detailed analysis about each user's usage. In simple terms there could be separate instances of RpcDetailedMetrics for each user, Just an Idea. I feel this could be done in a follow-up jira and detailed discussions could be made.

        I didn't mean to suggest per-user RpcDetailedMetrics. I meant per-user connection metrics with cumulative counts. But the instantaneous numbers are fine as well.

        One minor thing in the latest patch is the new code in the test. server needs to be final, if you want this patch to go beyond trunk.

        Show
        kihwal Kihwal Lee added a comment - That's a good idea and may be required to for detailed analysis about each user's usage. In simple terms there could be separate instances of RpcDetailedMetrics for each user, Just an Idea. I feel this could be done in a follow-up jira and detailed discussions could be made. I didn't mean to suggest per-user RpcDetailedMetrics. I meant per-user connection metrics with cumulative counts. But the instantaneous numbers are fine as well. One minor thing in the latest patch is the new code in the test. server needs to be final , if you want this patch to go beyond trunk.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        One minor thing in the latest patch is the new code in the test. server needs to be final, if you want this patch to go beyond trunk.

        Yes,,Thought of updating once after final review..Uploaded for same..

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited One minor thing in the latest patch is the new code in the test. server needs to be final, if you want this patch to go beyond trunk. Yes,,Thought of updating once after final review..Uploaded for same..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 14m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        -1 mvninstall 0m 8s root in trunk failed.
        -1 compile 4m 13s root in trunk failed with JDK v1.8.0_111.
        -1 compile 0m 10s root in trunk failed with JDK v1.7.0_111.
        +1 checkstyle 0m 28s trunk passed
        -1 mvnsite 0m 15s hadoop-common in trunk failed.
        -1 mvneclipse 0m 10s hadoop-common in trunk failed.
        -1 findbugs 0m 10s hadoop-common in trunk failed.
        +1 javadoc 0m 41s trunk passed with JDK v1.8.0_111
        -1 javadoc 0m 10s hadoop-common in trunk failed with JDK v1.7.0_111.
        -1 mvninstall 0m 9s hadoop-common in the patch failed.
        -1 compile 4m 21s root in the patch failed with JDK v1.8.0_111.
        -1 javac 4m 21s root in the patch failed with JDK v1.8.0_111.
        -1 compile 0m 10s root in the patch failed with JDK v1.7.0_111.
        -1 javac 0m 10s root in the patch failed with JDK v1.7.0_111.
        -0 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 2 new + 288 unchanged - 0 fixed = 290 total (was 288)
        -1 mvnsite 0m 12s hadoop-common in the patch failed.
        -1 mvneclipse 0m 10s hadoop-common in the patch failed.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 10s hadoop-common in the patch failed.
        +1 javadoc 0m 39s the patch passed with JDK v1.8.0_111
        -1 javadoc 0m 10s hadoop-common in the patch failed with JDK v1.7.0_111.
        -1 unit 0m 11s hadoop-common in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        37m 31s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HADOOP-13742
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839386/HADOOP-13742-006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 93875e462166 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b2d4b7b
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-mvninstall-root.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-compile-root-jdk1.8.0_111.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-compile-root-jdk1.7.0_111.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt
        mvneclipse https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-mvneclipse-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-compile-root-jdk1.8.0_111.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-compile-root-jdk1.8.0_111.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
        mvneclipse https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-mvneclipse-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 14m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. -1 mvninstall 0m 8s root in trunk failed. -1 compile 4m 13s root in trunk failed with JDK v1.8.0_111. -1 compile 0m 10s root in trunk failed with JDK v1.7.0_111. +1 checkstyle 0m 28s trunk passed -1 mvnsite 0m 15s hadoop-common in trunk failed. -1 mvneclipse 0m 10s hadoop-common in trunk failed. -1 findbugs 0m 10s hadoop-common in trunk failed. +1 javadoc 0m 41s trunk passed with JDK v1.8.0_111 -1 javadoc 0m 10s hadoop-common in trunk failed with JDK v1.7.0_111. -1 mvninstall 0m 9s hadoop-common in the patch failed. -1 compile 4m 21s root in the patch failed with JDK v1.8.0_111. -1 javac 4m 21s root in the patch failed with JDK v1.8.0_111. -1 compile 0m 10s root in the patch failed with JDK v1.7.0_111. -1 javac 0m 10s root in the patch failed with JDK v1.7.0_111. -0 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 2 new + 288 unchanged - 0 fixed = 290 total (was 288) -1 mvnsite 0m 12s hadoop-common in the patch failed. -1 mvneclipse 0m 10s hadoop-common in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 10s hadoop-common in the patch failed. +1 javadoc 0m 39s the patch passed with JDK v1.8.0_111 -1 javadoc 0m 10s hadoop-common in the patch failed with JDK v1.7.0_111. -1 unit 0m 11s hadoop-common in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 37m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-13742 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839386/HADOOP-13742-006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 93875e462166 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b2d4b7b Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-compile-root-jdk1.8.0_111.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-compile-root-jdk1.7.0_111.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt mvneclipse https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-mvneclipse-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-compile-root-jdk1.8.0_111.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-compile-root-jdk1.8.0_111.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-compile-root-jdk1.7.0_111.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt mvneclipse https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-mvneclipse-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11089/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 8m 43s trunk passed
        +1 compile 11m 25s trunk passed
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 1m 13s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 40s trunk passed
        +1 javadoc 0m 49s trunk passed
        +1 mvninstall 0m 41s the patch passed
        +1 compile 10m 50s the patch passed
        +1 javac 10m 50s the patch passed
        -0 checkstyle 0m 34s hadoop-common-project/hadoop-common: The patch generated 2 new + 288 unchanged - 0 fixed = 290 total (was 288)
        +1 mvnsite 1m 7s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 9m 4s hadoop-common in the patch passed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        52m 17s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13742
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839386/HADOOP-13742-006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4134611efa8f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b2d4b7b
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11090/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11090/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11090/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 43s trunk passed +1 compile 11m 25s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 49s trunk passed +1 mvninstall 0m 41s the patch passed +1 compile 10m 50s the patch passed +1 javac 10m 50s the patch passed -0 checkstyle 0m 34s hadoop-common-project/hadoop-common: The patch generated 2 new + 288 unchanged - 0 fixed = 290 total (was 288) +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 9m 4s hadoop-common in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 52m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13742 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839386/HADOOP-13742-006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4134611efa8f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b2d4b7b Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11090/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11090/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11090/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        +1

        Show
        kihwal Kihwal Lee added a comment - +1
        Hide
        kihwal Kihwal Lee added a comment -

        I've committed it to trunk through branch-2.8. Thanks for working on this, Brahma.

        Show
        kihwal Kihwal Lee added a comment - I've committed it to trunk through branch-2.8. Thanks for working on this, Brahma.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10854 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10854/)
        HADOOP-13742. Expose NumOpenConnectionsPerUser as a metric. Brahma Reddy (kihwal: rev bd3735554fa5c3bc064c57ec78f4308430b14b48)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10854 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10854/ ) HADOOP-13742 . Expose NumOpenConnectionsPerUser as a metric. Brahma Reddy (kihwal: rev bd3735554fa5c3bc064c57ec78f4308430b14b48) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Kihwal Lee thanks a lot for your review and commit and thanks to Vinayakumar B for additional review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Kihwal Lee thanks a lot for your review and commit and thanks to Vinayakumar B for additional review..
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Brahma for the work! I think this is a good improvement for branch-2.7 as well. I just did the backport.

        Show
        zhz Zhe Zhang added a comment - Thanks Brahma for the work! I think this is a good improvement for branch-2.7 as well. I just did the backport.

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development