Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2, 2.8.2
    • Component/s: util
    • Labels:
      None

      Description

      The DiskChecker class has a few unused public methods. We can remove them.

      1. HADOOP-13737.02.patch
        10 kB
        Arpit Agarwal
      2. HADOOP-13737.01.patch
        10 kB
        Arpit Agarwal

        Issue Links

          Activity

          Hide
          vinayrpet Vinayakumar B added a comment -

          cherry-picked to branch-2.8.2 and branch-2.8

          Show
          vinayrpet Vinayakumar B added a comment - cherry-picked to branch-2.8.2 and branch-2.8
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thank you for reviewing and committing this Anu Engineer!

          Show
          arpitagarwal Arpit Agarwal added a comment - Thank you for reviewing and committing this Anu Engineer !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10649 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10649/)
          HADOOP-13737. Cleanup DiskChecker interface. Contributed by Arpit (aengineer: rev 262827cf75bf9c48cd95335eb04fd8ff1d64c538)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDiskChecker.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/DiskChecker.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10649 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10649/ ) HADOOP-13737 . Cleanup DiskChecker interface. Contributed by Arpit (aengineer: rev 262827cf75bf9c48cd95335eb04fd8ff1d64c538) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDiskChecker.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/DiskChecker.java
          Hide
          anu Anu Engineer added a comment -

          Arpit Agarwal Thank you for the contribution. I have committed this to trunk and branch-2

          Show
          anu Anu Engineer added a comment - Arpit Agarwal Thank you for the contribution. I have committed this to trunk and branch-2
          Hide
          anu Anu Engineer added a comment - - edited

          +1, LGTM. I will commit this shortly to trunk and branch-2. I had an off-line chat with Arpit Agarwal about the test that was removed in this patch. There are better tests that cover the same scenario in HADOOP-13738

          Show
          anu Anu Engineer added a comment - - edited +1, LGTM. I will commit this shortly to trunk and branch-2. I had an off-line chat with Arpit Agarwal about the test that was removed in this patch. There are better tests that cover the same scenario in HADOOP-13738
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 20s trunk passed
          +1 compile 6m 46s trunk passed
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 15s trunk passed
          +1 javadoc 0m 41s trunk passed
          +1 mvninstall 0m 35s the patch passed
          +1 compile 6m 42s the patch passed
          +1 javac 6m 42s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 24s the patch passed
          +1 javadoc 0m 41s the patch passed
          +1 unit 7m 23s hadoop-common in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          37m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13737
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834292/HADOOP-13737.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 707e6b2a3668 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8650cc8
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10835/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10835/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 20s trunk passed +1 compile 6m 46s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 15s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 6m 42s the patch passed +1 javac 6m 42s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 24s the patch passed +1 javadoc 0m 41s the patch passed +1 unit 7m 23s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 37m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13737 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834292/HADOOP-13737.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 707e6b2a3668 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8650cc8 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10835/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10835/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          v02 patch addresses the checkstyle warning.

          Show
          arpitagarwal Arpit Agarwal added a comment - v02 patch addresses the checkstyle warning.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 46s trunk passed
          +1 compile 6m 46s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 16s trunk passed
          +1 javadoc 0m 41s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 51s the patch passed
          +1 javac 6m 51s the patch passed
          -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 1 new + 32 unchanged - 0 fixed = 33 total (was 32)
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 29s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 7m 29s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          37m 30s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13737
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834278/HADOOP-13737.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5571a249a5cc 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e9c4616
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10834/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10834/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10834/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 46s trunk passed +1 compile 6m 46s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 16s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 51s the patch passed +1 javac 6m 51s the patch passed -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 1 new + 32 unchanged - 0 fixed = 33 total (was 32) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 7m 29s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 37m 30s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13737 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834278/HADOOP-13737.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5571a249a5cc 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e9c4616 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10834/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10834/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10834/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          The v01 patch removes a number of unused methods and minimizes the public interface.

          Show
          arpitagarwal Arpit Agarwal added a comment - The v01 patch removes a number of unused methods and minimizes the public interface.

            People

            • Assignee:
              arpitagarwal Arpit Agarwal
              Reporter:
              arpitagarwal Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development