Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13723

AliyunOSSInputStream#read() should update read bytes stat correctly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: tools
    • Labels:
      None

      Description

        @Override
        public synchronized int read() throws IOException {
          ......
          if (statistics != null && byteRead >= 0) {
            statistics.incrementBytesRead(1);
          }
          return byteRead;
        }
      

      I believe it should be statistics.incrementBytesRead(byteRead);?

        Activity

        Hide
        liuml07 Mingliang Liu added a comment -

        I reviewed (sorry for coming late) other places that update the file system statistics; they look good to me.

        Ping Genmao Yu, Steve Loughran and Kai Zheng for comments.

        Show
        liuml07 Mingliang Liu added a comment - I reviewed (sorry for coming late) other places that update the file system statistics; they look good to me. Ping Genmao Yu , Steve Loughran and Kai Zheng for comments.
        Hide
        drankye Kai Zheng added a comment -

        Thanks Mingliang Liu for the reporting. The patch LGTM and +1. Will convert it to a HADOOP one.

        Show
        drankye Kai Zheng added a comment - Thanks Mingliang Liu for the reporting. The patch LGTM and +1. Will convert it to a HADOOP one.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 18m 8s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 31s trunk passed
        +1 compile 0m 15s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 21s trunk passed
        +1 mvneclipse 0m 23s trunk passed
        +1 findbugs 0m 25s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 13s the patch passed
        +1 compile 0m 11s the patch passed
        +1 javac 0m 11s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 16s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 29s the patch passed
        +1 javadoc 0m 10s the patch passed
        +1 unit 0m 12s hadoop-aliyun in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        31m 17s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11007
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833250/HDFS-11007.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ba069d823a49 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0a85d07
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17145/testReport/
        modules C: hadoop-tools/hadoop-aliyun U: hadoop-tools/hadoop-aliyun
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17145/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 18m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 31s trunk passed +1 compile 0m 15s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 13s the patch passed +1 compile 0m 11s the patch passed +1 javac 0m 11s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 0m 12s hadoop-aliyun in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 31m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11007 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833250/HDFS-11007.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ba069d823a49 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0a85d07 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17145/testReport/ modules C: hadoop-tools/hadoop-aliyun U: hadoop-tools/hadoop-aliyun Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17145/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for taking care of this!

        Show
        liuml07 Mingliang Liu added a comment - Thanks for taking care of this!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 41s trunk passed
        +1 compile 0m 14s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 19s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 0m 22s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 13s the patch passed
        +1 compile 0m 11s the patch passed
        +1 javac 0m 11s the patch passed
        +1 checkstyle 0m 9s the patch passed
        +1 mvnsite 0m 16s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 27s the patch passed
        +1 javadoc 0m 10s the patch passed
        +1 unit 0m 11s hadoop-aliyun in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        11m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13723
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833250/HDFS-11007.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 266fa7f25c8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0a85d07
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10779/testReport/
        modules C: hadoop-tools/hadoop-aliyun U: hadoop-tools/hadoop-aliyun
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10779/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 41s trunk passed +1 compile 0m 14s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 0m 22s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 13s the patch passed +1 compile 0m 11s the patch passed +1 javac 0m 11s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 27s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 0m 11s hadoop-aliyun in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 11m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13723 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833250/HDFS-11007.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 266fa7f25c8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0a85d07 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10779/testReport/ modules C: hadoop-tools/hadoop-aliyun U: hadoop-tools/hadoop-aliyun Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10779/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        I have committed this to trunk branch. Thanks Kai Zheng for review.

        Show
        liuml07 Mingliang Liu added a comment - I have committed this to trunk branch. Thanks Kai Zheng for review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10609/)
        HADOOP-13723. AliyunOSSInputStream#read() should update read bytes stat (liuml07: rev d9f73f1b7cd893a7d88baa9bfd1b809a5dec9e59)

        • (edit) hadoop-tools/hadoop-aliyun/src/main/java/org/apache/hadoop/fs/aliyun/oss/AliyunOSSInputStream.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10609/ ) HADOOP-13723 . AliyunOSSInputStream#read() should update read bytes stat (liuml07: rev d9f73f1b7cd893a7d88baa9bfd1b809a5dec9e59) (edit) hadoop-tools/hadoop-aliyun/src/main/java/org/apache/hadoop/fs/aliyun/oss/AliyunOSSInputStream.java

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            liuml07 Mingliang Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development