Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13705

Revert HADOOP-13534 Remove unused TrashPolicy#getInstance and initialize code

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      Per discussion on HADOOP-13700, I'd like to revert HADOOP-13534. It removes a deprecated API, but the 2.x line does not have a release with the new replacement API. This places a burden on downstream applications.

        Issue Links

          Activity

          Hide
          andrew.wang Andrew Wang added a comment -

          Patch attached. Clean revert.

          Show
          andrew.wang Andrew Wang added a comment - Patch attached. Clean revert.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 24s trunk passed
          +1 compile 7m 45s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 20s trunk passed
          +1 javadoc 0m 41s trunk passed
          +1 mvninstall 0m 35s the patch passed
          +1 compile 6m 46s the patch passed
          -1 javac 6m 46s root generated 1 new + 708 unchanged - 0 fixed = 709 total (was 708)
          -0 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 3 new + 81 unchanged - 0 fixed = 84 total (was 81)
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 41s the patch passed
          -1 unit 21m 30s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          54m 32s



          Reason Tests
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13705
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832577/HADOOP-13705.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 96c0620a0add 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 96b1266
          Default Java 1.8.0_101
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 24s trunk passed +1 compile 7m 45s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 6m 46s the patch passed -1 javac 6m 46s root generated 1 new + 708 unchanged - 0 fixed = 709 total (was 708) -0 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 3 new + 81 unchanged - 0 fixed = 84 total (was 81) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 41s the patch passed -1 unit 21m 30s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 54m 32s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13705 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832577/HADOOP-13705.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 96c0620a0add 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96b1266 Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10725/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1. Thanks Andrew.

          Show
          ajisakaa Akira Ajisaka added a comment - +1. Thanks Andrew.
          Hide
          haibochen Haibo Chen added a comment -

          Thanks Andrew Wang for the patch. This should take care of the issues I encountered.

          Show
          haibochen Haibo Chen added a comment - Thanks Andrew Wang for the patch. This should take care of the issues I encountered.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks Akira and Haibo for reviewing, I've pushed this to trunk.

          Show
          andrew.wang Andrew Wang added a comment - Thanks Akira and Haibo for reviewing, I've pushed this to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10589 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10589/)
          HADOOP-13705. Revert HADOOP-13534 Remove unused TrashPolicy#getInstance (wang: rev 8a09bf7c19d9d2f6d6853d45e11b0d38c7c67f2a)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicy.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10589 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10589/ ) HADOOP-13705 . Revert HADOOP-13534 Remove unused TrashPolicy#getInstance (wang: rev 8a09bf7c19d9d2f6d6853d45e11b0d38c7c67f2a) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicy.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java

            People

            • Assignee:
              andrew.wang Andrew Wang
              Reporter:
              andrew.wang Andrew Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development