Hello Dushyanth. This patch basically looks good. A few comments:
- Please do not subclass NativeAzureFileSystemBaseTest for the new test suite. This causes it to re-run every @Test from the base class, which adds ~5 minutes of redundant testing to the build. Instead, please subclass AbstractWasbTestBase. See
HADOOP-13459 if you'd like more details on this.
- I suspect pre-commit will show Checkstyle warnings in TestNativeAzureFileSystemConcurrencyLive. Please indent by 2 spaces. (Do not use tabs.)
- After applying the patch, I saw test failures in TestNativeAzureFileSystemMocked,TestOutOfBandAzureBlobOperations and TestOutOfBandAzureBlobOperationsLive. Would you please investigate these and fix them?
When posting patches, please run all tests, including the tests against the live Azure Storage service, and state that you ran all tests successfully before posting the patch. Thank you.