Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13667

Fix typing mistake of inline document in hadoop-metrics2.properties

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: documentation
    • Labels:
      None

      Description

      Fix typing mistake of inline document in hadoop-metrics2.properties.

      #*.sink.ganglia.tagsForPrefix.jvm=ProcesName

      should be

      #*.sink.ganglia.tagsForPrefix.jvm=ProcessName

      And also could add examples into the inline document for easier understanding of metrics tag related configuration.

      1. HADOOP-13667.2.patch
        2 kB
        Rui Gao
      2. HADOOP-13667.patch
        2 kB
        Rui Gao

        Activity

        Hide
        templedf Daniel Templeton added a comment -

        Let me know if you need a pointer for how to create and post a patch.

        Show
        templedf Daniel Templeton added a comment - Let me know if you need a pointer for how to create and post a patch.
        Hide
        templedf Daniel Templeton added a comment -

        Ha! Nevermind. Should've looked at your profile first.

        Show
        templedf Daniel Templeton added a comment - Ha! Nevermind. Should've looked at your profile first.
        Hide
        demongaorui Rui Gao added a comment -

        How nice you are! Thanks!

        Show
        demongaorui Rui Gao added a comment - How nice you are! Thanks!
        Hide
        demongaorui Rui Gao added a comment - - edited

        Hi Daniel Templeton, could you help me review the patch? Thank you very much for your kindly help.

        Show
        demongaorui Rui Gao added a comment - - edited Hi Daniel Templeton , could you help me review the patch? Thank you very much for your kindly help.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 56s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvnsite 0m 51s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 0m 39s hadoop-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        10m 15s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13667
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830651/HADOOP-13667.patch
        Optional Tests asflicense mvnsite unit
        uname Linux 444f5be37f21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 03f519a
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10622/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10622/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 56s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvnsite 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 39s hadoop-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 10m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13667 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830651/HADOOP-13667.patch Optional Tests asflicense mvnsite unit uname Linux 444f5be37f21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 03f519a Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10622/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10622/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch. My only comment is no language. Instead of

        # An typical usage of tags is separating metrics for rpc port
        # and service rpc port of HDFS.

        it would be better as

        # A typical use of tags is separating the metrics by the HDFS rpc port
        # and HDFS service rpc port.
        Show
        templedf Daniel Templeton added a comment - Thanks for the patch. My only comment is no language. Instead of # An typical usage of tags is separating metrics for rpc port # and service rpc port of HDFS. it would be better as # A typical use of tags is separating the metrics by the HDFS rpc port # and HDFS service rpc port.
        Hide
        demongaorui Rui Gao added a comment -

        Thank you very much for your review and comment. I had attached a new patch. Could you help to review it when you got time? Thank you.

        Show
        demongaorui Rui Gao added a comment - Thank you very much for your review and comment. I had attached a new patch. Could you help to review it when you got time? Thank you.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 41s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvnsite 0m 51s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 0m 39s hadoop-common in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        9m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13667
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832618/HADOOP-13667.2.patch
        Optional Tests asflicense mvnsite unit
        uname Linux 8f8920614dca 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 96b1266
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10729/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10729/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 41s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvnsite 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 0m 39s hadoop-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 9m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13667 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832618/HADOOP-13667.2.patch Optional Tests asflicense mvnsite unit uname Linux 8f8920614dca 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96b1266 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10729/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10729/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Rui Gao. Looks good to me, but I don't know much about exporting the metrics to Ganglia. Andrew Wang, can you take a look or recommend a reviewer?

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Rui Gao . Looks good to me, but I don't know much about exporting the metrics to Ganglia. Andrew Wang , can you take a look or recommend a reviewer?
        Hide
        andrew.wang Andrew Wang added a comment -

        I don't know much about Ganglia either, but since this is just additional documentation, I think it's okay for commit.

        Show
        andrew.wang Andrew Wang added a comment - I don't know much about Ganglia either, but since this is just additional documentation, I think it's okay for commit.
        Hide
        templedf Daniel Templeton added a comment -

        Alrighty then. +1 from me.

        Show
        templedf Daniel Templeton added a comment - Alrighty then. +1 from me.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the fix, Rui Gao. Committed to trunk.

        Show
        templedf Daniel Templeton added a comment - Thanks for the fix, Rui Gao . Committed to trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10753 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10753/)
        HADOOP-13667. Fix typing mistake of inline document in (templedf: rev 0dc2a6a3a50add18e959475032264b04aff18fc4)

        • (edit) hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics2.properties
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10753 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10753/ ) HADOOP-13667 . Fix typing mistake of inline document in (templedf: rev 0dc2a6a3a50add18e959475032264b04aff18fc4) (edit) hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics2.properties
        Hide
        demongaorui Rui Gao added a comment -

        Daniel Templeton Andrew Wang Thank you very much for review and commit

        Show
        demongaorui Rui Gao added a comment - Daniel Templeton Andrew Wang Thank you very much for review and commit

          People

          • Assignee:
            demongaorui Rui Gao
            Reporter:
            demongaorui Rui Gao
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development