Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.7.3
-
Fix Version/s: 2.8.0, 3.0.0-alpha2
-
Component/s: scripts
-
Labels:None
-
Environment:
Windows
Description
Sometimes, the NodeResourceMonitor tries to read the system utilization from winutils.exe and this return empty values. This triggers the following exception:
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1911)
at org.apache.hadoop.util.SysInfoWindows.refreshIfNeeded(SysInfoWindows.java:158)
at org.apache.hadoop.util.SysInfoWindows.getPhysicalMemorySize(SysInfoWindows.java:247)
at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getPhysicalMemorySize(ResourceCalculatorPlugin.java:63)
at org.apache.hadoop.yarn.server.nodemanager.NodeResourceMonitorImpl$MonitoringThread.run(NodeResourceMonitorImpl.java:139)
Issue Links
- relates to
-
HADOOP-14354
SysInfoWindows is not thread safe
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 19s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 7m 32s | trunk passed |
| +1 | compile | 6m 50s | trunk passed |
| +1 | checkstyle | 0m 22s | trunk passed |
| +1 | mvnsite | 0m 58s | trunk passed |
| +1 | mvneclipse | 0m 13s | trunk passed |
| +1 | findbugs | 1m 19s | trunk passed |
| +1 | javadoc | 0m 45s | trunk passed |
| +1 | mvninstall | 0m 38s | the patch passed |
| +1 | compile | 6m 47s | the patch passed |
| +1 | javac | 6m 47s | the patch passed |
| +1 | checkstyle | 0m 21s | the patch passed |
| +1 | mvnsite | 0m 53s | the patch passed |
| +1 | mvneclipse | 0m 13s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | findbugs | 1m 25s | the patch passed |
| +1 | javadoc | 0m 45s | the patch passed |
| +1 | unit | 8m 10s | hadoop-common in the patch passed. |
| +1 | asflicense | 0m 22s | The patch does not generate ASF License warnings. |
| 39m 13s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12830517/HADOOP-13663.000.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux 44f0c17f1a17 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / df1d0f5 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/10611/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/10611/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Could you add a test for this into TestSysInfoWindows?
Modified unit test.
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 16s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | mvninstall | 7m 27s | trunk passed |
| +1 | compile | 6m 51s | trunk passed |
| +1 | checkstyle | 0m 22s | trunk passed |
| +1 | mvnsite | 0m 56s | trunk passed |
| +1 | mvneclipse | 0m 12s | trunk passed |
| +1 | findbugs | 1m 18s | trunk passed |
| +1 | javadoc | 0m 44s | trunk passed |
| +1 | mvninstall | 0m 36s | the patch passed |
| +1 | compile | 6m 44s | the patch passed |
| +1 | javac | 6m 44s | the patch passed |
| +1 | checkstyle | 0m 22s | the patch passed |
| +1 | mvnsite | 0m 53s | the patch passed |
| +1 | mvneclipse | 0m 12s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | findbugs | 1m 24s | the patch passed |
| +1 | javadoc | 0m 44s | the patch passed |
| +1 | unit | 7m 18s | hadoop-common in the patch passed. |
| +1 | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| 38m 8s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12830522/HADOOP-13663.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux a85538299447 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 8ae4729 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/10612/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/10612/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
My cleanest Hadoop QA report in a long time 
Steve Loughran are you OK with this patch?
+1
committed to 2.8+
if you need this in 2.7.4, you'll need to open a new JIRA with a patch named for a build & test against that branch. e.g HADOOP-13663-branch-2.7-001.patch
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10511 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10511/)
HADOOP-13663 Index out of range in SysInfoWindows. Contributed by Inigo (stevel: rev 1518cb9532cbedeada1b3d880f4ef1059301e828)
- (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SysInfoWindows.java
- (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestSysInfoWindows.java
Thank you Steve Loughran, 2.8+ is good. No need for 2.7.4 for us.
If anyone wants it pushed there, I can go ahead.
Re-resolving so the status is "Fixed" rather than "Resolved".
Checking if the index is a positive number. I tried to put all the error message together in the code.