Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      hadoop-common-project/hadoop-common/src/main/java/overview.html is outdated and not linked from anywhere.

      1. HADOOP-13646.patch
        9 kB
        Brahma Reddy Battula
      2. HADOOP-13646-002.patch
        19 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch..Kindly review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch..Kindly review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 34s trunk passed
        +1 compile 7m 18s trunk passed
        +1 mvnsite 3m 1s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 javadoc 0m 46s trunk passed
        +1 mvninstall 0m 40s the patch passed
        +1 compile 7m 13s the patch passed
        +1 javac 7m 13s the patch passed
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 javadoc 0m 46s the patch passed
        +1 unit 8m 31s hadoop-common in the patch passed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        38m 39s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830019/HADOOP-13646.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit
        uname Linux f0de41a573db 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e5ef51e
        Default Java 1.8.0_101
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10580/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10580/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 34s trunk passed +1 compile 7m 18s trunk passed +1 mvnsite 3m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 7m 13s the patch passed +1 javac 7m 13s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 javadoc 0m 46s the patch passed +1 unit 8m 31s hadoop-common in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 38m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830019/HADOOP-13646.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit uname Linux f0de41a573db 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e5ef51e Default Java 1.8.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10580/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10580/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        Isn't this file used by the maven javadoc plugin?

        Show
        aw Allen Wittenauer added a comment - Isn't this file used by the maven javadoc plugin?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Allen. Yes, it is actually used.
        https://github.com/apache/hadoop/blob/trunk/pom.xml#L575

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Allen. Yes, it is actually used. https://github.com/apache/hadoop/blob/trunk/pom.xml#L575
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        It's anyway outdated data and we can remove from maven javadoc plugin also..? am I correct..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - It's anyway outdated data and we can remove from maven javadoc plugin also..? am I correct..?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        It looks like the setting is used when we execute "mvn javadoc:aggregate -Pdist", but this command is not documented or used. Therefore I'm thinking the setting can be removed. Please let me know if I am wrong.

        Show
        ajisakaa Akira Ajisaka added a comment - It looks like the setting is used when we execute "mvn javadoc:aggregate -Pdist", but this command is not documented or used. Therefore I'm thinking the setting can be removed. Please let me know if I am wrong.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'm +1 for removing overview.html and remove the setting in pom.xml. Now there are 3 overview.html in the source tree and I'm thinking we can remove all of them. Hi Allen Wittenauer, what do you think?

        Show
        ajisakaa Akira Ajisaka added a comment - I'm +1 for removing overview.html and remove the setting in pom.xml. Now there are 3 overview.html in the source tree and I'm thinking we can remove all of them. Hi Allen Wittenauer , what do you think?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Hi Brahma Reddy Battula, would you remove the maven javadoc plugin setting in pom.xml also?

        Show
        ajisakaa Akira Ajisaka added a comment - Hi Brahma Reddy Battula , would you remove the maven javadoc plugin setting in pom.xml also?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Akira Ajisaka thanks for taking a look..Uploaded patch.kindly review.

        Now there are 3 overview.html in the source tree and I'm thinking we can remove all of them.

        I feel, org/apache/hadoop/hdfs/protocolPB/overview.html can't removed as javadoc of DatanodeProtocol,InterDatanodeProtocol,JournalProtocol and NamenodeProtocol contains it and it's related to Protocol Buffers

        Show
        brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks for taking a look..Uploaded patch.kindly review. Now there are 3 overview.html in the source tree and I'm thinking we can remove all of them. I feel, org/apache/hadoop/hdfs/protocolPB/overview.html can't removed as javadoc of DatanodeProtocol , InterDatanodeProtocol , JournalProtocol and NamenodeProtocol contains it and it's related to Protocol Buffers
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 6m 46s trunk passed
        +1 compile 9m 32s trunk passed
        +1 mvnsite 9m 46s trunk passed
        +1 mvneclipse 1m 5s trunk passed
        +1 javadoc 4m 26s trunk passed
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 8m 10s the patch passed
        +1 compile 9m 19s the patch passed
        +1 javac 9m 19s the patch passed
        +1 mvnsite 9m 29s the patch passed
        +1 mvneclipse 1m 3s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 4m 23s the patch passed
        -1 unit 150m 18s root in the patch failed.
        -1 asflicense 0m 33s The patch generated 2 ASF License warnings.
        216m 28s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13646
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839782/HADOOP-13646-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 4a5bd200e64c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c68dad1
        Default Java 1.8.0_111
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11109/artifact/patchprocess/patch-unit-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11109/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/11109/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs . U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11109/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 46s trunk passed +1 compile 9m 32s trunk passed +1 mvnsite 9m 46s trunk passed +1 mvneclipse 1m 5s trunk passed +1 javadoc 4m 26s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 8m 10s the patch passed +1 compile 9m 19s the patch passed +1 javac 9m 19s the patch passed +1 mvnsite 9m 29s the patch passed +1 mvneclipse 1m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 4m 23s the patch passed -1 unit 150m 18s root in the patch failed. -1 asflicense 0m 33s The patch generated 2 ASF License warnings. 216m 28s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13646 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839782/HADOOP-13646-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 4a5bd200e64c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c68dad1 Default Java 1.8.0_111 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11109/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11109/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/11109/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11109/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1. Thanks Brahma Reddy Battula.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1. Thanks Brahma Reddy Battula .
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,branch-2 and branch-2.8.
        Akira Ajisaka thanks lot for review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2 and branch-2.8. Akira Ajisaka thanks lot for review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10872 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10872/)
        HADOOP-13646. Remove outdated overview.html. Contributed By Brahma Reddy (brahma: rev afcf8d38e750f935c06629e641a1321b79c4cace)

        • (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/java/overview.html
        • (edit) pom.xml
        • (delete) hadoop-common-project/hadoop-common/src/main/java/overview.html
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10872 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10872/ ) HADOOP-13646 . Remove outdated overview.html. Contributed By Brahma Reddy (brahma: rev afcf8d38e750f935c06629e641a1321b79c4cace) (delete) hadoop-hdfs-project/hadoop-hdfs/src/main/java/overview.html (edit) pom.xml (delete) hadoop-common-project/hadoop-common/src/main/java/overview.html

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development