Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.8.0
-
Fix Version/s: 2.8.0, 3.0.0-alpha2
-
Component/s: None
-
Labels:None
Description
There is a minor math error in AbstractContractDistCpTest when calculating file size:
int fileSizeMb = fileSizeKb * 1024;
This should be division, not multiplication.
Issue Links
- relates to
-
HADOOP-13145
In DistCp, prevent unnecessary getFileStatus call when not preserving metadata.
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Ping Steve Loughran.. easy code review.
Show
Aaron Fabbri
added a comment - Ping Steve Loughran .. easy code review.
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 14s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | mvninstall | 8m 18s | trunk passed |
| +1 | compile | 0m 19s | trunk passed |
| +1 | checkstyle | 0m 13s | trunk passed |
| +1 | mvnsite | 0m 23s | trunk passed |
| +1 | mvneclipse | 0m 15s | trunk passed |
| +1 | findbugs | 0m 26s | trunk passed |
| +1 | javadoc | 0m 13s | trunk passed |
| +1 | mvninstall | 0m 15s | the patch passed |
| +1 | compile | 0m 15s | the patch passed |
| +1 | javac | 0m 15s | the patch passed |
| +1 | checkstyle | 0m 10s | the patch passed |
| +1 | mvnsite | 0m 18s | the patch passed |
| +1 | mvneclipse | 0m 10s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | findbugs | 0m 29s | the patch passed |
| +1 | javadoc | 0m 11s | the patch passed |
| +1 | unit | 10m 0s | hadoop-distcp in the patch passed. |
| +1 | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| 23m 41s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12829959/HADOOP-13643.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux a0f5885a56fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 5ffd4b7 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/10577/testReport/ |
| modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/10577/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Show
Hadoop QA
added a comment -
+1 overall
Vote
Subsystem
Runtime
Comment
0
reexec
0m 14s
Docker mode activated.
+1
@author
0m 0s
The patch does not contain any @author tags.
+1
test4tests
0m 0s
The patch appears to include 1 new or modified test files.
+1
mvninstall
8m 18s
trunk passed
+1
compile
0m 19s
trunk passed
+1
checkstyle
0m 13s
trunk passed
+1
mvnsite
0m 23s
trunk passed
+1
mvneclipse
0m 15s
trunk passed
+1
findbugs
0m 26s
trunk passed
+1
javadoc
0m 13s
trunk passed
+1
mvninstall
0m 15s
the patch passed
+1
compile
0m 15s
the patch passed
+1
javac
0m 15s
the patch passed
+1
checkstyle
0m 10s
the patch passed
+1
mvnsite
0m 18s
the patch passed
+1
mvneclipse
0m 10s
the patch passed
+1
whitespace
0m 0s
The patch has no whitespace issues.
+1
findbugs
0m 29s
the patch passed
+1
javadoc
0m 11s
the patch passed
+1
unit
10m 0s
hadoop-distcp in the patch passed.
+1
asflicense
0m 16s
The patch does not generate ASF License warnings.
23m 41s
Subsystem
Report/Notes
Docker
Image:yetus/hadoop:9560f25
JIRA Issue
HADOOP-13643
JIRA Patch URL
https://issues.apache.org/jira/secure/attachment/12829959/HADOOP-13643.001.patch
Optional Tests
asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
uname
Linux a0f5885a56fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
Build tool
maven
Personality
/testptch/hadoop/patchprocess/precommit/personality/provided.sh
git revision
trunk / 5ffd4b7
Default Java
1.8.0_101
findbugs
v3.0.0
Test Results
https://builds.apache.org/job/PreCommit-HADOOP-Build/10577/testReport/
modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output
https://builds.apache.org/job/PreCommit-HADOOP-Build/10577/console
Powered by
Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org
This message was automatically generated.
+1, committed, thanks!
Show
Steve Loughran
added a comment - +1, committed, thanks!
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10478 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10478/)
HADOOP-13643. Math error in AbstractContractDistCpTest. Contributed by (stevel: rev e5ef51e717647328db9f2b80f21fe44b99079d08)
- (edit) hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java
Show
Hudson
added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10478 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10478/ )
HADOOP-13643 . Math error in AbstractContractDistCpTest. Contributed by (stevel: rev e5ef51e717647328db9f2b80f21fe44b99079d08)
(edit) hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java
Thank you, Aaron Fabbri and Sean Mackrory.
Show
Chris Nauroth
added a comment - Thank you, Aaron Fabbri and Sean Mackrory .
Hat tip to Sean Mackrory for spotting this one.