Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: documentation, fs/s3
    • Labels:
      None

      Description

      HADOOP-12709 should have cut off s3:// fully from the trunk branch for Hadoop 3. However, during the long rebasing period, there are some omissions left in documentation aka hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md. This jira is to address this.

      1. HADOOP-13621.001.patch
        3 kB
        Mingliang Liu
      2. HADOOP-13621.000.patch
        3 kB
        Mingliang Liu

        Activity

        Hide
        liuml07 Mingliang Liu added a comment -

        Ping Chris Nauroth and Akira Ajisaka for kind review.

        Show
        liuml07 Mingliang Liu added a comment - Ping Chris Nauroth and Akira Ajisaka for kind review.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvninstall 7m 24s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvnsite 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        9m 0s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13621
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828942/HADOOP-13621.000.patch
        Optional Tests asflicense mvnsite
        uname Linux 5efa8f4eaa39 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 501a778
        modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10531/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 7m 24s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvnsite 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 9m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13621 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828942/HADOOP-13621.000.patch Optional Tests asflicense mvnsite uname Linux 5efa8f4eaa39 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 501a778 modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10531/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Nice catch! Two comments from me.

              <description>Determines where on the local filesystem the s3:/s3n: filesystem
        

        1. Would you remove s3:?

        (or `org.apache.hadoop.fs.s3native.NativeS3FileSystem`, `org.apache.hadoop.fs.s3.S3FileSystem`).
        

        2. Would you remove org.apache.hadoop.fs.s3.S3FileSystem?

        Show
        ajisakaa Akira Ajisaka added a comment - Nice catch! Two comments from me. <description>Determines where on the local filesystem the s3:/s3n: filesystem 1. Would you remove s3:? (or `org.apache.hadoop.fs.s3native.NativeS3FileSystem`, `org.apache.hadoop.fs.s3.S3FileSystem`). 2. Would you remove org.apache.hadoop.fs.s3.S3FileSystem?
        Hide
        liuml07 Mingliang Liu added a comment - - edited

        Thanks Akira Ajisaka for the review and useful comments. I updated the v1 patch (see HADOOP-13621.001.patch).

        Show
        liuml07 Mingliang Liu added a comment - - edited Thanks Akira Ajisaka for the review and useful comments. I updated the v1 patch (see HADOOP-13621.001.patch ).
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvninstall 6m 39s trunk passed
        +1 mvnsite 0m 24s trunk passed
        +1 mvnsite 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        8m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13621
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829070/HADOOP-13621.001.patch
        Optional Tests asflicense mvnsite
        uname Linux fa530b43f886 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f67237c
        modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10532/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 6m 39s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvnsite 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 8m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13621 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829070/HADOOP-13621.001.patch Optional Tests asflicense mvnsite uname Linux fa530b43f886 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f67237c modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10532/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        liuml07 Mingliang Liu added a comment -

        Committed to trunk branch. Thanks Akira Ajisaka for review.

        Show
        liuml07 Mingliang Liu added a comment - Committed to trunk branch. Thanks Akira Ajisaka for review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10456 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10456/)
        HADOOP-13621. s3:// should have been fully cut off from trunk. (liuml07: rev 96142efa2dded3212d07e7e14e251066865fb7d2)

        • (edit) hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10456 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10456/ ) HADOOP-13621 . s3:// should have been fully cut off from trunk. (liuml07: rev 96142efa2dded3212d07e7e14e251066865fb7d2) (edit) hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            liuml07 Mingliang Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development