Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13606

swift FS to add a service load metadata file

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.3
    • Fix Version/s: 2.9.0, 2.8.1, 3.0.0-alpha3
    • Component/s: fs/swift
    • Labels:
      None

      Description

      add a metadata file giving the FS impl of swift; remove the entry from core-default.xml

      1. HADOOP-13606.002.patch
        3 kB
        John Zhuge
      2. HADOOP-13606-branch-2-001.patch
        2 kB
        Steve Loughran
      3. unit_test_results_for_HADOOP-13606.002
        31 kB
        John Zhuge

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          move to a service file

          tested in hadoop-openstack against RAX US; also tested in spark

          Show
          stevel@apache.org Steve Loughran added a comment - move to a service file tested in hadoop-openstack against RAX US; also tested in spark
          Hide
          cnauroth Chris Nauroth added a comment - - edited

          +1 pending pre-commit.

          I'm not currently set up for end-to-end testing against an OpenStack instance. I did build a distro, deploy it, and confirm that shell commands for a swift: URI dispatch successfully into the hadoop-openstack code, so I know the class loading through the service loader is working fine.

          Steve, thank you for sharing your test pass results.

          Show
          cnauroth Chris Nauroth added a comment - - edited +1 pending pre-commit. I'm not currently set up for end-to-end testing against an OpenStack instance. I did build a distro, deploy it, and confirm that shell commands for a swift: URI dispatch successfully into the hadoop-openstack code, so I know the class loading through the service loader is working fine. Steve, thank you for sharing your test pass results.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 56s branch-2 passed
          +1 compile 6m 31s branch-2 passed with JDK v1.8.0_101
          +1 compile 6m 59s branch-2 passed with JDK v1.7.0_111
          +1 mvnsite 1m 17s branch-2 passed
          +1 mvneclipse 0m 30s branch-2 passed
          +1 javadoc 0m 56s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 10s branch-2 passed with JDK v1.7.0_111
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 55s the patch passed
          +1 compile 5m 23s the patch passed with JDK v1.8.0_101
          +1 javac 5m 23s the patch passed
          +1 compile 6m 30s the patch passed with JDK v1.7.0_111
          +1 javac 6m 30s the patch passed
          +1 mvnsite 1m 16s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 57s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 10s the patch passed with JDK v1.7.0_111
          +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.7.0_111.
          +1 unit 0m 15s hadoop-openstack in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          60m 11s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HADOOP-13606
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828316/HADOOP-13606-branch-2-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 65e7f85b0e57 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 55600b3
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10500/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10500/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-openstack U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10500/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 56s branch-2 passed +1 compile 6m 31s branch-2 passed with JDK v1.8.0_101 +1 compile 6m 59s branch-2 passed with JDK v1.7.0_111 +1 mvnsite 1m 17s branch-2 passed +1 mvneclipse 0m 30s branch-2 passed +1 javadoc 0m 56s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 10s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 5m 23s the patch passed with JDK v1.8.0_101 +1 javac 5m 23s the patch passed +1 compile 6m 30s the patch passed with JDK v1.7.0_111 +1 javac 6m 30s the patch passed +1 mvnsite 1m 16s the patch passed +1 mvneclipse 0m 29s the patch passed -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 57s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 10s the patch passed with JDK v1.7.0_111 +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.7.0_111. +1 unit 0m 15s hadoop-openstack in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 60m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-13606 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828316/HADOOP-13606-branch-2-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 65e7f85b0e57 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 55600b3 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10500/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10500/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-openstack U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10500/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          No new tests necessary, and the whitespace warnings aren't really related.

          Show
          cnauroth Chris Nauroth added a comment - No new tests necessary, and the whitespace warnings aren't really related.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10441 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10441/)
          HADOOP-13606 swift FS to add a service load metadata file. Contributed (stevel: rev 53a12fa721bb431f7d481aac7d245c93efb56153)

          • (add) hadoop-tools/hadoop-openstack/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem
          • (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10441 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10441/ ) HADOOP-13606 swift FS to add a service load metadata file. Contributed (stevel: rev 53a12fa721bb431f7d481aac7d245c93efb56153) (add) hadoop-tools/hadoop-openstack/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Hide
          jzhuge John Zhuge added a comment -

          Per discussion in HADOOP-14132, I'm going to revert this patch, in order to speed up the load time for Hadoop client.

          I will wait for a few days in case anyone objects.

          Show
          jzhuge John Zhuge added a comment - Per discussion in HADOOP-14132 , I'm going to revert this patch, in order to speed up the load time for Hadoop client. I will wait for a few days in case anyone objects.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 002

          • Revert commit 53a12fa721bb431f7d481aac7d245c93efb56153

          Testing done

          • Live unit tests against Rackspace US public, region DFW.

          There are many unit test failures:

          • TestSwiftContractRootDir#testRmNonEmptyRootDirNonRecursive failure is tracked by HADOOP-14151 Swift treats 0-len file as directory
          • TestSwiftFileSystemContract#testWriteReadAndDeleteTwoBlocks failure is tracked by HADOOP-14152 Operation not authorized in swift unit test

          The rest of failures were caused by weak consistency of the blobstore

          • FileNotFoundException due to "get-after-create"
          • HTTP error 409 Conflict due to "delete-after-create"
          • Assertion by TestSwiftFileSystemLsOperations#testListEmptyRoot due to "list-after-delete"
          Show
          jzhuge John Zhuge added a comment - Patch 002 Revert commit 53a12fa721bb431f7d481aac7d245c93efb56153 Testing done Live unit tests against Rackspace US public, region DFW. There are many unit test failures: TestSwiftContractRootDir#testRmNonEmptyRootDirNonRecursive failure is tracked by HADOOP-14151 Swift treats 0-len file as directory TestSwiftFileSystemContract#testWriteReadAndDeleteTwoBlocks failure is tracked by HADOOP-14152 Operation not authorized in swift unit test The rest of failures were caused by weak consistency of the blobstore FileNotFoundException due to "get-after-create" HTTP error 409 Conflict due to "delete-after-create" Assertion by TestSwiftFileSystemLsOperations#testListEmptyRoot due to "list-after-delete"
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1 for the rollback

          Show
          stevel@apache.org Steve Loughran added a comment - +1 for the rollback
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11372 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11372/)
          Revert "HADOOP-13606 swift FS to add a service load metadata file. (john.zhuge: rev 98142d2f722e82d57b0e2bae6276f7c17fd99598)

          • (delete) hadoop-tools/hadoop-openstack/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem
          • (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11372 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11372/ ) Revert " HADOOP-13606 swift FS to add a service load metadata file. (john.zhuge: rev 98142d2f722e82d57b0e2bae6276f7c17fd99598) (delete) hadoop-tools/hadoop-openstack/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Hide
          jzhuge John Zhuge added a comment -

          Committed to trunk, branch-2, and branch-2.8. Thanks Steve Loughran for the discussion and review.

          Show
          jzhuge John Zhuge added a comment - Committed to trunk, branch-2, and branch-2.8. Thanks Steve Loughran for the discussion and review.

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development