Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
Reviewed
Description
The packages related to the DockerLinuxContainerRuntime all exceed the 80 char line length limit enforced by checkstyle. This causes every build to fail with a -1. I would like to exclude this rule from causing a failure.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerCommandExecutor.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88). ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/DockerContainerStatusHandler.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88). ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/package-info.java:23:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88). ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/privileged/MockPrivilegedOperationCaptor.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged;: Line is longer than 80 characters (found 84). ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerRuntimeTestingUtils.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime;: Line is longer than 80 characters (found 81). ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/MockDockerContainerStatusHandler.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88). ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerCommandExecutor.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88). ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/docker/TestDockerContainerStatusHandler.java:17:package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker;: Line is longer than 80 characters (found 88).
Alternatively, we could look to restructure the packages here, but I question what value this check really provides.