Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13598

Add eol=lf for unix format files in .gitattributes

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In .gitattributes, eol=crlf is set for .cmd and .bat, but eol=lf is not set for .java, .html, and so on. Setting eol=lf would be great for developers using Windows.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10439 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10439/)
        HADOOP-13598. Add eol=lf for unix format files in .gitattributes. (aajisaka: rev 696bc0e0abe57051470da0cbd539ddf21cc60da9)

        • (edit) .gitattributes
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10439 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10439/ ) HADOOP-13598 . Add eol=lf for unix format files in .gitattributes. (aajisaka: rev 696bc0e0abe57051470da0cbd539ddf21cc60da9) (edit) .gitattributes
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution!
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        0m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13598
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828196/HADOOP-13598.001.patch
        Optional Tests asflicense
        uname Linux b50f02106a63 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f0876b8
        modules C: . U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10491/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 0m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13598 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828196/HADOOP-13598.001.patch Optional Tests asflicense uname Linux b50f02106a63 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f0876b8 modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10491/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a initial patch to address the comment that Akira Ajisaka has mentioned in HDFS-10856.

        Show
        linyiqun Yiqun Lin added a comment - Attach a initial patch to address the comment that Akira Ajisaka has mentioned in HDFS-10856 .

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development