Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13580

If user is unauthorized, log "unauthorized" instead of "Invalid signed text:"

    Details

    • Hadoop Flags:
      Reviewed

      Description

      If a user is unauthorized to access web interface, the signed text is empty, and the web interface prints

      org.apache.hadoop.security.authentication.util.SignerException: Invalid signed text:

      This error message is obscure. It should be a more meaningful message like "Unauthorized access."

      1. HADOOP-13580.001.patch
        1 kB
        Wei-Chiu Chuang
      2. HADOOP-13580.002.patch
        1 kB
        Wei-Chiu Chuang

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10449 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10449/)
        HADOOP-13580. If user is unauthorized, log "unauthorized" instead of (weichiu: rev f6f3a447bf3b2900a2e9a0615ad9877f9310e062)

        • (edit) hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/AuthenticationFilter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10449 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10449/ ) HADOOP-13580 . If user is unauthorized, log "unauthorized" instead of (weichiu: rev f6f3a447bf3b2900a2e9a0615ad9877f9310e062) (edit) hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/AuthenticationFilter.java
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committed to branch2.8, branch-2 and trunk. Thanks to Andrew Wang for +1!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committed to branch2.8, branch-2 and trunk. Thanks to Andrew Wang for +1!
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committing the patch based on Andrew's +1.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committing the patch based on Andrew's +1.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 40s trunk passed
        +1 compile 6m 48s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 17s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 0m 21s trunk passed
        +1 javadoc 0m 11s trunk passed
        +1 mvninstall 0m 12s the patch passed
        +1 compile 6m 46s the patch passed
        +1 javac 6m 46s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 17s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 28s the patch passed
        +1 javadoc 0m 13s the patch passed
        +1 unit 3m 15s hadoop-auth in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        28m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13580
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828097/HADOOP-13580.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 994ec0158383 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 58ed4fa
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10487/testReport/
        modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10487/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 40s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 17s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 21s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 12s the patch passed +1 compile 6m 46s the patch passed +1 javac 6m 46s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 17s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 3m 15s hadoop-auth in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 28m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13580 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828097/HADOOP-13580.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 994ec0158383 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 58ed4fa Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10487/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10487/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        The resubmit doesn't seem to work. Resubmit v01 patch as v02 and see if that works....

        Show
        jojochuang Wei-Chiu Chuang added a comment - The resubmit doesn't seem to work. Resubmit v01 patch as v02 and see if that works....
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        cancel & resubmit

        Show
        jojochuang Wei-Chiu Chuang added a comment - cancel & resubmit
        Hide
        andrew.wang Andrew Wang added a comment -

        +1

        Show
        andrew.wang Andrew Wang added a comment - +1
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Post a simple patch to make error message better.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Post a simple patch to make error message better.

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development