[HADOOP-13559] Remove close() within try-with-resources in ChecksumFileSystem/ChecksumFs classes

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.0, 2.9.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: fs
• Target Version/s: 2.8.0, 2.9.0
• Hadoop Flags: Reviewed
• Assignee: Aaron Fabbri
• Reporter: Aaron Fabbri
• Created: 29/Aug/16 17:01
• Updated: 30/Aug/16 01:11
• Resolved: 29/Aug/16 20:07

Description

My colleague noticed that HADOOP-12994 introduced to places where close() was still called manually within a try-with-resources block.

I'll attach a patch to remove the manual close() calls.

These extra calls to close() are probably safe, as InputStream is a Closable, not AutoClosable (the later does not specify close() as idempotent).

Issue Links

• relates to: HADOOP-12994 Specify PositionedReadable, add contract tests, fix problems