Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2, HADOOP-13341
    • Component/s: scripts
    • Labels:
      None

      Description

      There are only two OPTS vars for security and they are inconsistent. Additionally, if someone adds a subcommand that needs security support, we have no hook to allow for an _OPTS.

      1. HADOOP-13554-HADOOP-13341.01.patch
        4 kB
        Allen Wittenauer
      2. HADOOP-13554-HADOOP-13341.00.patch
        2 kB
        Allen Wittenauer

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 8m 26s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 10m 17s HADOOP-13341 passed
        +1 mvnsite 1m 3s HADOOP-13341 passed
        +1 mvnsite 0m 51s the patch passed
        +1 shellcheck 0m 12s There were no new shellcheck issues.
        +1 shelldocs 0m 10s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 1m 57s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        23m 39s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13554
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826190/HADOOP-13554-HADOOP-13341.01.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux fcd201cb5cff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision HADOOP-13341 / cec3102
        shellcheck v0.4.4
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10409/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10409/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 8m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 17s HADOOP-13341 passed +1 mvnsite 1m 3s HADOOP-13341 passed +1 mvnsite 0m 51s the patch passed +1 shellcheck 0m 12s There were no new shellcheck issues. +1 shelldocs 0m 10s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 1m 57s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 23m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13554 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826190/HADOOP-13554-HADOOP-13341.01.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux fcd201cb5cff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision HADOOP-13341 / cec3102 shellcheck v0.4.4 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10409/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10409/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        -01:

        • forgot test file
        Show
        aw Allen Wittenauer added a comment - -01: forgot test file
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 52s HADOOP-13341 passed
        +1 mvnsite 0m 56s HADOOP-13341 passed
        +1 mvnsite 0m 50s the patch passed
        +1 shellcheck 0m 12s There were no new shellcheck issues.
        +1 shelldocs 0m 9s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 1m 53s hadoop-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        11m 48s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13554
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825928/HADOOP-13554-HADOOP-13341.00.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux a3971d40192f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision HADOOP-13341 / cec3102
        shellcheck v0.4.4
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10397/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10397/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 52s HADOOP-13341 passed +1 mvnsite 0m 56s HADOOP-13341 passed +1 mvnsite 0m 50s the patch passed +1 shellcheck 0m 12s There were no new shellcheck issues. +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 1m 53s hadoop-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 11m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13554 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825928/HADOOP-13554-HADOOP-13341.00.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux a3971d40192f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision HADOOP-13341 / cec3102 shellcheck v0.4.4 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10397/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10397/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            aw Allen Wittenauer
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development