Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-13426 improved encoding and added framed buffers. Upon further review, the intermediate response buffer is completely unnecessary for PB responses since the size can be pre-computed unlike Writables.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10397 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10397/)
        HADOOP-13549. Eliminate intermediate buffer for server-side PB encoding. (kihwal: rev 39d1b1d747b1e325792b897b3264272f32b756a9)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10397 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10397/ ) HADOOP-13549 . Eliminate intermediate buffer for server-side PB encoding. (kihwal: rev 39d1b1d747b1e325792b897b3264272f32b756a9) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Hide
        kihwal Kihwal Lee added a comment -

        Committed this to trunk, branch-2 and branch-2.8.

        Show
        kihwal Kihwal Lee added a comment - Committed this to trunk, branch-2 and branch-2.8.
        Hide
        kihwal Kihwal Lee added a comment -

        +1 a nice optimization.

        Show
        kihwal Kihwal Lee added a comment - +1 a nice optimization.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 4s trunk passed
        +1 compile 8m 14s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 29s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 6m 44s the patch passed
        +1 javac 6m 44s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 45s the patch passed
        +1 unit 8m 4s hadoop-common in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        41m 32s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13549
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825501/HADOOP-13549.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 747539c08b79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1360bd2
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10375/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10375/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 4s trunk passed +1 compile 8m 14s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 6m 44s the patch passed +1 javac 6m 44s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 4s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 41m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13549 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825501/HADOOP-13549.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 747539c08b79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1360bd2 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10375/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10375/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        daryn Daryn Sharp added a comment -

        Patch is rather trivial to include an optimized second PB-specific method for setupResponse. Existing tests prove the encoding is correct else the client would fail.

        Show
        daryn Daryn Sharp added a comment - Patch is rather trivial to include an optimized second PB-specific method for setupResponse. Existing tests prove the encoding is correct else the client would fail.

          People

          • Assignee:
            daryn Daryn Sharp
            Reporter:
            daryn Daryn Sharp
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development