Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Override #equals and #hashcode to ensure multiple instances are equivalent. They eventually
      share the same RPC connection given the other arguments of constructing ConnectionId are
      the same.

      1. HADOOP-13546-HADOOP-13436.000.patch
        10 kB
        Xiaobing Zhou
      2. HADOOP-13546-HADOOP-13436.001.patch
        11 kB
        Xiaobing Zhou
      3. HADOOP-13546-HADOOP-13436.002.patch
        17 kB
        Xiaobing Zhou
      4. HADOOP-13546-HADOOP-13436.003.patch
        17 kB
        Xiaobing Zhou
      5. HADOOP-13546-HADOOP-13436.004.patch
        18 kB
        Xiaobing Zhou
      6. HADOOP-13546-HADOOP-13436.005.patch
        18 kB
        Xiaobing Zhou
      7. HADOOP-13546-HADOOP-13436.006.patch
        18 kB
        Xiaobing Zhou
      8. HADOOP-13546-HADOOP-13436.007.patch
        22 kB
        Xiaobing Zhou

        Activity

        Hide
        jingzhao Jing Zhao added a comment -

        Yes, I think we can backport it to 2.7

        Show
        jingzhao Jing Zhao added a comment - Yes, I think we can backport it to 2.7
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Ping Jing Zhao for input for it.

        Show
        xiaobingo Xiaobing Zhou added a comment - Ping Jing Zhao for input for it.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        it's good to have in branch-2.7..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - it's good to have in branch-2.7..?
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thank you Jing Zhao for committing it.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thank you Jing Zhao for committing it.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10436 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10436/)
        HADOOP-13546. Override equals and hashCode of the default retry policy (jing9: rev 08d8e0ba259f01465a83d8db09466dfd46b7ec81)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java
        • (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestConnectionRetryPolicy.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
        • (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestReuseRpcConnections.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10436 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10436/ ) HADOOP-13546 . Override equals and hashCode of the default retry policy (jing9: rev 08d8e0ba259f01465a83d8db09466dfd46b7ec81) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRpcBase.java (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestConnectionRetryPolicy.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestReuseRpcConnections.java
        Hide
        jingzhao Jing Zhao added a comment -

        I've committed the patch to trunk, branch-2 and branch-2.8. Thanks for the contribution Xiaobing Zhou!

        Show
        jingzhao Jing Zhao added a comment - I've committed the patch to trunk, branch-2 and branch-2.8. Thanks for the contribution Xiaobing Zhou !
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for updating the patch, Xiaobing. The 007 patch looks good to me. +1. I will commit the patch early tomorrow if no objections.

        Show
        jingzhao Jing Zhao added a comment - Thanks for updating the patch, Xiaobing. The 007 patch looks good to me. +1. I will commit the patch early tomorrow if no objections.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 7m 9s trunk passed
        +1 compile 7m 3s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 7m 12s the patch passed
        +1 javac 7m 12s the patch passed
        +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 58 unchanged - 5 fixed = 58 total (was 63)
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 29s the patch passed
        +1 javadoc 0m 44s the patch passed
        -1 unit 18m 8s hadoop-common in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        49m 38s



        Reason Tests
        Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13546
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827839/HADOOP-13546-HADOOP-13436.007.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b866cbf6a151 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cba973f
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10474/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10474/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10474/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 9s trunk passed +1 compile 7m 3s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 7m 12s the patch passed +1 javac 7m 12s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 58 unchanged - 5 fixed = 58 total (was 63) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 44s the patch passed -1 unit 18m 8s hadoop-common in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 49m 38s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13546 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827839/HADOOP-13546-HADOOP-13436.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b866cbf6a151 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cba973f Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10474/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10474/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10474/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Jing Zhao for review. v007 is posted to address your comments.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Jing Zhao for review. v007 is posted to address your comments.
        Hide
        jingzhao Jing Zhao added a comment -

        Comments on the latest patch:

        1. TestConnectionRetryPolicy.java does not have ASF license.
        2. The following code can be simplified as "return (obj instanceof WrapperRetryPolicy) && this.multipleLinearRandomRetry.equals(((WrapperRetryPolicy) obj).multipleLinearRandomRetry);"
                } else if (obj == null || obj.getClass() != this.getClass()) {
                  return false;
                } else {
                  return this.multipleLinearRandomRetry
                      .equals(((WrapperRetryPolicy) obj).multipleLinearRandomRetry);
                }
          
        3. The new javadoc is not accurate. To ignore remoteExceptionToRetry is mainly because our motivation for overriding equals and hashCode. The motivation here is for connection reuse, and remoteExceptionToRetry does not affect connection failure handling.
        4. In testDefaultRetryPolicyReuseConnections, we can add another test case to check default retry policy with non-null remoteExceptionToRetry case.
        Show
        jingzhao Jing Zhao added a comment - Comments on the latest patch: TestConnectionRetryPolicy.java does not have ASF license. The following code can be simplified as "return (obj instanceof WrapperRetryPolicy) && this.multipleLinearRandomRetry.equals(((WrapperRetryPolicy) obj).multipleLinearRandomRetry);" } else if (obj == null || obj.getClass() != this .getClass()) { return false ; } else { return this .multipleLinearRandomRetry .equals(((WrapperRetryPolicy) obj).multipleLinearRandomRetry); } The new javadoc is not accurate. To ignore remoteExceptionToRetry is mainly because our motivation for overriding equals and hashCode. The motivation here is for connection reuse, and remoteExceptionToRetry does not affect connection failure handling. In testDefaultRetryPolicyReuseConnections , we can add another test case to check default retry policy with non-null remoteExceptionToRetry case.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 6m 44s trunk passed
        +1 compile 6m 53s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 45s the patch passed
        +1 javac 6m 45s the patch passed
        +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 58 unchanged - 5 fixed = 58 total (was 63)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 44s the patch passed
        +1 unit 8m 54s hadoop-common in the patch passed.
        -1 asflicense 0m 21s The patch generated 1 ASF License warnings.
        39m 7s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13546
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826213/HADOOP-13546-HADOOP-13436.006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5dcdee77a15b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / af50860
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10411/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10411/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10411/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 6m 53s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 45s the patch passed +1 javac 6m 45s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 58 unchanged - 5 fixed = 58 total (was 63) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 8m 54s hadoop-common in the patch passed. -1 asflicense 0m 21s The patch generated 1 ASF License warnings. 39m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13546 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826213/HADOOP-13546-HADOOP-13436.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5dcdee77a15b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / af50860 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10411/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10411/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10411/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        It seems v005 missed some fixes. v006 is posted.

        Show
        xiaobingo Xiaobing Zhou added a comment - It seems v005 missed some fixes. v006 is posted.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 6m 41s trunk passed
        +1 compile 6m 48s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 17s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 6m 43s the patch passed
        +1 javac 6m 43s the patch passed
        -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 7 new + 58 unchanged - 5 fixed = 65 total (was 63)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 35s the patch passed
        +1 javadoc 0m 46s the patch passed
        +1 unit 8m 9s hadoop-common in the patch passed.
        -1 asflicense 0m 21s The patch generated 1 ASF License warnings.
        38m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13546
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826121/HADOOP-13546-HADOOP-13436.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6fddec3fe9e6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cd5e10c
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10408/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10408/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10408/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10408/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 41s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 17s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 6m 43s the patch passed +1 javac 6m 43s the patch passed -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 7 new + 58 unchanged - 5 fixed = 65 total (was 63) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 35s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 8m 9s hadoop-common in the patch passed. -1 asflicense 0m 21s The patch generated 1 ASF License warnings. 38m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13546 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826121/HADOOP-13546-HADOOP-13436.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6fddec3fe9e6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cd5e10c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10408/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10408/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10408/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10408/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        v005 fixed some check style issues.

        Show
        xiaobingo Xiaobing Zhou added a comment - v005 fixed some check style issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 8m 18s trunk passed
        +1 compile 7m 54s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 27s trunk passed
        +1 javadoc 0m 50s trunk passed
        +1 mvninstall 0m 48s the patch passed
        +1 compile 8m 30s the patch passed
        +1 javac 8m 30s the patch passed
        -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 7 new + 58 unchanged - 5 fixed = 65 total (was 63)
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 40s the patch passed
        +1 javadoc 0m 45s the patch passed
        +1 unit 8m 18s hadoop-common in the patch passed.
        -1 asflicense 0m 21s The patch generated 1 ASF License warnings.
        43m 59s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13546
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826105/HADOOP-13546-HADOOP-13436.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 915ba599e6ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 05ede00
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10407/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10407/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10407/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10407/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 18s trunk passed +1 compile 7m 54s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 27s trunk passed +1 javadoc 0m 50s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 8m 30s the patch passed +1 javac 8m 30s the patch passed -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 7 new + 58 unchanged - 5 fixed = 65 total (was 63) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 40s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 18s hadoop-common in the patch passed. -1 asflicense 0m 21s The patch generated 1 ASF License warnings. 43m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13546 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826105/HADOOP-13546-HADOOP-13436.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 915ba599e6ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 05ede00 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10407/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10407/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10407/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10407/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment - - edited

        Thanks Jing Zhao for the reviews. I posted patch v004 addressed all your comments. The unit tests are separated into io.retry and hadoop.ipc packages since tests for reusing connections need access to classes in ipc space. TestReuseRpcConnections extending TestRpcBase makes it easy to setup rpc server.

        Show
        xiaobingo Xiaobing Zhou added a comment - - edited Thanks Jing Zhao for the reviews. I posted patch v004 addressed all your comments. The unit tests are separated into io.retry and hadoop.ipc packages since tests for reusing connections need access to classes in ipc space. TestReuseRpcConnections extending TestRpcBase makes it easy to setup rpc server.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 7s HADOOP-13546 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HADOOP-13546
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826098/HADOOP-13546-HADOOP-13436.004.patch
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10406/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HADOOP-13546 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-13546 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826098/HADOOP-13546-HADOOP-13436.004.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10406/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for the work, Xiaobing. Some comments:

        1. No need to add the new tryOnceThenFail method which is only used by unit tests.
        2. Any reason TestConnectionRetryPolicy needs to extend TestRpcBase?
        3. Looks like this unit test should be moved to o.a.h.io.retry package.
        4. In WrapperRetryPolicy, the semantic of equals and hashCode does not consider remoteExceptionToRetry. Maybe you can add some java comment to explain why.
        5. WrapperRetryPolicy's constructor does not need to be public.
        6. In the following code, let's also check if remoteExceptionToRetry is null.
                } else if (e instanceof RemoteException) {
                  final RemoteException re = (RemoteException)e;
                  p = remoteExceptionToRetry.equals(re.getClassName())?
                      multipleLinearRandomRetry: RetryPolicies.TRY_ONCE_THEN_FAIL;
          
        7. In the unit test, a lot of assertEquals(true/false, x.equals) can be replaced by assertEquals(x, y) or assertNotEquals(x, y).
        8. "testAnonymousRetryPolicy..." should be "testDefaultRetryPolicy..."
        9. We can pass a RetryPolicy[] to verifyRetryPolicyEquivalence and use a simple "for" loop to compare each pair of retry policies.
        10. Let's also add some new unit tests to test cases when we call RetryUtils.getDefaultRetryPolicy but providing different configurations (to enable to disable retry policy) and specifications (of multipleLinearRandomRetry).
        Show
        jingzhao Jing Zhao added a comment - Thanks for the work, Xiaobing. Some comments: No need to add the new tryOnceThenFail method which is only used by unit tests. Any reason TestConnectionRetryPolicy needs to extend TestRpcBase? Looks like this unit test should be moved to o.a.h.io.retry package. In WrapperRetryPolicy, the semantic of equals and hashCode does not consider remoteExceptionToRetry. Maybe you can add some java comment to explain why. WrapperRetryPolicy's constructor does not need to be public. In the following code, let's also check if remoteExceptionToRetry is null. } else if (e instanceof RemoteException) { final RemoteException re = (RemoteException)e; p = remoteExceptionToRetry.equals(re.getClassName())? multipleLinearRandomRetry: RetryPolicies.TRY_ONCE_THEN_FAIL; In the unit test, a lot of assertEquals(true/false, x.equals ) can be replaced by assertEquals(x, y) or assertNotEquals(x, y). "testAnonymousRetryPolicy..." should be "testDefaultRetryPolicy..." We can pass a RetryPolicy[] to verifyRetryPolicyEquivalence and use a simple "for" loop to compare each pair of retry policies. Let's also add some new unit tests to test cases when we call RetryUtils.getDefaultRetryPolicy but providing different configurations (to enable to disable retry policy) and specifications (of multipleLinearRandomRetry).
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        The test failure is not related to the patch. It's been reported in HADOOP-13375.

        Show
        xiaobingo Xiaobing Zhou added a comment - The test failure is not related to the patch. It's been reported in HADOOP-13375 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 39s trunk passed
        +1 compile 6m 46s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 8m 2s the patch passed
        +1 javac 8m 2s the patch passed
        +1 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 0 new + 58 unchanged - 5 fixed = 58 total (was 63)
        +1 mvnsite 0m 59s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 43s the patch passed
        +1 javadoc 0m 49s the patch passed
        -1 unit 8m 42s hadoop-common in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        40m 33s



        Reason Tests
        Failed junit tests hadoop.security.TestGroupsCaching



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13546
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825701/HADOOP-13546-HADOOP-13436.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux db1d75895b65 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cde3a00
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10384/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10384/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 39s trunk passed +1 compile 6m 46s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 8m 2s the patch passed +1 javac 8m 2s the patch passed +1 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 0 new + 58 unchanged - 5 fixed = 58 total (was 63) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 43s the patch passed +1 javadoc 0m 49s the patch passed -1 unit 8m 42s hadoop-common in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 40m 33s Reason Tests Failed junit tests hadoop.security.TestGroupsCaching Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13546 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825701/HADOOP-13546-HADOOP-13436.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux db1d75895b65 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cde3a00 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10384/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10384/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10384/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        v003 fixed the check style issue.

        Show
        xiaobingo Xiaobing Zhou added a comment - v003 fixed the check style issue.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 56s trunk passed
        +1 compile 7m 11s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 52s the patch passed
        +1 javac 6m 52s the patch passed
        -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 1 new + 58 unchanged - 5 fixed = 59 total (was 63)
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 26s the patch passed
        +1 javadoc 0m 45s the patch passed
        +1 unit 8m 11s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        39m 13s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13546
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825557/HADOOP-13546-HADOOP-13436.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5e3eff86100b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 81485db
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10377/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10377/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10377/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 56s trunk passed +1 compile 7m 11s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 52s the patch passed +1 javac 6m 52s the patch passed -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 1 new + 58 unchanged - 5 fixed = 59 total (was 63) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 11s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 39m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13546 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825557/HADOOP-13546-HADOOP-13436.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5e3eff86100b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 81485db Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10377/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10377/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10377/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        v002 is posted. It consolidates changes of TryOnceThenFail and anonymous RetryPolicy to one patch and also simplifies equals as suggested. Thank you Jing Zhao for comments.

        Show
        xiaobingo Xiaobing Zhou added a comment - v002 is posted. It consolidates changes of TryOnceThenFail and anonymous RetryPolicy to one patch and also simplifies equals as suggested. Thank you Jing Zhao for comments.
        Hide
        jingzhao Jing Zhao added a comment -

        Since for 2.x we only need to fix 2 retry policies, maybe we can finish the work in one jira?

        For the current patch, the following code can be further simplified:

        196	    public boolean equals(Object obj) {
        197	      if (obj == null) {
        198	        return false;
        199	      }
        200	
        201	      if (obj == this) {
        202	        return true;
        203	      }
        204	
        205	      if (obj.getClass() == this.getClass()) {
        206	        return true;
        207	      }
        208	
        209	      return false;
        210	    }
        
        Show
        jingzhao Jing Zhao added a comment - Since for 2.x we only need to fix 2 retry policies, maybe we can finish the work in one jira? For the current patch, the following code can be further simplified: 196 public boolean equals( Object obj) { 197 if (obj == null ) { 198 return false ; 199 } 200 201 if (obj == this ) { 202 return true ; 203 } 204 205 if (obj.getClass() == this .getClass()) { 206 return true ; 207 } 208 209 return false ; 210 }
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 9s trunk passed
        +1 compile 7m 10s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 45s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 55s the patch passed
        +1 javac 6m 55s the patch passed
        +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 54 unchanged - 4 fixed = 54 total (was 58)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 45s the patch passed
        +1 unit 8m 12s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        39m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825373/HADOOP-13546-HADOOP-13436.001.patch
        JIRA Issue HADOOP-13546
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9bbae62f7903 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a1f3293
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10363/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10363/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 9s trunk passed +1 compile 7m 10s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 55s the patch passed +1 javac 6m 55s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 54 unchanged - 4 fixed = 54 total (was 58) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 12s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 39m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825373/HADOOP-13546-HADOOP-13436.001.patch JIRA Issue HADOOP-13546 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9bbae62f7903 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a1f3293 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10363/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10363/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        v001 fixed some comments.

        Show
        xiaobingo Xiaobing Zhou added a comment - v001 fixed some comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 12s trunk passed
        +1 compile 7m 3s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 45s trunk passed
        -1 mvninstall 0m 35s hadoop-common in the patch failed.
        -1 compile 0m 47s root in the patch failed.
        -1 javac 0m 47s root in the patch failed.
        -0 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 3 new + 54 unchanged - 4 fixed = 57 total (was 58)
        -1 mvnsite 0m 32s hadoop-common in the patch failed.
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 24s hadoop-common in the patch failed.
        +1 javadoc 0m 44s the patch passed
        -1 unit 0m 41s hadoop-common in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        23m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825357/HADOOP-13546-HADOOP-13436.000.patch
        JIRA Issue HADOOP-13546
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2e074bc1da34 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a1f3293
        Default Java 1.8.0_101
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-compile-root.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-compile-root.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 12s trunk passed +1 compile 7m 3s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 45s trunk passed -1 mvninstall 0m 35s hadoop-common in the patch failed. -1 compile 0m 47s root in the patch failed. -1 javac 0m 47s root in the patch failed. -0 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 3 new + 54 unchanged - 4 fixed = 57 total (was 58) -1 mvnsite 0m 32s hadoop-common in the patch failed. +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 24s hadoop-common in the patch failed. +1 javadoc 0m 44s the patch passed -1 unit 0m 41s hadoop-common in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 23m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825357/HADOOP-13546-HADOOP-13436.000.patch JIRA Issue HADOOP-13546 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2e074bc1da34 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a1f3293 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10362/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment - - edited

        I posted initial patch v000. This should target 2.x. Please kindly review it, thanks.

        Show
        xiaobingo Xiaobing Zhou added a comment - - edited I posted initial patch v000. This should target 2.x. Please kindly review it, thanks.

          People

          • Assignee:
            xiaobingo Xiaobing Zhou
            Reporter:
            xiaobingo Xiaobing Zhou
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development