Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13538

Deprecate getInstance and initialize methods with Path in TrashPolicy

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.8.0, 3.0.0-alpha1
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          As HADOOP-13534 memtioned, the getInstance and initiate APIs with Path is not used anymore. We should deprecate these methods before removing them.

          1. Text File
            HADOOP-13538.001.patch
            2 kB
            Yiqun Lin
          2. Text File
            HADOOP-13538.002.patch
            2 kB
            Yiqun Lin

            Issue Links

            is related to

            Improvement - An improvement or enhancement to an existing feature or task. HADOOP-13534 Remove unused TrashPolicy#getInstance and initialize code

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              linyiqun Yiqun Lin added a comment - - edited

              Attach a simple patch for this. Since I am not a contributor for HADOOP-COMMON, I can't assign this jira to me.

              Show
              linyiqun Yiqun Lin added a comment - - edited Attach a simple patch for this. Since I am not a contributor for HADOOP-COMMON, I can't assign this jira to me.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 15s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 mvninstall 7m 7s trunk passed
              +1 compile 7m 10s trunk passed
              +1 checkstyle 0m 24s trunk passed
              +1 mvnsite 0m 56s trunk passed
              +1 mvneclipse 0m 12s trunk passed
              +1 findbugs 1m 22s trunk passed
              +1 javadoc 0m 45s trunk passed
              +1 mvninstall 0m 40s the patch passed
              +1 compile 7m 7s the patch passed
              -1 javac 7m 7s root generated 1 new + 710 unchanged - 0 fixed = 711 total (was 710)
              +1 checkstyle 0m 23s the patch passed
              +1 mvnsite 0m 55s the patch passed
              +1 mvneclipse 0m 13s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 34s the patch passed
              +1 javadoc 0m 46s the patch passed
              -1 unit 17m 5s hadoop-common in the patch failed.
              +1 asflicense 0m 20s The patch does not generate ASF License warnings.
              48m 44s



              Reason Tests
              Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825165/HADOOP-13538.001.patch
              JIRA Issue HADOOP-13538
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux 13eaad5b3849 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / c37346d
              Default Java 1.8.0_101
              findbugs v3.0.0
              javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10349/artifact/patchprocess/diff-compile-javac-root.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10349/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10349/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10349/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 7s trunk passed +1 compile 7m 10s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 7m 7s the patch passed -1 javac 7m 7s root generated 1 new + 710 unchanged - 0 fixed = 711 total (was 710) +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 34s the patch passed +1 javadoc 0m 46s the patch passed -1 unit 17m 5s hadoop-common in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 48m 44s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825165/HADOOP-13538.001.patch JIRA Issue HADOOP-13538 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 13eaad5b3849 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c37346d Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10349/artifact/patchprocess/diff-compile-javac-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10349/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10349/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10349/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              ajisakaa Akira Ajisaka added a comment -

              +1, thanks Yiqun.

              Show
              ajisakaa Akira Ajisaka added a comment - +1, thanks Yiqun.
              Hide
              Permalink
              ajisakaa Akira Ajisaka added a comment -

              Cancelling my +1. Would you update the javadoc to document the alternative as follows?

                 * @deprecated Use {@link #initialize(Configuration, FileSystem)} instead.
              Show
              ajisakaa Akira Ajisaka added a comment - Cancelling my +1. Would you update the javadoc to document the alternative as follows? * @deprecated Use {@link #initialize(Configuration, FileSystem)} instead.
              Hide
              Permalink
              linyiqun Yiqun Lin added a comment -

              Thanks Akira Ajisaka for the review. Attach a new patch to make this change.

              Show
              linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the review. Attach a new patch to make this change.
              Hide
              Permalink
              ajisakaa Akira Ajisaka added a comment -

              Would you update the javadoc in getInstance and TrasnPolicyDefault#initialize as well?

              Show
              ajisakaa Akira Ajisaka added a comment - Would you update the javadoc in getInstance and TrasnPolicyDefault#initialize as well?
              Hide
              Permalink
              linyiqun Yiqun Lin added a comment -

              Sorry, I missed for that, upload the v002 patch again.

              Show
              linyiqun Yiqun Lin added a comment - Sorry, I missed for that, upload the v002 patch again.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 20s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 mvninstall 8m 3s trunk passed
              +1 compile 7m 25s trunk passed
              +1 checkstyle 0m 23s trunk passed
              +1 mvnsite 0m 54s trunk passed
              +1 mvneclipse 0m 12s trunk passed
              +1 findbugs 1m 18s trunk passed
              +1 javadoc 0m 45s trunk passed
              +1 mvninstall 0m 38s the patch passed
              +1 compile 8m 21s the patch passed
              -1 javac 8m 21s root generated 1 new + 710 unchanged - 0 fixed = 711 total (was 710)
              +1 checkstyle 0m 25s the patch passed
              +1 mvnsite 1m 2s the patch passed
              +1 mvneclipse 0m 13s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 51s the patch passed
              +1 javadoc 0m 51s the patch passed
              -1 unit 8m 41s hadoop-common in the patch failed.
              +1 asflicense 0m 21s The patch does not generate ASF License warnings.
              43m 9s



              Reason Tests
              Failed junit tests hadoop.net.TestDNS



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825197/HADOOP-13538.002.patch
              JIRA Issue HADOOP-13538
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux 141d1c0b80a7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / c37346d
              Default Java 1.8.0_101
              findbugs v3.0.0
              javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10352/artifact/patchprocess/diff-compile-javac-root.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10352/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10352/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10352/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 3s trunk passed +1 compile 7m 25s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 8m 21s the patch passed -1 javac 8m 21s root generated 1 new + 710 unchanged - 0 fixed = 711 total (was 710) +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 51s the patch passed -1 unit 8m 41s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 43m 9s Reason Tests Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825197/HADOOP-13538.002.patch JIRA Issue HADOOP-13538 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 141d1c0b80a7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c37346d Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10352/artifact/patchprocess/diff-compile-javac-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10352/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10352/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10352/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 17s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 mvninstall 8m 15s trunk passed
              +1 compile 8m 16s trunk passed
              +1 checkstyle 0m 25s trunk passed
              +1 mvnsite 1m 0s trunk passed
              +1 mvneclipse 0m 14s trunk passed
              +1 findbugs 1m 33s trunk passed
              +1 javadoc 0m 53s trunk passed
              +1 mvninstall 0m 38s the patch passed
              +1 compile 6m 49s the patch passed
              -1 javac 6m 49s root generated 1 new + 710 unchanged - 0 fixed = 711 total (was 710)
              +1 checkstyle 0m 23s the patch passed
              +1 mvnsite 0m 51s the patch passed
              +1 mvneclipse 0m 13s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 25s the patch passed
              +1 javadoc 0m 45s the patch passed
              +1 unit 8m 29s hadoop-common in the patch passed.
              +1 asflicense 0m 23s The patch does not generate ASF License warnings.
              42m 15s



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825201/HADOOP-13538.002.patch
              JIRA Issue HADOOP-13538
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux 805a0b5c3046 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / c37346d
              Default Java 1.8.0_101
              findbugs v3.0.0
              javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10354/artifact/patchprocess/diff-compile-javac-root.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10354/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10354/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 15s trunk passed +1 compile 8m 16s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 53s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 6m 49s the patch passed -1 javac 6m 49s root generated 1 new + 710 unchanged - 0 fixed = 711 total (was 710) +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 29s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 42m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825201/HADOOP-13538.002.patch JIRA Issue HADOOP-13538 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 805a0b5c3046 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c37346d Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10354/artifact/patchprocess/diff-compile-javac-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10354/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10354/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              ajisakaa Akira Ajisaka added a comment -

              +1, checking this in.

              Show
              ajisakaa Akira Ajisaka added a comment - +1, checking this in.
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10333 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10333/)
              HADOOP-13538. Deprecate getInstance and initialize methods with Path in (aajisaka: rev 092b4d5bfd02131d62723fc5673892305eb9fcef)

              • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicy.java
              • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10333 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10333/ ) HADOOP-13538 . Deprecate getInstance and initialize methods with Path in (aajisaka: rev 092b4d5bfd02131d62723fc5673892305eb9fcef) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicy.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
              Hide
              Permalink
              ajisakaa Akira Ajisaka added a comment -

              Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution.
              Now we cannot add a contributor to the contributor role because we have hit the limit. Sorry for that.

              Show
              ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution. Now we cannot add a contributor to the contributor role because we have hit the limit. Sorry for that.

                People

                • Assignee:
                  linyiqun Yiqun Lin
                  Reporter:
                  linyiqun Yiqun Lin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development