Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13526

Add detailed logging in KMS for the authentication failure of proxy user

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: kms
    • Labels:
      None
    • Environment:

      RHEL

    • Hadoop Flags:
      Reviewed

      Description

      Problem :
      User A was not able to write a file to HDFS Encryption Zone. It was resolved by adding proxy user A in kms-site.xml
      However, the logs showed :

      2016-08-10 19:32:08,954 DEBUG org.apache.hadoop.security.authentication.server.AuthenticationFilter: Request https://vm.example.com:16000/kms/v1/keyversion/aMxsSSKmMEzINTIrKURpFJgHnZxiOvsT9L1nMpbUoGu/_eek?eek_op=decrypt&doAs=userb&user.name=usera user [usera] authenticated

      Possible Solution :
      So the message which says the user was successfully authenticated comes from AuthenticationFilter.java. However, when the filter on DelegationTokenAuthenticationFilter is called it hits an exception there and there is no log message there. This leads to the confusion that we have had a success while the exception happens in the next class.

      1. HADOOP-13526.patch.3
        2 kB
        Suraj Acharya
      2. HADOOP-13526.patch.2
        2 kB
        Suraj Acharya
      3. HADOOP-13526.patch.1
        2 kB
        Suraj Acharya
      4. HADOOP-13526.patch
        2 kB
        Suraj Acharya

        Activity

        Hide
        sacharya Suraj Acharya added a comment -
        Show
        sacharya Suraj Acharya added a comment - Xiao Chen and Anu Engineer thanks
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10322 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10322/)
        HADOOP-13526. Add detailed logging in KMS for the authentication failure (xiao: rev 4070caad70db49b50554088d29ac2fbc7ba62a0a)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/DelegationTokenAuthenticationFilter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10322 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10322/ ) HADOOP-13526 . Add detailed logging in KMS for the authentication failure (xiao: rev 4070caad70db49b50554088d29ac2fbc7ba62a0a) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/DelegationTokenAuthenticationFilter.java
        Hide
        xiaochen Xiao Chen added a comment -

        I have committed this to trunk and branch-2.

        Thank you Suraj Acharya for the contribution, and Anu Engineer for the review!

        Show
        xiaochen Xiao Chen added a comment - I have committed this to trunk and branch-2. Thank you Suraj Acharya for the contribution, and Anu Engineer for the review!
        Hide
        anu Anu Engineer added a comment -

        +1, on patch 3. Thanks for the patch Suraj Acharya. Thanks for committing this Xiao Chen

        Show
        anu Anu Engineer added a comment - +1, on patch 3. Thanks for the patch Suraj Acharya . Thanks for committing this Xiao Chen
        Hide
        xiaochen Xiao Chen added a comment -

        +1 on patch 3, will commit later today if no objections.

        Show
        xiaochen Xiao Chen added a comment - +1 on patch 3, will commit later today if no objections.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 38s trunk passed
        +1 compile 6m 48s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 42s the patch passed
        +1 javac 6m 42s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 44s the patch passed
        +1 unit 9m 10s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        39m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824940/HADOOP-13526.patch.3
        JIRA Issue HADOOP-13526
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 519b9b3c4258 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3ca4d6d
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10339/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10339/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. 0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 38s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 42s the patch passed +1 javac 6m 42s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 9m 10s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 39m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824940/HADOOP-13526.patch.3 JIRA Issue HADOOP-13526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 519b9b3c4258 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3ca4d6d Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10339/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10339/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sacharya Suraj Acharya added a comment -

        Fixed Checkstyle of '('

        Show
        sacharya Suraj Acharya added a comment - Fixed Checkstyle of '('
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 49s trunk passed
        +1 compile 6m 48s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 17s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 47s the patch passed
        +1 javac 6m 47s the patch passed
        -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 45s the patch passed
        +1 unit 7m 49s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        37m 57s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824931/HADOOP-13526.patch.2
        JIRA Issue HADOOP-13526
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 31adeffe46b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3ca4d6d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10338/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10338/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10338/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 49s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 17s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 47s the patch passed +1 javac 6m 47s the patch passed -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 7m 49s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 37m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824931/HADOOP-13526.patch.2 JIRA Issue HADOOP-13526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 31adeffe46b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3ca4d6d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10338/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10338/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10338/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 38s trunk passed
        +1 compile 6m 55s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 26s trunk passed
        +1 javadoc 0m 47s trunk passed
        +1 mvninstall 0m 42s the patch passed
        +1 compile 7m 34s the patch passed
        +1 javac 7m 34s the patch passed
        -0 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 37s the patch passed
        +1 javadoc 0m 48s the patch passed
        +1 unit 8m 46s hadoop-common in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        40m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824928/HADOOP-13526.patch.1
        JIRA Issue HADOOP-13526
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 482a9efd1fce 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 22fc46d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10337/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10337/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10337/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 38s trunk passed +1 compile 6m 55s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 26s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 7m 34s the patch passed +1 javac 7m 34s the patch passed -0 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 37s the patch passed +1 javadoc 0m 48s the patch passed +1 unit 8m 46s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 40m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824928/HADOOP-13526.patch.1 JIRA Issue HADOOP-13526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 482a9efd1fce 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22fc46d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10337/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10337/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10337/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sacharya Suraj Acharya added a comment -

        Anu Engineer and Xiao Chen
        Done
        Sorry about it.

        Show
        sacharya Suraj Acharya added a comment - Anu Engineer and Xiao Chen Done Sorry about it.
        Hide
        anu Anu Engineer added a comment -

        There is one more checkstyle warning about line length being more than 80. Could you please fix that too ? +1 after that.

        Show
        anu Anu Engineer added a comment - There is one more checkstyle warning about line length being more than 80. Could you please fix that too ? +1 after that.
        Hide
        xiaochen Xiao Chen added a comment -

        Hi Suraj,

        Sorry for not being clear. The checksyle output also alerts about the line length, could you fix that so we have a green pre-commit?
        Thank you.

        Show
        xiaochen Xiao Chen added a comment - Hi Suraj, Sorry for not being clear. The checksyle output also alerts about the line length, could you fix that so we have a green pre-commit? Thank you.
        Hide
        sacharya Suraj Acharya added a comment -

        I fixed it by declaring it as final as Xiao Chen mentioned.

        Show
        sacharya Suraj Acharya added a comment - I fixed it by declaring it as final as Xiao Chen mentioned.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Suraj Acharya for reporting and fixing the issue, and Anu Engineer for reviewing. I agree current patch is more consistent with the existing code, and no test is needed.

        Could you fix the checkstyle? For the naming, you can declare LOG as final to make checkstyle happy. (Credit to Andrew Wang for the tip!). +1 pending that.

        Show
        xiaochen Xiao Chen added a comment - Thanks Suraj Acharya for reporting and fixing the issue, and Anu Engineer for reviewing. I agree current patch is more consistent with the existing code, and no test is needed. Could you fix the checkstyle? For the naming, you can declare LOG as final to make checkstyle happy. (Credit to Andrew Wang for the tip!). +1 pending that.
        Hide
        anu Anu Engineer added a comment -

        Suraj Acharya Thanks for the explanation. That makes sense. Let us leave the code as you proposed. Would you please fix these 2 checkstyle warnings, once they are fixed I think we can commit this. Here is the checkstyle warnings URL https://builds.apache.org/job/PreCommit-HADOOP-Build/10328/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt

        Show
        anu Anu Engineer added a comment - Suraj Acharya Thanks for the explanation. That makes sense. Let us leave the code as you proposed. Would you please fix these 2 checkstyle warnings, once they are fixed I think we can commit this. Here is the checkstyle warnings URL https://builds.apache.org/job/PreCommit-HADOOP-Build/10328/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Hide
        sacharya Suraj Acharya added a comment -

        @anu i tried to emulate the model present in AuthenticationFilter.java.
        Here we can see that the debug level prints to Warn. I was not sure but I maintained the consistency so that the user is not confused in the behaviour pattern.

        Show
        sacharya Suraj Acharya added a comment - @anu i tried to emulate the model present in AuthenticationFilter.java . Here we can see that the debug level prints to Warn. I was not sure but I maintained the consistency so that the user is not confused in the behaviour pattern.
        Hide
        anu Anu Engineer added a comment -

        Suraj Acharya Thanks for catching this and fix it. The patch looks good. One small q. should we change the level of the log based on if we have debugging turned on or not ? it looks like if we have Log level DEBUG turned on the failure will be logged at DEBUG level instead of a WARN ( I do see we log details of the failure with this debug statement). Should we log at the same WARN level even if we have debug turned on, but with the details of the exception ?

        Show
        anu Anu Engineer added a comment - Suraj Acharya Thanks for catching this and fix it. The patch looks good. One small q. should we change the level of the log based on if we have debugging turned on or not ? it looks like if we have Log level DEBUG turned on the failure will be logged at DEBUG level instead of a WARN ( I do see we log details of the failure with this debug statement). Should we log at the same WARN level even if we have debug turned on, but with the details of the exception ?
        Hide
        sacharya Suraj Acharya added a comment -

        No tests have been added since it is an improvement to log.

        Show
        sacharya Suraj Acharya added a comment - No tests have been added since it is an improvement to log.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 48s trunk passed
        +1 compile 6m 44s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 19s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 39s the patch passed
        +1 javac 6m 39s the patch passed
        -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 2 new + 5 unchanged - 0 fixed = 7 total (was 5)
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 44s the patch passed
        +1 unit 8m 3s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        38m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824755/HADOOP-13526.patch
        JIRA Issue HADOOP-13526
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 71d7ce801e47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 115ecb5
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10328/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10328/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10328/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 48s trunk passed +1 compile 6m 44s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 39s the patch passed +1 javac 6m 39s the patch passed -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 2 new + 5 unchanged - 0 fixed = 7 total (was 5) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 8m 3s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824755/HADOOP-13526.patch JIRA Issue HADOOP-13526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 71d7ce801e47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 115ecb5 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10328/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10328/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10328/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            sacharya Suraj Acharya
            Reporter:
            sacharya Suraj Acharya
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development