Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13522

Add %A and %a formats for fs -stat command to print permissions

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Added permissions to the fs stat command. They are now available as symbolic (%A) and octal (%a) formats, which are in line with Linux.

      Description

      This patch adds to fs/shell/Stat.java the missing options of %a and %A.

      FileStatus already contains the getPermission() method required for returning symbolic permissions. FsPermission contains the method to return the binary short, but nothing to present in standard Octal format.

      Most UNIX admins base their work on such standard octal permissions. Hence, this patch also introduces one tiny method to translate the toShort() return into octal.

      Build has already passed unit tests and javadoc.

      1. HADOOP-13522.001.patch
        4 kB
        Alex Garbarini
      2. HADOOP-13522.002.patch
        4 kB
        Alex Garbarini
      3. HADOOP-13522.003.patch
        4 kB
        Alex Garbarini
      4. HADOOP-13522.004.patch
        5 kB
        Alex Garbarini
      5. HADOOP-13522.005.patch
        15 kB
        Alex Garbarini
      6. HADOOP-13522.006.patch
        6 kB
        Alex Garbarini
      7. HADOOP-13522.007.patch
        7 kB
        Alex Garbarini
      8. HADOOP-13522.008.patch
        7 kB
        Alex Garbarini

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 7m 0s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 20s trunk passed
          +1 javadoc 0m 46s trunk passed
          +1 mvninstall 0m 38s the patch passed
          +1 compile 7m 1s the patch passed
          +1 javac 7m 1s the patch passed
          -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 14 new + 59 unchanged - 1 fixed = 73 total (was 60)
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          -1 whitespace 0m 0s The patch 5 line(s) with tabs.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 28s the patch passed
          +1 javadoc 0m 46s the patch passed
          -1 unit 17m 2s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          48m 4s



          Reason Tests
          Failed junit tests hadoop.net.TestClusterTopology
            hadoop.net.TestDNS
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13522
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830230/HADOOP-13522.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 57b397b411f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5707f88
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 7m 0s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 7m 1s the patch passed +1 javac 7m 1s the patch passed -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 14 new + 59 unchanged - 1 fixed = 73 total (was 60) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch 5 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 28s the patch passed +1 javadoc 0m 46s the patch passed -1 unit 17m 2s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 48m 4s Reason Tests Failed junit tests hadoop.net.TestClusterTopology   hadoop.net.TestDNS Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13522 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830230/HADOOP-13522.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 57b397b411f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5707f88 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10590/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          algarbar Alex Garbarini added a comment -

          Replaced Tabs with Spaces, Fixed Javadoc missing a period, and moved octal definition to one line.

          Show
          algarbar Alex Garbarini added a comment - Replaced Tabs with Spaces, Fixed Javadoc missing a period, and moved octal definition to one line.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 3s trunk passed
          +1 compile 6m 55s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 0m 44s trunk passed
          -1 mvninstall 0m 11s hadoop-common in the patch failed.
          -1 compile 0m 22s root in the patch failed.
          -1 javac 0m 22s root in the patch failed.
          -0 checkstyle 0m 20s hadoop-common-project/hadoop-common: The patch generated 9 new + 41 unchanged - 19 fixed = 50 total (was 60)
          -1 mvnsite 0m 12s hadoop-common in the patch failed.
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          -1 findbugs 0m 11s hadoop-common in the patch failed.
          -1 javadoc 0m 10s hadoop-common in the patch failed.
          -1 unit 0m 11s hadoop-common in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          21m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13522
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830237/HADOOP-13522.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux ebf13327a98f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5707f88
          Default Java 1.8.0_101
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-compile-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 3s trunk passed +1 compile 6m 55s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 44s trunk passed -1 mvninstall 0m 11s hadoop-common in the patch failed. -1 compile 0m 22s root in the patch failed. -1 javac 0m 22s root in the patch failed. -0 checkstyle 0m 20s hadoop-common-project/hadoop-common: The patch generated 9 new + 41 unchanged - 19 fixed = 50 total (was 60) -1 mvnsite 0m 12s hadoop-common in the patch failed. +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. -1 findbugs 0m 11s hadoop-common in the patch failed. -1 javadoc 0m 10s hadoop-common in the patch failed. -1 unit 0m 11s hadoop-common in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 21m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13522 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830237/HADOOP-13522.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux ebf13327a98f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5707f88 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10591/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Mostly looks good to me.

          • Would you add test case?
          • Would you update the document? (hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md)
          Show
          ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. Would you add test case? Would you update the document? (hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md)
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Fix Version/s is set when the patch is committed. Removing it.

          Show
          ajisakaa Akira Ajisaka added a comment - Fix Version/s is set when the patch is committed. Removing it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 26s trunk passed
          +1 compile 7m 52s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 2s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 27s trunk passed
          +1 javadoc 0m 47s trunk passed
          +1 mvninstall 0m 43s the patch passed
          +1 compile 7m 58s the patch passed
          +1 javac 7m 58s the patch passed
          -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 9 new + 59 unchanged - 1 fixed = 68 total (was 60)
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 39s the patch passed
          +1 javadoc 0m 48s the patch passed
          -1 unit 17m 18s hadoop-common in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          51m 34s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13522
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830238/HADOOP-13522.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 174642182bb1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5707f88
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10592/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10592/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10592/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10592/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 26s trunk passed +1 compile 7m 52s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 27s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 43s the patch passed +1 compile 7m 58s the patch passed +1 javac 7m 58s the patch passed -0 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 9 new + 59 unchanged - 1 fixed = 68 total (was 60) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 39s the patch passed +1 javadoc 0m 48s the patch passed -1 unit 17m 18s hadoop-common in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 51m 34s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13522 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830238/HADOOP-13522.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 174642182bb1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5707f88 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10592/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10592/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10592/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10592/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          algarbar Alex Garbarini added a comment -

          Thank you, Akira, for reviewing the patch. Update to FileSystemShell.md is now applied. I am still learning to create and apply new Hadoop test cases. Would you be willing to submit any new, required case?

          Show
          algarbar Alex Garbarini added a comment - Thank you, Akira, for reviewing the patch. Update to FileSystemShell.md is now applied. I am still learning to create and apply new Hadoop test cases. Would you be willing to submit any new, required case?
          Hide
          algarbar Alex Garbarini added a comment -

          Update to: hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md

          Show
          algarbar Alex Garbarini added a comment - Update to: hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 56s trunk passed
          +1 compile 7m 3s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 51s the patch passed
          +1 javac 6m 51s the patch passed
          -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 9 new + 59 unchanged - 1 fixed = 68 total (was 60)
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 8m 9s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          38m 56s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13522
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830240/HADOOP-13522.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux d3775b127c00 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5707f88
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10593/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10593/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10593/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 56s trunk passed +1 compile 7m 3s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 51s the patch passed +1 javac 6m 51s the patch passed -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 9 new + 59 unchanged - 1 fixed = 68 total (was 60) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 9s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13522 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830240/HADOOP-13522.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux d3775b127c00 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5707f88 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10593/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10593/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10593/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for updating the patch!

          Would you be willing to submit any new, required case?

          I want you to submit some test cases, but if you don't want to work for creating tests or don't have time to do this, I'm willing to take it over.

          I searched existing test cases but unfortunately there is no test case for fs -stat command. Therefore I'm thinking we need to create a new test class in hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell. In the class, we execute all the options of fs -stat command and verify the output. We can re-use the other test classes in the directory as reference. Let me know if you need any help.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for updating the patch! Would you be willing to submit any new, required case? I want you to submit some test cases, but if you don't want to work for creating tests or don't have time to do this, I'm willing to take it over. I searched existing test cases but unfortunately there is no test case for fs -stat command. Therefore I'm thinking we need to create a new test class in hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell . In the class, we execute all the options of fs -stat command and verify the output. We can re-use the other test classes in the directory as reference. Let me know if you need any help.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I searched existing test cases but unfortunately there is no test case for fs -stat command.

          There is a patch in HDFS-10892. I'll review this shortly.

          Show
          ajisakaa Akira Ajisaka added a comment - I searched existing test cases but unfortunately there is no test case for fs -stat command. There is a patch in HDFS-10892 . I'll review this shortly.
          Hide
          algarbar Alex Garbarini added a comment -

          Added test case from HDFS-10892. Modified to include FsPermission Test. Re-ran build and test cases with success.

          Show
          algarbar Alex Garbarini added a comment - Added test case from HDFS-10892 . Modified to include FsPermission Test. Re-ran build and test cases with success.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-13522 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-13522
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830919/HADOOP-13522.005.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10630/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-13522 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-13522 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830919/HADOOP-13522.005.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10630/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment - - edited

          Thank you Alex Garbarini for updating the patch! Now HDFS-10892 is committed, so would you rebase the patch for the latest trunk?

          Show
          ajisakaa Akira Ajisaka added a comment - - edited Thank you Alex Garbarini for updating the patch! Now HDFS-10892 is committed, so would you rebase the patch for the latest trunk?
          Hide
          algarbar Alex Garbarini added a comment -

          Rebased the patch for the latest trunk.

          Show
          algarbar Alex Garbarini added a comment - Rebased the patch for the latest trunk.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 7m 19s trunk passed
          +1 compile 7m 31s trunk passed
          +1 checkstyle 1m 32s trunk passed
          +1 mvnsite 1m 57s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 30s trunk passed
          +1 javadoc 2m 9s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 1m 52s the patch passed
          +1 compile 8m 50s the patch passed
          +1 javac 8m 50s the patch passed
          -0 checkstyle 1m 54s root: The patch generated 10 new + 238 unchanged - 1 fixed = 248 total (was 239)
          +1 mvnsite 2m 19s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 findbugs 4m 10s the patch passed
          +1 javadoc 2m 17s the patch passed
          -1 unit 8m 5s hadoop-common in the patch failed.
          -1 unit 79m 22s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          158m 58s



          Reason Tests
          Failed junit tests hadoop.ipc.TestIPC
            hadoop.hdfs.TestErasureCodeBenchmarkThroughput



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13522
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831607/HADOOP-13522.006.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 79f9577e68d9 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 44f48ee
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 7m 19s trunk passed +1 compile 7m 31s trunk passed +1 checkstyle 1m 32s trunk passed +1 mvnsite 1m 57s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 30s trunk passed +1 javadoc 2m 9s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 52s the patch passed +1 compile 8m 50s the patch passed +1 javac 8m 50s the patch passed -0 checkstyle 1m 54s root: The patch generated 10 new + 238 unchanged - 1 fixed = 248 total (was 239) +1 mvnsite 2m 19s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 4m 10s the patch passed +1 javadoc 2m 17s the patch passed -1 unit 8m 5s hadoop-common in the patch failed. -1 unit 79m 22s hadoop-hdfs in the patch failed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 158m 58s Reason Tests Failed junit tests hadoop.ipc.TestIPC   hadoop.hdfs.TestErasureCodeBenchmarkThroughput Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13522 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831607/HADOOP-13522.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 79f9577e68d9 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 44f48ee Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10663/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for updating the patch, Alex Garbarini.
          1. Would you render the lines within 80 characters?

          FsPermission.java
              int octal = (n >>> 9 & 1)*1000 + (n >>> 6 & 7)*100 + (n >>> 3 & 7)*10 + (n & 7);
          
          TestDFSShell.java
                assertTrue(out.toString(), out.toString().contains(status1.getPermission().toString()));
          

          2. Would you add an assertion for %a option?

                assertTrue(out.toString(), out.toString().contains(
                    Short.toString(status1.getPermission().toShort())));
          

          3. Would you add assertions for testFile2 as well?

          (You don't need to set the assignee to me. In this project, assignee is a developer who creates a patch.)

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for updating the patch, Alex Garbarini . 1. Would you render the lines within 80 characters? FsPermission.java int octal = (n >>> 9 & 1)*1000 + (n >>> 6 & 7)*100 + (n >>> 3 & 7)*10 + (n & 7); TestDFSShell.java assertTrue(out.toString(), out.toString().contains(status1.getPermission().toString())); 2. Would you add an assertion for %a option? assertTrue(out.toString(), out.toString().contains( Short .toString(status1.getPermission().toShort()))); 3. Would you add assertions for testFile2 as well? (You don't need to set the assignee to me. In this project, assignee is a developer who creates a patch.)
          Hide
          algarbar Alex Garbarini added a comment -

          Thank you Akira Ajisaka for all your help! I have made the requested revisions. Though, the toShort again needs to be converted to octal. So I'm not sure if it's an effective test. I can later expand the test case to include a match check against every permutation of possible values.

          Reran the build and the single test case.

          Show
          algarbar Alex Garbarini added a comment - Thank you Akira Ajisaka for all your help! I have made the requested revisions. Though, the toShort again needs to be converted to octal. So I'm not sure if it's an effective test. I can later expand the test case to include a match check against every permutation of possible values. Reran the build and the single test case.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 41s Maven dependency ordering for branch
          +1 mvninstall 8m 28s trunk passed
          +1 compile 8m 16s trunk passed
          +1 checkstyle 1m 35s trunk passed
          +1 mvnsite 1m 59s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 3m 33s trunk passed
          +1 javadoc 1m 56s trunk passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 1m 46s the patch passed
          +1 compile 8m 9s the patch passed
          +1 javac 8m 9s the patch passed
          -0 checkstyle 1m 49s root: The patch generated 8 new + 238 unchanged - 1 fixed = 246 total (was 239)
          +1 mvnsite 2m 5s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 10s the patch passed
          +1 javadoc 1m 52s the patch passed
          +1 unit 7m 26s hadoop-common in the patch passed.
          -1 unit 56m 51s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          136m 1s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13522
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831856/HADOOP-13522.007.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux db8a8f09d476 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c5ca216
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 41s Maven dependency ordering for branch +1 mvninstall 8m 28s trunk passed +1 compile 8m 16s trunk passed +1 checkstyle 1m 35s trunk passed +1 mvnsite 1m 59s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 3m 33s trunk passed +1 javadoc 1m 56s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 46s the patch passed +1 compile 8m 9s the patch passed +1 javac 8m 9s the patch passed -0 checkstyle 1m 49s root: The patch generated 8 new + 238 unchanged - 1 fixed = 246 total (was 239) +1 mvnsite 2m 5s the patch passed +1 mvneclipse 0m 36s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 10s the patch passed +1 javadoc 1m 52s the patch passed +1 unit 7m 26s hadoop-common in the patch passed. -1 unit 56m 51s hadoop-hdfs in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 136m 1s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13522 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831856/HADOOP-13522.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux db8a8f09d476 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c5ca216 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for updating the patch!

          Though, the toShort again needs to be converted to octal.

          My bad. Your new test case looks good. Now I have the following two comments.

          I can later expand the test case to include a match check against every permutation of possible values.

          Great! Let's do this in a separate jira after this issue.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for updating the patch! Though, the toShort again needs to be converted to octal. My bad. Your new test case looks good. Now I have the following two comments. Would you rebase the patch for the latest trunk? Would you remove trailing whitespaces? https://builds.apache.org/job/PreCommit-HADOOP-Build/10683/artifact/patchprocess/whitespace-eol.txt I can later expand the test case to include a match check against every permutation of possible values. Great! Let's do this in a separate jira after this issue.
          Hide
          algarbar Alex Garbarini added a comment -

          Thank you Akira for helping at each step!

          The patch has been updated for the latest trunk and the removal of whitespace.

          Build and test case both pass.

          Show
          algarbar Alex Garbarini added a comment - Thank you Akira for helping at each step! The patch has been updated for the latest trunk and the removal of whitespace. Build and test case both pass.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 1s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 24s Maven dependency ordering for branch
          +1 mvninstall 6m 54s trunk passed
          +1 compile 7m 12s trunk passed
          +1 checkstyle 1m 30s trunk passed
          +1 mvnsite 1m 49s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 7s trunk passed
          +1 javadoc 1m 29s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 37s the patch passed
          +1 compile 8m 56s the patch passed
          +1 javac 8m 56s the patch passed
          -0 checkstyle 1m 41s root: The patch generated 8 new + 214 unchanged - 1 fixed = 222 total (was 215)
          +1 mvnsite 2m 23s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 31s the patch passed
          +1 javadoc 1m 32s the patch passed
          +1 unit 8m 15s hadoop-common in the patch passed.
          +1 unit 61m 18s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          137m 59s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13522
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833850/HADOOP-13522.008.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 38819bcdda6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f5d9235
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10819/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10819/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10819/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 1s The patch appears to include 2 new or modified test files. 0 mvndep 1m 24s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 7m 12s trunk passed +1 checkstyle 1m 30s trunk passed +1 mvnsite 1m 49s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 7s trunk passed +1 javadoc 1m 29s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed +1 compile 8m 56s the patch passed +1 javac 8m 56s the patch passed -0 checkstyle 1m 41s root: The patch generated 8 new + 214 unchanged - 1 fixed = 222 total (was 215) +1 mvnsite 2m 23s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 31s the patch passed +1 javadoc 1m 32s the patch passed +1 unit 8m 15s hadoop-common in the patch passed. +1 unit 61m 18s hadoop-hdfs in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 137m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13522 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833850/HADOOP-13522.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 38819bcdda6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f5d9235 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10819/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10819/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10819/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, checking this in. This patch adds checkstyle warnings (indents), however, I'd like to make the indents consistent with other lines.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, checking this in. This patch adds checkstyle warnings (indents), however, I'd like to make the indents consistent with other lines.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Alex Garbarini for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Alex Garbarini for the contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10629 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10629/)
          HADOOP-13522. Add %A and %a formats for fs -stat command to print (aajisaka: rev bedfec0c10144087168bc79501ffd5ab4fa52606)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Stat.java
          • (edit) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
          • (edit) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10629 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10629/ ) HADOOP-13522 . Add %A and %a formats for fs -stat command to print (aajisaka: rev bedfec0c10144087168bc79501ffd5ab4fa52606) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Stat.java (edit) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java (edit) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java
          Hide
          algarbar Alex Garbarini added a comment -

          Thank you, Akira, for your patience and help teaching! I'm already hard at work on the next JIRA.

          Show
          algarbar Alex Garbarini added a comment - Thank you, Akira, for your patience and help teaching! I'm already hard at work on the next JIRA.

            People

            • Assignee:
              algarbar Alex Garbarini
              Reporter:
              algarbar Alex Garbarini
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development