Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13508

FsPermission string constructor does not recognize sticky bit

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.9.0, 3.0.0-alpha2, 2.8.2
        • Component/s: None
        • Labels:
          None

          Description

          FsPermissions's string constructor breaks on valid permission strings, like "1777".

          This is because FsPermission class naïvely uses UmaskParser to do it’s parsing of permissions: (from source code):
          public FsPermission(String mode)

          { this((new UmaskParser(mode)).getUMask()); }

          The mode string UMask accepts is subtly different (esp wrt sticky bit), so parsing Umask is not the same as parsing FsPermission.

          1. Text File
            HADOOP-13508.003.patch
            7 kB
            Chris Douglas
          2. Text File
            HADOOP-13508.004.patch
            7 kB
            Chris Douglas
          3. Text File
            HADOOP-13508.005.patch
            40 kB
            Chris Douglas
          4. Text File
            HADOOP-13508.006.patch
            39 kB
            Chris Douglas
          5. Text File
            HADOOP-13508.branch-2.patch
            40 kB
            Wei-Chiu Chuang
          6. Text File
            HADOOP-13508-1.patch
            1 kB
            Atul Sikaria
          7. Text File
            HADOOP-13508-2.patch
            1 kB
            Atul Sikaria

            Issue Links

            is required by

            Bug - A problem which impairs or prevents the functions of the product. HDFS-11084 Add a regression test for sticky bit support of OIV ReverseXML processor

            • Major - Major loss of function.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 16s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 mvninstall 7m 6s trunk passed
              +1 compile 6m 57s trunk passed
              +1 checkstyle 0m 21s trunk passed
              +1 mvnsite 0m 56s trunk passed
              +1 mvneclipse 0m 15s trunk passed
              +1 findbugs 1m 22s trunk passed
              +1 javadoc 0m 45s trunk passed
              +1 mvninstall 0m 36s the patch passed
              +1 compile 6m 44s the patch passed
              +1 javac 6m 44s the patch passed
              -0 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 2 new + 18 unchanged - 0 fixed = 20 total (was 18)
              +1 mvnsite 0m 51s the patch passed
              +1 mvneclipse 0m 12s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 31s the patch passed
              +1 javadoc 0m 46s the patch passed
              -1 unit 6m 42s hadoop-common in the patch failed.
              +1 asflicense 0m 22s The patch does not generate ASF License warnings.
              37m 32s



              Reason Tests
              Failed junit tests hadoop.security.TestLdapGroupsMapping
                hadoop.util.TestDiskChecker
                hadoop.security.ssl.TestSSLFactory
                hadoop.crypto.key.TestKeyShell
                hadoop.util.TestBasicDiskValidator
                hadoop.fs.TestHarFileSystemBasics
                hadoop.fs.TestLocalFileSystemPermission
                hadoop.security.alias.TestCredShell
                hadoop.security.alias.TestCredentialProviderFactory
                hadoop.crypto.key.TestKeyProviderFactory



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824240/HADOOP-13508-1.patch
              JIRA Issue HADOOP-13508
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux ea0f30007c64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / c575231
              Default Java 1.8.0_101
              findbugs v3.0.0
              checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10288/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10288/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10288/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10288/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 6s trunk passed +1 compile 6m 57s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 6m 44s the patch passed +1 javac 6m 44s the patch passed -0 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 2 new + 18 unchanged - 0 fixed = 20 total (was 18) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 46s the patch passed -1 unit 6m 42s hadoop-common in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 37m 32s Reason Tests Failed junit tests hadoop.security.TestLdapGroupsMapping   hadoop.util.TestDiskChecker   hadoop.security.ssl.TestSSLFactory   hadoop.crypto.key.TestKeyShell   hadoop.util.TestBasicDiskValidator   hadoop.fs.TestHarFileSystemBasics   hadoop.fs.TestLocalFileSystemPermission   hadoop.security.alias.TestCredShell   hadoop.security.alias.TestCredentialProviderFactory   hadoop.crypto.key.TestKeyProviderFactory Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824240/HADOOP-13508-1.patch JIRA Issue HADOOP-13508 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ea0f30007c64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c575231 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10288/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10288/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10288/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10288/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 9s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 mvninstall 8m 10s trunk passed
              +1 compile 7m 22s trunk passed
              +1 checkstyle 0m 24s trunk passed
              +1 mvnsite 1m 0s trunk passed
              +1 mvneclipse 0m 14s trunk passed
              +1 findbugs 1m 29s trunk passed
              +1 javadoc 0m 47s trunk passed
              +1 mvninstall 0m 42s the patch passed
              +1 compile 7m 24s the patch passed
              +1 javac 7m 24s the patch passed
              -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 2 new + 19 unchanged - 0 fixed = 21 total (was 19)
              +1 mvnsite 0m 59s the patch passed
              +1 mvneclipse 0m 12s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 45s the patch passed
              +1 javadoc 0m 50s the patch passed
              -1 unit 8m 33s hadoop-common in the patch failed.
              +1 asflicense 0m 24s The patch does not generate ASF License warnings.
              42m 13s



              Reason Tests
              Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager
                hadoop.fs.TestHarFileSystemBasics



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824296/HADOOP-13508-2.patch
              JIRA Issue HADOOP-13508
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux 8f8a33ac323a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / 913a895
              Default Java 1.8.0_101
              findbugs v3.0.0
              checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10295/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10295/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10295/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10295/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 10s trunk passed +1 compile 7m 22s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 29s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 7m 24s the patch passed +1 javac 7m 24s the patch passed -0 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 2 new + 19 unchanged - 0 fixed = 21 total (was 19) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 50s the patch passed -1 unit 8m 33s hadoop-common in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 42m 13s Reason Tests Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.fs.TestHarFileSystemBasics Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824296/HADOOP-13508-2.patch JIRA Issue HADOOP-13508 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8f8a33ac323a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 913a895 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10295/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10295/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10295/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10295/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              chris.douglas Chris Douglas added a comment -

              The UmaskParser also includes symbolic patterns for FsPermission, not just the short values supported by v2. That said, the parser doesn't seem to recognize the sticky bit in the symbolic representation, either. The regexp parser framework seems pretty heavy, but the bug fix can precede a rewrite.

              Also updated the unit test to check for the sticky bit in octal and to verify the symbolic constructors that work.

              Show
              chris.douglas Chris Douglas added a comment - The UmaskParser also includes symbolic patterns for FsPermission , not just the short values supported by v2. That said, the parser doesn't seem to recognize the sticky bit in the symbolic representation, either. The regexp parser framework seems pretty heavy, but the bug fix can precede a rewrite. Also updated the unit test to check for the sticky bit in octal and to verify the symbolic constructors that work.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 17s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 7m 14s trunk passed
              +1 compile 7m 27s trunk passed
              +1 checkstyle 0m 29s trunk passed
              +1 mvnsite 0m 57s trunk passed
              +1 mvneclipse 0m 13s trunk passed
              +1 findbugs 1m 25s trunk passed
              +1 javadoc 0m 46s trunk passed
              +1 mvninstall 0m 41s the patch passed
              +1 compile 7m 29s the patch passed
              +1 javac 7m 29s the patch passed
              -0 checkstyle 0m 35s hadoop-common-project/hadoop-common: The patch generated 520 new + 538 unchanged - 5 fixed = 1058 total (was 543)
              +1 mvnsite 0m 56s the patch passed
              +1 mvneclipse 0m 13s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 33s the patch passed
              +1 javadoc 0m 45s the patch passed
              -1 unit 8m 11s hadoop-common in the patch failed.
              +1 asflicense 0m 22s The patch does not generate ASF License warnings.
              41m 0s



              Reason Tests
              Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825350/HADOOP-13508.003.patch
              JIRA Issue HADOOP-13508
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux 7e4e7cabdf45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / a1f3293
              Default Java 1.8.0_101
              findbugs v3.0.0
              checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10361/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10361/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10361/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10361/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 14s trunk passed +1 compile 7m 27s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 41s the patch passed +1 compile 7m 29s the patch passed +1 javac 7m 29s the patch passed -0 checkstyle 0m 35s hadoop-common-project/hadoop-common: The patch generated 520 new + 538 unchanged - 5 fixed = 1058 total (was 543) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 45s the patch passed -1 unit 8m 11s hadoop-common in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 41m 0s Reason Tests Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825350/HADOOP-13508.003.patch JIRA Issue HADOOP-13508 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7e4e7cabdf45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a1f3293 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10361/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10361/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10361/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10361/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              chris.douglas Chris Douglas added a comment -

              Added to the unit test, validating the symbolic constructor as supported by the current matcher (i.e., *,o=[r][w]xt)

              Show
              chris.douglas Chris Douglas added a comment - Added to the unit test, validating the symbolic constructor as supported by the current matcher (i.e., *,o= [r] [w] xt )
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 14m 7s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 8m 1s trunk passed
              +1 compile 8m 44s trunk passed
              +1 checkstyle 0m 28s trunk passed
              +1 mvnsite 1m 4s trunk passed
              +1 mvneclipse 0m 13s trunk passed
              +1 findbugs 1m 30s trunk passed
              +1 javadoc 0m 47s trunk passed
              +1 mvninstall 0m 40s the patch passed
              +1 compile 6m 56s the patch passed
              +1 javac 6m 56s the patch passed
              -0 checkstyle 0m 37s hadoop-common-project/hadoop-common: The patch generated 520 new + 538 unchanged - 5 fixed = 1058 total (was 543)
              +1 mvnsite 0m 52s the patch passed
              +1 mvneclipse 0m 13s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 26s the patch passed
              +1 javadoc 0m 46s the patch passed
              -1 unit 7m 42s hadoop-common in the patch failed.
              +1 asflicense 0m 21s The patch does not generate ASF License warnings.
              55m 57s



              Reason Tests
              Failed junit tests hadoop.security.ssl.TestSSLFactory



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Issue HADOOP-13508
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825690/HADOOP-13508.004.patch
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux bca587e14a2f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / cde3a00
              Default Java 1.8.0_101
              findbugs v3.0.0
              checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10383/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10383/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10383/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10383/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 14m 7s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 1s trunk passed +1 compile 8m 44s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 6m 56s the patch passed +1 javac 6m 56s the patch passed -0 checkstyle 0m 37s hadoop-common-project/hadoop-common: The patch generated 520 new + 538 unchanged - 5 fixed = 1058 total (was 543) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 46s the patch passed -1 unit 7m 42s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 55m 57s Reason Tests Failed junit tests hadoop.security.ssl.TestSSLFactory Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13508 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825690/HADOOP-13508.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bca587e14a2f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cde3a00 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10383/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10383/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10383/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10383/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              chris.douglas Chris Douglas added a comment -

              Fix checkstyle

              Show
              chris.douglas Chris Douglas added a comment - Fix checkstyle
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              +1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 16s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 8m 9s trunk passed
              +1 compile 8m 11s trunk passed
              +1 checkstyle 0m 31s trunk passed
              +1 mvnsite 1m 5s trunk passed
              +1 mvneclipse 0m 14s trunk passed
              +1 findbugs 1m 17s trunk passed
              +1 javadoc 0m 47s trunk passed
              +1 mvninstall 0m 37s the patch passed
              +1 compile 6m 49s the patch passed
              +1 javac 6m 49s the patch passed
              -0 checkstyle 0m 31s hadoop-common-project/hadoop-common: The patch generated 512 new + 28 unchanged - 515 fixed = 540 total (was 543)
              +1 mvnsite 0m 52s the patch passed
              +1 mvneclipse 0m 13s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 25s the patch passed
              +1 javadoc 0m 46s the patch passed
              +1 unit 8m 8s hadoop-common in the patch passed.
              +1 asflicense 0m 21s The patch does not generate ASF License warnings.
              41m 37s



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Issue HADOOP-13508
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825704/HADOOP-13508.005.patch
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux be5fd16fd015 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / cde3a00
              Default Java 1.8.0_101
              findbugs v3.0.0
              checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10385/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10385/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10385/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 9s trunk passed +1 compile 8m 11s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 17s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 49s the patch passed +1 javac 6m 49s the patch passed -0 checkstyle 0m 31s hadoop-common-project/hadoop-common: The patch generated 512 new + 28 unchanged - 515 fixed = 540 total (was 543) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 8m 8s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 41m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13508 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825704/HADOOP-13508.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux be5fd16fd015 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cde3a00 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10385/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10385/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10385/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              chris.douglas Chris Douglas added a comment -

              FFS checkstyle...

              Show
              chris.douglas Chris Douglas added a comment - FFS checkstyle...
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              +1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 17s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 8m 6s trunk passed
              +1 compile 8m 37s trunk passed
              +1 checkstyle 0m 31s trunk passed
              +1 mvnsite 1m 2s trunk passed
              +1 mvneclipse 0m 14s trunk passed
              +1 findbugs 1m 32s trunk passed
              +1 javadoc 0m 48s trunk passed
              +1 mvninstall 0m 41s the patch passed
              +1 compile 8m 27s the patch passed
              +1 javac 8m 27s the patch passed
              +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 28 unchanged - 515 fixed = 28 total (was 543)
              +1 mvnsite 0m 59s the patch passed
              +1 mvneclipse 0m 14s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 1m 40s the patch passed
              +1 javadoc 0m 47s the patch passed
              +1 unit 9m 8s hadoop-common in the patch passed.
              +1 asflicense 0m 21s The patch does not generate ASF License warnings.
              45m 12s



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:9560f25
              JIRA Issue HADOOP-13508
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825715/HADOOP-13508.006.patch
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux f55f38a2871c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / 407b519
              Default Java 1.8.0_101
              findbugs v3.0.0
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10387/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10387/console
              Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 6s trunk passed +1 compile 8m 37s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 41s the patch passed +1 compile 8m 27s the patch passed +1 javac 8m 27s the patch passed +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 28 unchanged - 515 fixed = 28 total (was 543) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 40s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 9m 8s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 45m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13508 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12825715/HADOOP-13508.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f55f38a2871c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 407b519 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10387/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10387/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              ASikaria Atul Sikaria added a comment -

              Looks reasonable - thanks Chris.

              Agree that the general parsing approach here should be looked at in the future, but this addresses current problem of not being able to parse valid permission strings.

              Show
              ASikaria Atul Sikaria added a comment - Looks reasonable - thanks Chris. Agree that the general parsing approach here should be looked at in the future, but this addresses current problem of not being able to parse valid permission strings.
              Hide
              Permalink
              chris.douglas Chris Douglas added a comment -

              +1

              I committed this. Thanks Atul

              Show
              chris.douglas Chris Douglas added a comment - +1 I committed this. Thanks Atul
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Is it an incompatible change? I wonder if it make sense to backoprt to branch-2.

              OIV ReverseXML tool fails to reconstruct a fsimage that has sticky bit because of this bug.

              Show
              jojochuang Wei-Chiu Chuang added a comment - Is it an incompatible change? I wonder if it make sense to backoprt to branch-2. OIV ReverseXML tool fails to reconstruct a fsimage that has sticky bit because of this bug.
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              I am reopening this issue to backport the fix to branch-2.

              Please shout out if you think this is incompatible change (e.g. downstream applications that depends on existing semantics). Thanks.

              Show
              jojochuang Wei-Chiu Chuang added a comment - I am reopening this issue to backport the fix to branch-2. Please shout out if you think this is incompatible change (e.g. downstream applications that depends on existing semantics). Thanks.
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Submit branch-2 patch for precommit check.

              Show
              jojochuang Wei-Chiu Chuang added a comment - Submit branch-2 patch for precommit check.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 18m 14s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 7m 32s branch-2 passed
              +1 compile 5m 47s branch-2 passed with JDK v1.8.0_111
              +1 compile 6m 44s branch-2 passed with JDK v1.7.0_121
              +1 checkstyle 0m 31s branch-2 passed
              +1 mvnsite 1m 4s branch-2 passed
              +1 mvneclipse 0m 15s branch-2 passed
              +1 findbugs 1m 50s branch-2 passed
              +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_111
              +1 javadoc 1m 0s branch-2 passed with JDK v1.7.0_121
              +1 mvninstall 0m 45s the patch passed
              +1 compile 6m 30s the patch passed with JDK v1.8.0_111
              +1 javac 6m 30s the patch passed
              +1 compile 7m 3s the patch passed with JDK v1.7.0_121
              +1 javac 7m 3s the patch passed
              +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 29 unchanged - 515 fixed = 29 total (was 544)
              +1 mvnsite 1m 5s the patch passed
              +1 mvneclipse 0m 16s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 2m 0s the patch passed
              +1 javadoc 0m 52s the patch passed with JDK v1.8.0_111
              +1 javadoc 1m 0s the patch passed with JDK v1.7.0_121
              -1 unit 8m 22s hadoop-common in the patch failed with JDK v1.7.0_121.
              +1 asflicense 0m 24s The patch does not generate ASF License warnings.
              82m 55s



              Reason Tests
              JDK v1.8.0_111 Failed junit tests hadoop.net.TestDNS
              JDK v1.7.0_121 Failed junit tests hadoop.net.TestDNS



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:b59b8b7
              JIRA Issue HADOOP-13508
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843077/HADOOP-13508.branch-2.patch
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux 0e499e234435 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision branch-2 / eaa50a1
              Default Java 1.7.0_121
              Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
              findbugs v3.0.0
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11286/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_121.txt
              JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11286/testReport/
              modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11286/console
              Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 18m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 32s branch-2 passed +1 compile 5m 47s branch-2 passed with JDK v1.8.0_111 +1 compile 6m 44s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 31s branch-2 passed +1 mvnsite 1m 4s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 50s branch-2 passed +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_111 +1 javadoc 1m 0s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 45s the patch passed +1 compile 6m 30s the patch passed with JDK v1.8.0_111 +1 javac 6m 30s the patch passed +1 compile 7m 3s the patch passed with JDK v1.7.0_121 +1 javac 7m 3s the patch passed +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 29 unchanged - 515 fixed = 29 total (was 544) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 0s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_111 +1 javadoc 1m 0s the patch passed with JDK v1.7.0_121 -1 unit 8m 22s hadoop-common in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 82m 55s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.net.TestDNS JDK v1.7.0_121 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-13508 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843077/HADOOP-13508.branch-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0e499e234435 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / eaa50a1 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11286/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11286/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11286/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              The test failure is unrelated. Committing branch-2 patch.

              Show
              jojochuang Wei-Chiu Chuang added a comment - The test failure is unrelated. Committing branch-2 patch.
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Committed the patch to branch-2.

              Show
              jojochuang Wei-Chiu Chuang added a comment - Committed the patch to branch-2.
              Hide
              Permalink
              jojochuang Wei-Chiu Chuang added a comment -

              Pushed the commit into branch-2.8

              Show
              jojochuang Wei-Chiu Chuang added a comment - Pushed the commit into branch-2.8
              Hide
              Permalink
              vinodkv Vinod Kumar Vavilapalli added a comment -

              2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

              Show
              vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

                People

                • Assignee:
                  ASikaria Atul Sikaria
                  Reporter:
                  ASikaria Atul Sikaria
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development