Details
-
Type:
Improvement
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.7.0
-
Fix Version/s: 2.8.0, 3.0.0-alpha1
-
Component/s: security
-
Labels:None
-
Hadoop Flags:Reviewed
Description
In SaslRpcClient#getServerPrincipal, it only printed out server advertised principal. The actual principal we expect from configuration is quite useful while debugging security related issues. It should also be logged.
Issue Links
- is duplicated by
-
HADOOP-13056
Print expected values when rejecting a server's determined principal
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 16s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 6m 42s | trunk passed |
| +1 | compile | 6m 46s | trunk passed |
| +1 | checkstyle | 0m 24s | trunk passed |
| +1 | mvnsite | 0m 54s | trunk passed |
| +1 | mvneclipse | 0m 12s | trunk passed |
| +1 | findbugs | 1m 16s | trunk passed |
| +1 | javadoc | 0m 45s | trunk passed |
| +1 | mvninstall | 0m 37s | the patch passed |
| +1 | compile | 6m 47s | the patch passed |
| +1 | javac | 6m 47s | the patch passed |
| +1 | checkstyle | 0m 24s | the patch passed |
| +1 | mvnsite | 0m 51s | the patch passed |
| +1 | mvneclipse | 0m 13s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 | findbugs | 1m 46s | hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 | javadoc | 0m 51s | the patch passed |
| +1 | unit | 9m 17s | hadoop-common in the patch passed. |
| +1 | asflicense | 0m 22s | The patch does not generate ASF License warnings. |
| 39m 50s |
| Reason | Tests |
|---|---|
| FindBugs | module:hadoop-common-project/hadoop-common |
| Redundant nullcheck of StringBuilder.toString(), which is known to be non-null in org.apache.hadoop.security.SaslRpcClient.getServerPrincipal(RpcHeaderProtos$RpcSaslProto$SaslAuth) Redundant null check at SaslRpcClient.java:is known to be non-null in org.apache.hadoop.security.SaslRpcClient.getServerPrincipal(RpcHeaderProtos$RpcSaslProto$SaslAuth) Redundant null check at SaslRpcClient.java:[line 337] |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12824034/HADOOP-13503.000.patch |
| JIRA Issue | |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux 7bcde30e31dc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 2353271 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HADOOP-Build/10267/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/10267/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/10267/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Findbugs seems a bit unhappy here
Thanks Steve Loughran for review. I changed the log a bit, and posted the patch v001.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 14s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 7m 1s | trunk passed |
| +1 | compile | 6m 54s | trunk passed |
| +1 | checkstyle | 0m 23s | trunk passed |
| +1 | mvnsite | 0m 54s | trunk passed |
| +1 | mvneclipse | 0m 13s | trunk passed |
| +1 | findbugs | 1m 19s | trunk passed |
| +1 | javadoc | 0m 45s | trunk passed |
| +1 | mvninstall | 0m 37s | the patch passed |
| +1 | compile | 7m 19s | the patch passed |
| +1 | javac | 7m 19s | the patch passed |
| +1 | checkstyle | 0m 23s | the patch passed |
| +1 | mvnsite | 0m 51s | the patch passed |
| +1 | mvneclipse | 0m 13s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | findbugs | 1m 26s | the patch passed |
| +1 | javadoc | 0m 45s | the patch passed |
| +1 | unit | 8m 26s | hadoop-common in the patch passed. |
| +1 | asflicense | 0m 21s | The patch does not generate ASF License warnings. |
| 39m 30s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12824230/HADOOP-13503.001.patch |
| JIRA Issue | |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux 4d84d61dc952 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / e3037c5 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/10284/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/10284/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
The findbugs is gone. Is v001 good? Steve Loughran thanks.
Posted patch v002 that removed isPrincipalValid, thanks Jing Zhao for offline review.
+1 for the v002 patch pending Jenkins. Thanks for the improvement Xiaobing Zhou.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 10s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 8m 5s | trunk passed |
| +1 | compile | 8m 8s | trunk passed |
| +1 | checkstyle | 0m 27s | trunk passed |
| +1 | mvnsite | 1m 0s | trunk passed |
| +1 | mvneclipse | 0m 13s | trunk passed |
| +1 | findbugs | 1m 22s | trunk passed |
| +1 | javadoc | 0m 45s | trunk passed |
| +1 | mvninstall | 0m 41s | the patch passed |
| +1 | compile | 7m 5s | the patch passed |
| +1 | javac | 7m 5s | the patch passed |
| +1 | checkstyle | 0m 25s | the patch passed |
| +1 | mvnsite | 0m 56s | the patch passed |
| +1 | mvneclipse | 0m 13s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | findbugs | 1m 45s | the patch passed |
| +1 | javadoc | 0m 45s | the patch passed |
| +1 | unit | 7m 17s | hadoop-common in the patch passed. |
| +1 | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| 41m 8s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12824246/HADOOP-13503.002.patch |
| JIRA Issue | |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux e2bb4ad85cd0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c575231 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/10287/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/10287/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1 as well. Will commit the patch shortly.
I've committed the patch to trunk, branch-2 and branch-2.8. Thanks Xiaobing Zhou for the contribution. Thanks Arpit Agarwal and Steve Loughran for the review.
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10303 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10303/)
HADOOP-13503. Improve SaslRpcClient failure logging. Contributed by (jing9: rev c5c3e81b49ae6ef0cf9022f90f3709166aa4488d)
- (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
I posted initial patch v000, please help to review it, thanks.